From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBF6BC6FA82 for ; Wed, 14 Sep 2022 17:30:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229647AbiINRax (ORCPT ); Wed, 14 Sep 2022 13:30:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229609AbiINRaw (ORCPT ); Wed, 14 Sep 2022 13:30:52 -0400 Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CB8680365; Wed, 14 Sep 2022 10:30:51 -0700 (PDT) Received: by mail-qv1-xf33.google.com with SMTP id c6so12278061qvn.6; Wed, 14 Sep 2022 10:30:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=0L27G4iP/cuKuBXoxBJrd9C7v+AkXXve2e5WgZmnPFM=; b=OwNpFg7qm3P6LQcskO6h973FuZ5ZH5pqPhL9rSvFWvFDrm4IqvH2rasrZoz63gaIVM QBxwZeFlhTErfLCFnU/hBTKbTzaucoDPNVe+ec0H2jDaK8Ebhzi4iLc4B30cdh5SIP+J U/u8Q+X/XTfAqwup7cUdIYBZy2FMkUqtyZkZx1xbRc2bYhX/D4AOCAU6cAR2wn7cwBTv b/PDf4eVJsqSWzv4DCt6F0Fc7zS9N2yOjUi4GsS5Wj91RFeCQIxdy5ahy+ncakDr8iB6 Fxan9Mw9UOkoWGjPBTPYJun8O3wwAS+yMUT6j8hC6rwUjtVB9XEcsUqg/IOrwP18C5+W aNJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=0L27G4iP/cuKuBXoxBJrd9C7v+AkXXve2e5WgZmnPFM=; b=zB37yqYVwGp49Nxmoo0/lZHTwnyD0owHONmfIu0qSNIdzeGhAew/qCNUolvLPNkAiF fKQ9VZKbAZqT8qvD5bz/gWa6CmoiAqcJQfcyKiYoCUaEAwy1mfkHvHyiAs8IE5RmCjHG b3uOkOQaUA15yL4LkDkp59Yj3mt2Jb91DnkLssaZuIQX2bm+0Lm9SC1joLYTSCt1qpez a+pdyfB/AQ2GD+CDNOT2ihDa6X2MdpTxElWGpcLcqtrwHUaC5VXxtac5EdYhz5QWcbpD UJtnII5DkMMQf9rnKTM+66oHxswwFGfRO66grUV06EwFELsCsDY4K/tdICWCaV+NXzOK jTlA== X-Gm-Message-State: ACgBeo3rOrzdHGSIV7e/dENJHKEPAsHQdu6znGZk5YJPib1jviwaxdNU UdwOkwZ4lGRQkhHu5/Ksyyg= X-Google-Smtp-Source: AA6agR4NanY+oRAKCwumuYS4qynQNlgRdXUQ9CoMAaXbiNck4dr+MBmcWBG+TscWXqo8NNLfJw1SfA== X-Received: by 2002:a05:6214:2aaa:b0:4ac:acbd:7ef8 with SMTP id js10-20020a0562142aaa00b004acacbd7ef8mr16025208qvb.126.1663176650653; Wed, 14 Sep 2022 10:30:50 -0700 (PDT) Received: from [10.69.40.226] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id x8-20020ac85388000000b0035bafecff78sm1838006qtp.74.2022.09.14.10.30.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Sep 2022 10:30:50 -0700 (PDT) Message-ID: <4d715585-413d-a506-1bc0-1f12a0aec716@gmail.com> Date: Wed, 14 Sep 2022 10:30:45 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH 02/21] mm/hugetlb: correct max_huge_pages accounting on demote Content-Language: en-US To: Mike Kravetz Cc: Andrew Morton , Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Frank Rowand , Muchun Song , Mike Rapoport , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Borislav Petkov , "Paul E. McKenney" , Neeraj Upadhyay , Randy Dunlap , Damien Le Moal , Florian Fainelli , David Hildenbrand , Zi Yan , Oscar Salvador , Hari Bathini , Kees Cook , - , KOSAKI Motohiro , Mel Gorman , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux.dev References: <20220913195508.3511038-1-opendmb@gmail.com> <20220913195508.3511038-3-opendmb@gmail.com> From: Doug Berger In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 9/14/2022 10:23 AM, Mike Kravetz wrote: > On 09/13/22 12:54, Doug Berger wrote: >> When demoting a hugepage to a smaller order, the number of pages >> added to the target hstate will be the size of the large page >> divided by the size of the smaller page. >> >> Fixes: 8531fc6f52f5 ("hugetlb: add hugetlb demote page support") >> Signed-off-by: Doug Berger >> --- >> mm/hugetlb.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/mm/hugetlb.c b/mm/hugetlb.c >> index e070b8593b37..79949893ac12 100644 >> --- a/mm/hugetlb.c >> +++ b/mm/hugetlb.c >> @@ -3472,7 +3472,8 @@ static int demote_free_huge_page(struct hstate *h, struct page *page) >> * based on pool changes for the demoted page. >> */ >> h->max_huge_pages--; >> - target_hstate->max_huge_pages += pages_per_huge_page(h); >> + target_hstate->max_huge_pages += pages_per_huge_page(h) / >> + pages_per_huge_page(target_hstate); >> >> return rc; >> } > > This has already been fixed here, > > https://lore.kernel.org/linux-mm/20220823030209.57434-2-linmiaohe@huawei.com/ > Excellent! Thanks for the pointer and sorry for the noise. -Doug