Linux Documentation
 help / color / mirror / Atom feed
From: Zenghui Yu <yuzenghui@huawei.com>
To: Fuad Tabba <fuad.tabba@linux.dev>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Sean Christopherson <seanjc@google.com>, <kvm@vger.kernel.org>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	Huacai Chen <chenhuacai@kernel.org>, <linux-mips@vger.kernel.org>,
	Will Deacon <will@kernel.org>, Fuad Tabba <tabba@google.com>
Subject: Re: [PATCH 5/7] KVM: Fix comments that refer to non-existent identifiers
Date: Mon, 16 Nov 2026 19:56:27 +0800	[thread overview]
Message-ID: <4fb0e902-32c6-727f-7aaa-e1a7381dbe15@huawei.com> (raw)
In-Reply-To: <20261111085448.1130701-6-fuad.tabba@linux.dev>

On 2026/11/11 16:54, Fuad Tabba wrote:
> Comments in the generic KVM code and its headers refer to functions,
> structures, fields, capabilities and Kconfig symbols that have been
> misspelled or renamed. Use the current names.
> 
> Signed-off-by: Fuad Tabba <fuad.tabba@linux.dev>
> ---
>  include/linux/kvm_dirty_ring.h | 2 +-
>  include/linux/kvm_host.h       | 4 ++--
>  include/linux/kvm_irqfd.h      | 4 ++--
>  include/uapi/linux/kvm.h       | 2 +-
>  virt/kvm/binary_stats.c        | 2 +-
>  virt/kvm/eventfd.c             | 2 +-
>  virt/kvm/kvm_main.c            | 2 +-
>  7 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/include/linux/kvm_dirty_ring.h b/include/linux/kvm_dirty_ring.h
> index eb10d87adf7d5..8679ba17bd1ff 100644
> --- a/include/linux/kvm_dirty_ring.h
> +++ b/include/linux/kvm_dirty_ring.h
> @@ -29,7 +29,7 @@ struct kvm_dirty_ring {
>  
>  #ifndef CONFIG_HAVE_KVM_DIRTY_RING
>  /*
> - * If CONFIG_HAVE_HVM_DIRTY_RING not defined, kvm_dirty_ring.o should
> + * If CONFIG_HAVE_KVM_DIRTY_RING not defined, kvm_dirty_ring.o should
>   * not be included as well, so define these nop functions for the arch.
>   */

The comment looks a bit obscure. We can rewrite it as

" If CONFIG_HAVE_KVM_DIRTY_RING is not defined, dirty_ring.o will not be
  built either, so define these nop functions for the arch. "

And personally I tend to remove it :-)

Thanks,
Zenghui

  parent reply	other threads:[~2026-11-16 11:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11  8:54 [PATCH 0/7] KVM: Documentation and comment fixes Fuad Tabba
2026-11-11  8:54 ` [PATCH 1/7] Documentation: KVM: Fix references to non-existent identifiers Fuad Tabba
2026-11-16  1:30   ` Randy Dunlap
2026-11-16  9:32   ` Zenghui Yu
2026-11-16  9:56     ` Fuad Tabba
2026-11-11  8:54 ` [PATCH 2/7] Documentation: KVM: Fix lock names and a lock type in locking.rst Fuad Tabba
2026-11-11  8:54 ` [PATCH 3/7] Documentation: KVM: Fix the function that implements halt polling Fuad Tabba
2026-11-16  1:37   ` Randy Dunlap
2026-11-11  8:54 ` [PATCH 4/7] Documentation: KVM: Drop the stale number of vCPU request flags Fuad Tabba
2026-11-16  1:39   ` Randy Dunlap
2026-11-11  8:54 ` [PATCH 5/7] KVM: Fix comments that refer to non-existent identifiers Fuad Tabba
2026-11-11 21:31   ` Randy Dunlap
2026-11-16 11:56   ` Zenghui Yu [this message]
2026-11-11  8:54 ` [PATCH 6/7] KVM: Fix the range of reserved arch-independent request bits Fuad Tabba
2026-11-11  8:54 ` [PATCH 7/7] KVM: Fix typos in comments Fuad Tabba
2026-11-11 17:05   ` Randy Dunlap
2026-11-16  9:57     ` Fuad Tabba
2026-11-16 11:58 ` [PATCH 0/7] KVM: Documentation and comment fixes Zenghui Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4fb0e902-32c6-727f-7aaa-e1a7381dbe15@huawei.com \
    --to=yuzenghui@huawei.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=chenhuacai@kernel.org \
    --cc=corbet@lwn.net \
    --cc=frankja@linux.ibm.com \
    --cc=fuad.tabba@linux.dev \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=tabba@google.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox