From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA03536F41A; Mon, 2 Mar 2026 12:36:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772454992; cv=pass; b=t46U8a+dHQwXrR8WKWTx6K6VQ2GaRG0DuCms/XkHZD0NU5PXNNCgO0QPrwn3aUt46kYfaqnIji5NJBqeNb4DrckVdUsF4YwTTSw/4c9swmT9+X+tJAjaRKCrYSb5V0RVdNTTHXJd9dCKIJaraerbM0fql3FMNOuG2x0C8VjE7os= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772454992; c=relaxed/simple; bh=Nb0N2xb6ISesaRzRPry1Vsf4TBbNBm/ISxZYaLPdLuk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RI2GGIsZICZePy7uxf7DzajhLjVMpu0FQf4ccVLHbWIlFepV0NPNtMvyEifoIYliknR5Efv5arjiZc1qvG9MSAKVcGLb6/fp8v6M7yq8g+4jzt0/+EpnKSOKDhe2D4HXoaCTTxbymMS87GDU6mPt9v1SwIY63kH90oIagRsI32s= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=B7iz3Bd6; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="B7iz3Bd6" ARC-Seal: i=1; a=rsa-sha256; t=1772454928; cv=none; d=zohomail.com; s=zohoarc; b=EdM6kuDOOrBMjnk82Ujo+bVjEAXNVDAZBqVU/C5AIUuCTCpiFxwCZcpe03EWauXknbjeD766XJC5tJXnzS73vS3HbLrIVgx4rI/i1umJU3RCWVf4cWtY31b9OEOnDlRP22zfC84VoMNE73XFwNmWC4jeftCBL06vVeerlFo1Mxg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772454928; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=3BG6NbMJZCakv4h2SAqH1WDhyhJOxLlkoG0+u/X9t+w=; b=TiGFuMZyrE5Ol/sLoQp+n0ByX0Xz2NUfj2Wbg/OGQXHHc+WHNgMxrth2sK/DXaQUgopkpXqtj73ZFd4FpvtZVvJsUOXn5b909FImg8PufyEmX3POJt6RtJLYu6HzjrzyRCD24SyHVJo7YW4IT+h4B294hCJ/oza3vNm3PR0QHA8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1772454928; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=3BG6NbMJZCakv4h2SAqH1WDhyhJOxLlkoG0+u/X9t+w=; b=B7iz3Bd6S3S9gUGiY3IxUc2MxIUugQu7iDZrJ/yyGxTlAtxwtsUGr5Xe5CLIXEGc 4z1rqx/G6PEKW5Q98G92SaBOZWk7fscOfqGNo1g8UGj3WiRlrlT4fxUNnQkh/ltgEPS YLQ2mrmefuTXI3ooJRzKjrWdygiygyjjnqNTQ15g= Received: by mx.zohomail.com with SMTPS id 1772454925950111.09737166746925; Mon, 2 Mar 2026 04:35:25 -0800 (PST) From: Nicolas Frattaroli To: Dmitry Baryshkov Cc: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?UTF-8?B?S8O2bmln?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , Heiko =?UTF-8?B?U3TDvGJuZXI=?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Dmitry Baryshkov , Sascha Hauer , Rob Herring , Jonathan Corbet , Shuah Khan , kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-doc@vger.kernel.org, Andri Yngvason , Werner Sembach , Marius Vlad Subject: Re: [PATCH v9 02/19] drm: Add new general DRM property "color format" Date: Mon, 02 Mar 2026 13:35:16 +0100 Message-ID: <5081457.31r3eYUQgx@workhorse> In-Reply-To: References: <20260227-color-format-v9-0-658c3b9db7ef@collabora.com> <20260227-color-format-v9-2-658c3b9db7ef@collabora.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" On Sunday, 1 March 2026 17:47:48 Central European Standard Time Dmitry Baryshkov wrote: > On Fri, Feb 27, 2026 at 08:20:07PM +0100, Nicolas Frattaroli wrote: > > From: Andri Yngvason > > > > Add a new general DRM property named "color format" which can be used by > > userspace to request the display driver to output a particular color > > format. > > > > Possible options are: > > - auto (setup by default, driver internally picks the color format) > > - rgb > > - ycbcr444 > > - ycbcr422 > > - ycbcr420 > > > > Drivers should advertise from this list which formats they support. > > Together with this list and EDID data from the sink we should be able > > to relay a list of usable color formats to users to pick from. > > > > Signed-off-by: Werner Sembach > > Signed-off-by: Andri Yngvason > > Signed-off-by: Marius Vlad > > Signed-off-by: Nicolas Frattaroli > > --- > > drivers/gpu/drm/drm_atomic_helper.c | 5 ++ > > drivers/gpu/drm/drm_atomic_uapi.c | 11 ++++ > > drivers/gpu/drm/drm_connector.c | 124 ++++++++++++++++++++++++++++++++++++ > > include/drm/drm_connector.h | 103 ++++++++++++++++++++++++++++++ > > 4 files changed, 243 insertions(+) > > It seems and feels that the common code to be used (almost?) everywhere > would be: > > if (!drm_mode_create_color_format_property(connector, supported_formats)) > drm_connector_attach_color_format_property(connector); > > > Please mention somewhere the reason to split that into two functions. > There isn't one I can think of, I kept it as-is since I inherited the code like this and figured this was the expected convention based on drm_mode_create_hdmi_colorspace_property -> drm_connector_attach_colorspace_property. Quite possibly, the idea is that callers can choose to probe whether a certain set of parameters would allow the property to be created without attaching it during said probing, but that's speculation on my part. Having it work like drm_connector_attach_max_bpc_property may make more sense here, and I'll refactor it to do this in the next revision unless anyone has any objections. Kind regards, Nicolas Frattaroli