Re: [RFC PATCH 5/6] cpufreq/amd-pstate: Reduce the scope of exported symbols

[Mario Limonciello <superm1@kernel.org>]

On 6/30/26 14:03, K Prateek Nayak wrote:
> Symbols exported by amd-pstate.c are ever only needed for amd-pstate-ut.
> Introduce EXPORT_SYMBOL_FOR_PSTATE_UT() to export these symbols
> selectively to "amd-pstate-ut" namespace as opposed to all GPL modules.
> 
> No functional changes intended.
> 
> Signed-off-by: K Prateek Nayak <kprateek.nayak@amd.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
> ---
>   drivers/cpufreq/amd-pstate.c | 14 +++++++-------
>   drivers/cpufreq/amd-pstate.h |  7 +++++++
>   2 files changed, 14 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 61f30820d95a..44c03b0be219 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -75,7 +75,7 @@ const char *amd_pstate_get_mode_string(enum amd_pstate_mode mode)
>   		mode = AMD_PSTATE_UNDEFINED;
>   	return amd_pstate_mode_string[mode];
>   }
> -EXPORT_SYMBOL_GPL(amd_pstate_get_mode_string);
> +EXPORT_SYMBOL_FOR_PSTATE_UT(amd_pstate_get_mode_string);
>   
>   struct quirk_entry {
>   	u32 nominal_freq;
> @@ -1266,7 +1266,7 @@ void amd_pstate_clear_dynamic_epp(struct cpufreq_policy *policy)
>   	kfree(cpudata->profile_name);
>   	cpudata->dynamic_epp = false;
>   }
> -EXPORT_SYMBOL_GPL(amd_pstate_clear_dynamic_epp);
> +EXPORT_SYMBOL_FOR_PSTATE_UT(amd_pstate_clear_dynamic_epp);
>   
>   static int amd_pstate_set_dynamic_epp(struct cpufreq_policy *policy)
>   {
> @@ -1472,7 +1472,7 @@ ssize_t store_energy_performance_preference(struct cpufreq_policy *policy,
>   
>   	return count;
>   }
> -EXPORT_SYMBOL_GPL(store_energy_performance_preference);
> +EXPORT_SYMBOL_FOR_PSTATE_UT(store_energy_performance_preference);
>   
>   ssize_t show_energy_performance_preference(struct cpufreq_policy *policy, char *buf)
>   {
> @@ -1506,7 +1506,7 @@ ssize_t show_energy_performance_preference(struct cpufreq_policy *policy, char *
>   
>   	return sysfs_emit(buf, "%s\n", energy_perf_strings[preference]);
>   }
> -EXPORT_SYMBOL_GPL(show_energy_performance_preference);
> +EXPORT_SYMBOL_FOR_PSTATE_UT(show_energy_performance_preference);
>   
>   static ssize_t store_amd_pstate_floor_freq(struct cpufreq_policy *policy,
>   					   const char *buf, size_t count)
> @@ -1606,7 +1606,7 @@ struct freq_attr **amd_pstate_get_current_attrs(void)
>   		return NULL;
>   	return current_pstate_driver->attr;
>   }
> -EXPORT_SYMBOL_GPL(amd_pstate_get_current_attrs);
> +EXPORT_SYMBOL_FOR_PSTATE_UT(amd_pstate_get_current_attrs);
>   
>   static struct freq_attr **get_freq_attrs(void)
>   {
> @@ -1791,7 +1791,7 @@ int amd_pstate_get_status(void)
>   {
>   	return cppc_state;
>   }
> -EXPORT_SYMBOL_GPL(amd_pstate_get_status);
> +EXPORT_SYMBOL_FOR_PSTATE_UT(amd_pstate_get_status);
>   
>   int amd_pstate_update_status(const char *buf, size_t size)
>   {
> @@ -1811,7 +1811,7 @@ int amd_pstate_update_status(const char *buf, size_t size)
>   
>   	return 0;
>   }
> -EXPORT_SYMBOL_GPL(amd_pstate_update_status);
> +EXPORT_SYMBOL_FOR_PSTATE_UT(amd_pstate_update_status);
>   
>   static ssize_t status_show(struct device *dev,
>   			   struct device_attribute *attr, char *buf)
> diff --git a/drivers/cpufreq/amd-pstate.h b/drivers/cpufreq/amd-pstate.h
> index 23e8baa05849..edd697a5e29f 100644
> --- a/drivers/cpufreq/amd-pstate.h
> +++ b/drivers/cpufreq/amd-pstate.h
> @@ -11,6 +11,13 @@
>   #include <linux/pm_qos.h>
>   #include <linux/platform_profile.h>
>   
> +#if IS_MODULE(CONFIG_X86_AMD_PSTATE_UT)
> +#define EXPORT_SYMBOL_FOR_PSTATE_UT(symbol) \
> +	EXPORT_SYMBOL_FOR_MODULES(symbol, "amd-pstate-ut")
> +#else
> +#define EXPORT_SYMBOL_FOR_PSTATE_UT(symbol)
> +#endif
> +
>   /*********************************************************************
>    *                        AMD P-state INTERFACE                       *
>    *********************************************************************/