From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 815AE7D043 for ; Fri, 29 Jun 2018 12:10:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755271AbeF2MKG (ORCPT ); Fri, 29 Jun 2018 08:10:06 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:51618 "EHLO mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754720AbeF2MKF (ORCPT ); Fri, 29 Jun 2018 08:10:05 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id EEB0520E91; Fri, 29 Jun 2018 12:10:04 +0000 (UTC) Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo02-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z_m5gVBz6CoW; Fri, 29 Jun 2018 12:10:04 +0000 (UTC) Received: from [172.20.4.200] (unknown [50.236.218.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 1A95A20E8D; Fri, 29 Jun 2018 12:09:57 +0000 (UTC) Subject: Re: [PATCH] doc: dev-tools: kselftest.rst: update contributing new tests To: Anders Roxell , corbet@lwn.net Cc: linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20180629100248.11560-1-anders.roxell@linaro.org> From: Shuah Khan Message-ID: <53d599f2-44a1-c366-4a5c-2ca6cd19b031@kernel.org> Date: Fri, 29 Jun 2018 06:09:45 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180629100248.11560-1-anders.roxell@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 06/29/2018 04:02 AM, Anders Roxell wrote: > Add a description that kernel config options should be added into a > config file that is placed next to the newly added test. > > Signed-off-by: Anders Roxell > --- > Documentation/dev-tools/kselftest.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst > index 3bf371a938d0..4c546a35bd58 100644 > --- a/Documentation/dev-tools/kselftest.rst > +++ b/Documentation/dev-tools/kselftest.rst > @@ -156,6 +156,9 @@ Contributing new tests (details) > installed by the distro on the system should be the primary focus to be able > to find regressions. > > + * If a new test needs specific kernel options, they should be enabled in get rid of new > + then config file in the same directory where the test is added. "the config" instead of "then config" Rephrasing this might be better: "If a test needs specific kernel config options enabled, add a config file in the test directory to enable them. e.g: tools/testing/selftests/android/ion/config > + > Test Harness > ============ > > -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html