From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hendrik Hamerlinck <hendrik.hamerlinck@hammernet.be>,
dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com,
joe@perches.com, corbet@lwn.net, apw@canonical.com
Cc: skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev,
workflows@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: validate commit tag ordering
Date: Fri, 25 Jul 2025 10:42:20 +0200 [thread overview]
Message-ID: <53eb0068-008b-48e6-9b92-d92de2ed4fc9@kernel.org> (raw)
In-Reply-To: <20250724072032.118554-1-hendrik.hamerlinck@hammernet.be>
On 24/07/2025 09:20, Hendrik Hamerlinck wrote:
> Modified the checkpatch script to ensure that commit tags (e.g.,
> Signed-off-by, Reviewed-by, Acked-by, Tested-by, etc.) appear in the
> correct order according to kernel conventions [1].
These are not the conventions I use for my subsystems and ask others to
follow, so imposing TIP rules to all maintainers needs broad consensus,
not (yet) checkpatch.
What's more, I think above TIP rules are contradicting with existing,
widely used and approved toolset - b4. So no, if you want universal
tool, please use b4 or whatever b4 defines.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-25 8:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 7:20 [PATCH] checkpatch: validate commit tag ordering Hendrik Hamerlinck
2025-07-24 15:04 ` Akira Yokosawa
2025-07-24 19:10 ` Jeff Johnson
2025-07-24 19:43 ` Konstantin Ryabitsev
2025-07-25 8:42 ` Krzysztof Kozlowski [this message]
2025-07-31 11:55 ` Geert Uytterhoeven
2025-07-31 12:46 ` Krzysztof Kozlowski
2025-08-01 7:55 ` Jani Nikula
2025-08-02 10:12 ` Mauro Carvalho Chehab
2025-08-02 16:26 ` Konstantin Ryabitsev
2025-07-26 7:34 ` Hendrik Hamerlinck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53eb0068-008b-48e6-9b92-d92de2ed4fc9@kernel.org \
--to=krzk@kernel.org \
--cc=apw@canonical.com \
--cc=corbet@lwn.net \
--cc=dwaipayanray1@gmail.com \
--cc=hendrik.hamerlinck@hammernet.be \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).