From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 874D5C00140 for ; Sun, 31 Jul 2022 17:49:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230208AbiGaRti (ORCPT ); Sun, 31 Jul 2022 13:49:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbiGaRth (ORCPT ); Sun, 31 Jul 2022 13:49:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7998DB4A9; Sun, 31 Jul 2022 10:49:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C697260FEB; Sun, 31 Jul 2022 17:49:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD7C1C433D6; Sun, 31 Jul 2022 17:49:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659289772; bh=3A75P4su/8E8y0yASTst8ObkOtAbAvd6xg9cUj4Lnl0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FP5onuuDGImR7EX5M/M6q1jONwRdIgLbCc3URSda8B83ujN+FuZUBt896XxObyGat Y3Zg0Oq/ZT4tKNn+DUDAfR37zHEtBtpCCnJI6xtdSRDQk8TdSIX9+tfwO9T6PM9ymw JXHw6d7/kQsGlsUE1nCLFNhzyUewU3aykapVm9bC2xBgUanobR1trQajZsc2yL3Kh9 An/F1TQdq78gZw7YHPzIlFS8/V0CcdUSGkS+d4lmuc9subCB9j6Pyit9l3MXMNew/0 hXgsyiLBEd7dKXrAZM6QKHUhGyJ8A/oLkP5UMfaJhSnZHaAInKYgL6Ws/LizpNvhJz E7aJzLObwjJQA== Message-ID: <5431c5e4-a8b0-738c-5143-3976cb904b9a@kernel.org> Date: Sun, 31 Jul 2022 19:49:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V9 01/16] rv: Add Runtime Verification (RV) interface Content-Language: en-US To: Steven Rostedt , Tao Zhou Cc: Wim Van Sebroeck , Guenter Roeck , Jonathan Corbet , Ingo Molnar , Thomas Gleixner , Peter Zijlstra , Will Deacon , Catalin Marinas , Marco Elver , Dmitry Vyukov , "Paul E. McKenney" , Shuah Khan , Gabriele Paoloni , Juri Lelli , Clark Williams , Randy Dunlap , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org References: <0197dd47-ea15-4d8b-5fc7-e466d8a501a7@kernel.org> <20220731124730.311c8207@rorschach.local.home> <20220731130144.26576a6a@rorschach.local.home> From: Daniel Bristot de Oliveira In-Reply-To: <20220731130144.26576a6a@rorschach.local.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 7/31/22 19:01, Steven Rostedt wrote: > static int da_monitor_init_##name(void) \ > { \ > int slot; \ > \ > slot = rv_get_task_monitor_slot(); <- if this returns positive, things break \ > if (slot < 0 || slot >= RV_PER_TASK_MONITOR_INIT) \ > > And we probably need slot to be negative if it is greater or equal to RV_PER_TASK_MONITOR_INIT. > > return slot; \ > ok, there will be a problem when RV_PER_TASK_MONITOR_INIT changes to > 1. This will need to be patched to return negative. So far we have only one because there is only one per task monitor. -- Daniel