From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E8D6C388F9 for ; Wed, 21 Oct 2020 16:56:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4231223C7 for ; Wed, 21 Oct 2020 16:56:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EV0zodmV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2503237AbgJUQ4U (ORCPT ); Wed, 21 Oct 2020 12:56:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:33876 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2503235AbgJUQ4U (ORCPT ); Wed, 21 Oct 2020 12:56:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603299378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YpWDrSQ0xS4iFl6zf0HLMlyff6mhU5Ears3TWXC/4Ho=; b=EV0zodmVWO4hXI+oHamzrLId58LDwWPavX7LGPhFHP/vnA1PnSBP2qWLZ5OpGVL7hmHo8L 85RVMZY5Gualoog7fM41SHm0hGTBMxizUHmVaXmtOtekv0uEYTnoFNCb7XAtHbqbvUEUh0 0i+5f1fFbyR0mSMuC6yKvXD/9mRtNlQ= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-155-mrD2q8S0PUyaIFO2lDIUkg-1; Wed, 21 Oct 2020 12:56:14 -0400 X-MC-Unique: mrD2q8S0PUyaIFO2lDIUkg-1 Received: by mail-qv1-f72.google.com with SMTP id h12so1675551qvk.22 for ; Wed, 21 Oct 2020 09:56:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:organization:user-agent:mime-version :content-transfer-encoding; bh=YpWDrSQ0xS4iFl6zf0HLMlyff6mhU5Ears3TWXC/4Ho=; b=CDZ+a2/jINL8GjeQWtq89QGnmnAqh1GrH3NxFRwcaPtc1CP/gStGcPiJu/R4ftg/x0 aPLFORF04wDi7XL/xG6p4i3gAreMteO7tq/4Sg2AKQREH2RO1b+g5SXhLN1f/bNhLS5B w61vyGKThDHn7eQx4g75cRlUsHtd4NLFFr7kgmjR5S+jZch2Rice4UAFmTlUYNIKBZk7 J/YHD6gEAG8RryX1m2h8EUsHuOgiDAChL/K0JhfpD1+LWFqRUqKalxE40qCHaOe0K7lg CKtUT2NzbXRgiM18IEIjpA2ezo2vqsLqdgWrSqKqK/3BfPPdhJQJ/0eVmAZV73ULXRAE FOYQ== X-Gm-Message-State: AOAM533VFdQbOIjzasoaw80dynYxNVviKWMVwh9BcMtr16+d2frU4MN8 wUY4KL9MWYJB0Tz5tkZ1geBdvoX3hr2IojL5uorD3AR4o93NgBGaIyXIUYtrjAFMMzTrNM+McmH rbUwPtMs1rQd/F/YICk4K X-Received: by 2002:a05:620a:142d:: with SMTP id k13mr3922510qkj.315.1603299373817; Wed, 21 Oct 2020 09:56:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx2v8PeoZ/a94ls9zOIyKWksYLW/NAN8enNJ9jX43dkLHUQkSE464KGbP6E/4BzXTqrq+S0iw== X-Received: by 2002:a05:620a:142d:: with SMTP id k13mr3922487qkj.315.1603299373526; Wed, 21 Oct 2020 09:56:13 -0700 (PDT) Received: from Ruby.lyude.net (pool-108-49-102-102.bstnma.fios.verizon.net. [108.49.102.102]) by smtp.gmail.com with ESMTPSA id 19sm1575196qki.33.2020.10.21.09.56.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Oct 2020 09:56:12 -0700 (PDT) Message-ID: <54b001e1748fd3d80c711181521e5cf1ec6875eb.camel@redhat.com> Subject: Re: [PATCH v2 12/24] drm/dp: fix a kernel-doc issue at drm_edid.c From: Lyude Paul To: Mauro Carvalho Chehab Cc: Linux Doc Mailing List , Jonathan Corbet , Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= , Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Wed, 21 Oct 2020 12:56:11 -0400 In-Reply-To: <20201021121108.51972144@coco.lan> References: <96d648f86024535e5f7d5b0caf8ebf93c7f8eaab.1602590106.git.mchehab+huawei@kernel.org> <20201021121108.51972144@coco.lan> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Ah, good point. It looks like you've already added the drm-misc-next and drm maintainers to here so as long as they're aware that should be fine On Wed, 2020-10-21 at 12:11 +0200, Mauro Carvalho Chehab wrote: > Hi Lyude, > > Em Tue, 13 Oct 2020 15:49:11 -0400 > Lyude Paul escreveu: > > > wait, I think there's some confusion here. these patches have already been > > pushed > > As the patch adding the warning was merged upstream at the 5.10 merge > window, the fixup one should also be added there, instead of waiting > until 5.11 ;-) > > So, if OK for you, I'll send this upstream via my tree by the end of > the merge window, as our goal is that 5.10 won't have doc warnings. > > Regards, > Mauro > > > > On Tue, 2020-10-13 at 14:14 +0200, Mauro Carvalho Chehab wrote: > > > The name of the argument is different, causing those warnings: > > > > > > ./drivers/gpu/drm/drm_edid.c:3754: warning: Function parameter or > > > member > > > 'video_code' not described in 'drm_display_mode_from_cea_vic' > > > ./drivers/gpu/drm/drm_edid.c:3754: warning: Excess function parameter > > > 'vic' description in 'drm_display_mode_from_cea_vic' > > > > > > Fixes: 7af655bce275 ("drm/dp: Add drm_dp_downstream_mode()") > > > Signed-off-by: Mauro Carvalho Chehab > > > --- > > > drivers/gpu/drm/drm_edid.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > > > index a82f37d44258..631125b46e04 100644 > > > --- a/drivers/gpu/drm/drm_edid.c > > > +++ b/drivers/gpu/drm/drm_edid.c > > > @@ -3741,7 +3741,7 @@ drm_add_cmdb_modes(struct drm_connector > > > *connector, u8 > > > svd) > > > /** > > > * drm_display_mode_from_cea_vic() - return a mode for CEA VIC > > > * @dev: DRM device > > > - * @vic: CEA VIC of the mode > > > + * @video_code: CEA VIC of the mode > > > * > > > * Creates a new mode matching the specified CEA VIC. > > > * > > > Thanks, > Mauro > -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat