From: Paolo Abeni <pabeni@redhat.com>
To: chia-yu.chang@nokia-bell-labs.com, edumazet@google.com,
linux-doc@vger.kernel.org, corbet@lwn.net, horms@kernel.org,
dsahern@kernel.org, kuniyu@amazon.com, bpf@vger.kernel.org,
netdev@vger.kernel.org, dave.taht@gmail.com, jhs@mojatatu.com,
kuba@kernel.org, stephen@networkplumber.org,
xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
andrew+netdev@lunn.ch, donald.hunter@gmail.com, ast@fiberby.net,
liuhangbin@gmail.com, shuah@kernel.org,
linux-kselftest@vger.kernel.org, ij@kernel.org,
ncardwell@google.com, koen.de_schepper@nokia-bell-labs.com,
g.white@cablelabs.com, ingemar.s.johansson@ericsson.com,
mirja.kuehlewind@ericsson.com, cheshire@apple.com,
rs.ietf@gmx.at, Jason_Livingood@comcast.com,
vidhi_goel@apple.com
Subject: Re: [PATCH v8 net-next 11/15] tcp: accecn: AccECN option failure handling
Date: Tue, 17 Jun 2025 11:44:21 +0200 [thread overview]
Message-ID: <558d81d1-3cd0-41f8-87b1-aa7be05f2924@redhat.com> (raw)
In-Reply-To: <20250610125314.18557-12-chia-yu.chang@nokia-bell-labs.com>
On 6/10/25 2:53 PM, chia-yu.chang@nokia-bell-labs.com wrote:
> diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
> index 3de6641c776e..d7cdc6589a9c 100644
> --- a/net/ipv4/tcp_output.c
> +++ b/net/ipv4/tcp_output.c
> @@ -1087,6 +1087,7 @@ static unsigned int tcp_syn_options(struct sock *sk, struct sk_buff *skb,
> /* Simultaneous open SYN/ACK needs AccECN option but not SYN */
> if (unlikely((TCP_SKB_CB(skb)->tcp_flags & TCPHDR_ACK) &&
> tcp_ecn_mode_accecn(tp) &&
> + inet_csk(sk)->icsk_retransmits < 2 &&
> sock_net(sk)->ipv4.sysctl_tcp_ecn_option &&
> remaining >= TCPOLEN_ACCECN_BASE)) {
> u32 saving = tcp_synack_options_combine_saving(opts);
AFAICS here the AccECN option is allowed even on the first retransmit as
opposed of what enforced for synack packets and what stated in the
commit message. Why?
Either code change or code/commit message comment needed.
Thanks,
Paolo
next prev parent reply other threads:[~2025-06-17 9:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 12:52 [PATCH v8 net-next 00/15] AccECN protocol patch series chia-yu.chang
2025-06-10 12:53 ` [PATCH v8 net-next 01/15] tcp: reorganize SYN ECN code chia-yu.chang
2025-06-10 12:53 ` [PATCH v8 net-next 02/15] tcp: fast path functions later chia-yu.chang
2025-06-10 12:53 ` [PATCH v8 net-next 03/15] tcp: reorganize tcp_sock_write_txrx group for variables later chia-yu.chang
2025-06-10 12:53 ` [PATCH v8 net-next 04/15] tcp: AccECN core chia-yu.chang
2025-06-17 8:03 ` Paolo Abeni
2025-06-20 8:57 ` Chia-Yu Chang (Nokia)
2025-06-10 12:53 ` [PATCH v8 net-next 05/15] tcp: accecn: AccECN negotiation chia-yu.chang
2025-06-10 12:53 ` [PATCH v8 net-next 06/15] tcp: accecn: add AccECN rx byte counters chia-yu.chang
2025-06-10 12:53 ` [PATCH v8 net-next 07/15] tcp: accecn: AccECN needs to know delivered bytes chia-yu.chang
2025-06-10 12:53 ` [PATCH v8 net-next 08/15] tcp: sack option handling improvements chia-yu.chang
2025-06-10 12:53 ` [PATCH v8 net-next 09/15] tcp: accecn: AccECN option chia-yu.chang
2025-06-17 9:27 ` Paolo Abeni
2025-06-17 18:43 ` Ilpo Järvinen
2025-06-20 23:22 ` Chia-Yu Chang (Nokia)
2025-06-24 6:39 ` Paolo Abeni
2025-06-10 12:53 ` [PATCH v8 net-next 10/15] tcp: accecn: AccECN option send control chia-yu.chang
2025-06-10 12:53 ` [PATCH v8 net-next 11/15] tcp: accecn: AccECN option failure handling chia-yu.chang
2025-06-17 9:44 ` Paolo Abeni [this message]
2025-06-10 12:53 ` [PATCH v8 net-next 12/15] tcp: accecn: AccECN option ceb/cep heuristic chia-yu.chang
2025-06-10 12:53 ` [PATCH v8 net-next 13/15] tcp: accecn: AccECN ACE field multi-wrap heuristic chia-yu.chang
2025-06-10 12:53 ` [PATCH v8 net-next 14/15] tcp: accecn: try to fit AccECN option with SACK chia-yu.chang
2025-06-10 12:53 ` [PATCH v8 net-next 15/15] tcp: try to avoid safer when ACKs are thinned chia-yu.chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558d81d1-3cd0-41f8-87b1-aa7be05f2924@redhat.com \
--to=pabeni@redhat.com \
--cc=Jason_Livingood@comcast.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@fiberby.net \
--cc=bpf@vger.kernel.org \
--cc=cheshire@apple.com \
--cc=chia-yu.chang@nokia-bell-labs.com \
--cc=corbet@lwn.net \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=g.white@cablelabs.com \
--cc=horms@kernel.org \
--cc=ij@kernel.org \
--cc=ingemar.s.johansson@ericsson.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=koen.de_schepper@nokia-bell-labs.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=mirja.kuehlewind@ericsson.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=rs.ietf@gmx.at \
--cc=shuah@kernel.org \
--cc=stephen@networkplumber.org \
--cc=vidhi_goel@apple.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).