From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 7DA0E7E6A5 for ; Tue, 17 Apr 2018 22:06:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752707AbeDQWGE (ORCPT ); Tue, 17 Apr 2018 18:06:04 -0400 Received: from mga09.intel.com ([134.134.136.24]:17300 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752606AbeDQWGD (ORCPT ); Tue, 17 Apr 2018 18:06:03 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2018 15:06:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,464,1517904000"; d="scan'208";a="192288160" Received: from yoojae-mobl1.amr.corp.intel.com (HELO [10.7.153.150]) ([10.7.153.150]) by orsmga004.jf.intel.com with ESMTP; 17 Apr 2018 15:06:02 -0700 Subject: Re: [PATCH v3 04/10] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs From: Jae Hyun Yoo To: Rob Herring Cc: Alan Cox , Andrew Jeffery , Andrew Lunn , Andy Shevchenko , Arnd Bergmann , Benjamin Herrenschmidt , Fengguang Wu , Greg KH , Guenter Roeck , Haiyue Wang , James Feist , Jason M Biils , Jean Delvare , Joel Stanley , Julia Cartwright , Miguel Ojeda , Milton Miller II , Pavel Machek , Randy Dunlap , Stef van Os , Sumeet R Pawnikar , Vernon Mauery , "linux-kernel@vger.kernel.org" , linux-doc@vger.kernel.org, devicetree@vger.kernel.org, Linux HWMON List , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , OpenBMC Maillist References: <20180410183212.16787-1-jae.hyun.yoo@linux.intel.com> <20180410183212.16787-5-jae.hyun.yoo@linux.intel.com> <20180416181035.rcjvt4rlrwaj5yxf@rob-hp-laptop> <53ff5b2b-eba8-8311-64a9-abd4bc72226d@linux.intel.com> Message-ID: <584aca6c-c87a-ff7a-2fdc-3c742236be60@linux.intel.com> Date: Tue, 17 Apr 2018 15:06:02 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 4/17/2018 11:16 AM, Jae Hyun Yoo wrote: > On 4/17/2018 6:16 AM, Rob Herring wrote: >> On Mon, Apr 16, 2018 at 6:12 PM, Jae Hyun Yoo >> wrote: >>> On 4/16/2018 11:10 AM, Rob Herring wrote: >>>> >>>> On Tue, Apr 10, 2018 at 11:32:06AM -0700, Jae Hyun Yoo wrote: >>>>> >>>>> This commit adds a dt-bindings document of PECI adapter driver for >>>>> Aspeed >>>>> AST24xx/25xx SoCs. >> >> [...] >> >>>>> +- clocks            : Should contain clock source for PECI >>>>> controller. >>>>> +                     Should reference clkin. >>>>> +- clock_frequency   : Should contain the operation frequency of PECI >>>>> controller >>>>> +                     in units of Hz. >>>>> +                     187500 ~ 24000000 >>>> >>>> >>>> This is the frequency of the bus or used to derive it? It would be >>>> better to specify the bus frequency instead and have the driver >>>> calculate its internal freq. And then use "bus-frequency" instead. >>>> >>> >>> I agree with you. Actually, it is being used for operation frequency >>> setting >>> of PECI controller module in SoC so it's different from the meaning of >>> "bus-frequency". I'll change it to "operation-frequency". >> >> No, now you've gone from a standard property name to something custom. >> Why do you need to set the frequency in DT if it is not related to the >> interface frequency? >> >> Rob >> > > Actually, the interface frequency is affected by the operation frequency > but there is no description of its relationship in datasheet. I'll check > again about the detail to ASPEED chip vendor and will use > 'bus-frequency' if available. > I investigated it more deeply. Basically, by the spec, PECI bus speed cannot be set as a fixed speed. A PECI bus can have a wide speed range from 2Kbps to 2Mbps which is dynamically set by a handshaking sequence between an originator and clients called 'timing negotiation' in spec. This timing negotiation behavior happens on every single transaction so the bus speed also can vary on every transactions. So I'm thinking a custom property name for it, 'peci-clk-frequency' if it is acceptable. Thanks, Jae -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html