From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4CDDC43334 for ; Wed, 15 Jun 2022 03:53:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353152AbiFODxI (ORCPT ); Tue, 14 Jun 2022 23:53:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351718AbiFODwN (ORCPT ); Tue, 14 Jun 2022 23:52:13 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD32050052; Tue, 14 Jun 2022 20:52:10 -0700 (PDT) Received: from dggpemm500023.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4LNBCR1cT8z1KB1N; Wed, 15 Jun 2022 11:50:11 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 15 Jun 2022 11:52:08 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 15 Jun 2022 11:52:00 +0800 Message-ID: <5af7a1d9-31fa-74d1-b292-79dc3c658dbd@huawei.com> Date: Wed, 15 Jun 2022 11:52:00 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v5 0/5] introduce mirrored memory support for arm64 Content-Language: en-US To: Wupeng Ma , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20220614092156.1972846-1-mawupeng1@huawei.com> From: Kefeng Wang In-Reply-To: <20220614092156.1972846-1-mawupeng1@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 2022/6/14 17:21, Wupeng Ma wrote: > From: Ma Wupeng > > Commit b05b9f5f9dcf ("x86, mirror: x86 enabling - find mirrored memory ranges") > introduced mirrored memory support for x86. This support rely on UEFI to > report mirrored memory address ranges. See UEFI 2.5 spec pages 157-158: > > http://www.uefi.org/sites/default/files/resources/UEFI%202_5.pdf > > Memory mirroring is a technique used to separate memory into two separate > channels, usually on a memory device, like a server. In memory mirroring, > one channel is copied to another to create redundancy. This method makes > input/output (I/O) registers and memory appear with more than one address > range because the same physical byte is accessible at more than one > address. Using memory mirroring, higher memory reliability and a higher > level of memory consolidation are possible. > > These EFI memory regions have various attributes, and the "mirrored" > attribute is one of them. The physical memory region whose descriptors > in EFI memory map has EFI_MEMORY_MORE_RELIABLE attribute (bit: 16) are > mirrored. The address range mirroring feature of the kernel arranges such > mirrored regions into normal zones and other regions into movable zones. > > Arm64 can support this too. So mirrored memory support is added to support > arm64. > > The main purpose of this patch set is to introduce mirrored support for > arm64 and we have already fixed the problems we had which is shown in > patch #5 to patch #8 and try to bring total isolation in patch #9 which > will disable mirror feature if kernelcore is not specified. > > In order to test this support in arm64: > - patch this patch set > - add kernelcore=mirror in kernel parameter > - start you kernel > > Patch #1 introduce mirrored memory support form arm64. > Patch #2-#4 fix some bugs for arm64 if memory reliable is enabled. > Patch #5 disable mirror feature if kernelcore is not specified. > > Thanks to Ard Biesheuvel's hard work [1], now kernel will perfer mirrored > memory if kaslr is enabled. > > [1] https://lore.kernel.org/linux-arm-kernel/CAMj1kXEPVEzMgOM4+Yj6PxHA-jFuDOAUdDJSiSxy_XaP4P7LSw@mail.gmail.com/T/ For series, Reviewed-by: Kefeng Wang > > Changelog since v4: > - merge the first two patches into one > - change __initdata to __initdata_memblock in patch #5 > > Changelog since v3: > - limit warning message in vmemmap_verify via pr_warn_once() > - only clear memblock_nomap flags rather than bring the mirrored flag back > - disable mirrored feature in memblock_mark_mirror() > > Changelog since v2: > - remove efi_fake_mem support > - remove Commit ("remove some redundant code in ia64 efi_init") since > efi_print_memmap() is not public > - add mirror flag back on initrd memory > > Changelog since v1: > - update changelog in cover letter > - use PHYS_PFN in patch #7 > > Ma Wupeng (5): > efi: arm64: Introduce ability to find mirrored memory ranges > mm: Ratelimited mirrored memory related warning messages > mm: Limit warning message in vmemmap_verify() to once > arm64: mm: Only remove nomap flag for initrd > memblock: Disable mirror feature if kernelcore is not specified > > arch/arm64/mm/init.c | 2 +- > arch/x86/include/asm/efi.h | 4 ---- > arch/x86/platform/efi/efi.c | 23 ----------------------- > drivers/firmware/efi/efi-init.c | 1 + > drivers/firmware/efi/efi.c | 23 +++++++++++++++++++++++ > include/linux/efi.h | 3 +++ > mm/internal.h | 2 ++ > mm/memblock.c | 7 +++++-- > mm/page_alloc.c | 2 +- > mm/sparse-vmemmap.c | 2 +- > 10 files changed, 37 insertions(+), 32 deletions(-) >