From: Yves-Alexis Perez <corsac@corsac.net>
To: Matthew Wilcox <willy@infradead.org>, Kees Cook <keescook@chromium.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
trivial@kernel.org
Subject: Re: [PATCH] yama: clarify ptrace_scope=2 in Yama documentation
Date: Sun, 07 Oct 2018 10:54:42 +0200 [thread overview]
Message-ID: <5b06d90e5fd23633af4dfbb5f9c6cfa7607152cc.camel@corsac.net> (raw)
In-Reply-To: <be02c1974b028efcc2a0ec49dfedff456a78e156.camel@corsac.net>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On Tue, 2018-10-02 at 23:08 +0200, Yves-Alexis Perez wrote:
> On Tue, 2018-10-02 at 13:52 -0700, Matthew Wilcox wrote:
> > On Tue, Oct 02, 2018 at 10:47:23PM +0200, Yves-Alexis Perez wrote:
> > > Current phrasing is ambiguous since it's unclear if attaching to a
> > > children through PTRACE_TRACEME requires CAP_SYS_PTRACE. Rephrase the
> > > sentence to make that clear.
> >
> > I disagree that your sentence makes that clear. How about:
> >
> > > 2 - admin-only attach:
> > > - only processes with ``CAP_SYS_PTRACE`` may use ptrace
> > > - with ``PTRACE_ATTACH``, or through children calling
> > > ``PTRACE_TRACEME``.
> > > + only processes with ``CAP_SYS_PTRACE`` may use ptrace, either with
> > > + ``PTRACE_ATTACH`` or through children calling ``PTRACE_TRACEME``.
> >
> > + only processes with ``CAP_SYS_PTRACE`` may use ptrace. This
> > + restricts both ``PTRACE_ATTACH`` and ``PTRACE_TRACEME``.
>
> Hi Matthew,
>
> I'm no native speaker, both versions are fine by me but I liked keeping the
> “children calling” part since the semantics are quite different for
> PTRACE_ATTACH and PTRACE_TRACEME.
>
Hi Kees, Matthew,
so what's the status on this? Who needs to acknowledge one wording or another?
Regards,
- --
Yves-Alexis
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEE8vi34Qgfo83x35gF3rYcyPpXRFsFAlu5ydIACgkQ3rYcyPpX
RFt7oAgAued/FsFiGvk6U/RG3JEj5p5aRu6harAXqK/Mw8n1gEu0nGvZvFJn31eY
fcU8quTtbmiNR2oYrAxjri2dhVd2JLsKDZU1bhpcKk33jDOzhUjeKnJgLGY38Z01
5idfKSy0CEZ0FvYvpt7gOm3loFlbM0au9JgFszVwFM8Yartr5vH1mPlZUwGbrroH
RORqAkwVI+g8iK1vqq9fdCf9J5mwcYu0DR8STvP8Nx12zEDNeiCShvXDNNt5VKg3
BHVNPHvE8uKaZmlyYt1oy9ZKjjcHn6veVkKEKFRz/TVc+q/Z7G1cORzVb7GzIPGj
9GoIZP2+Wi+7KUqUYQnHZSfujd5BzQ==
=jfBM
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2018-10-07 8:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 20:47 [PATCH] yama: clarify ptrace_scope=2 in Yama documentation Yves-Alexis Perez
2018-10-02 20:52 ` Kees Cook
2018-10-07 14:37 ` Jonathan Corbet
2018-10-02 20:52 ` Matthew Wilcox
2018-10-02 21:07 ` Kees Cook
2018-10-02 21:08 ` Yves-Alexis Perez
2018-10-07 8:54 ` Yves-Alexis Perez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b06d90e5fd23633af4dfbb5f9c6cfa7607152cc.camel@corsac.net \
--to=corsac@corsac.net \
--cc=corbet@lwn.net \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).