From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0183826F476; Mon, 24 Feb 2025 11:20:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=93.17.235.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740396008; cv=none; b=KJUxYE2olt8RIxqTmKup4oQGSCr66kvjZT+ZznwU9r7FFbCCOcrrIWeSlgH5KsQ/whj+SHQ5DY+2lAx9pz0k6nMCzLWK0de0oeFYxpG6G5fWLrNqRmyVMvfBcYsqzfcqkiGK50HijXZnanHMaiSISD+YiuYPxWAw4SVEydrnO7c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740396008; c=relaxed/simple; bh=vn+aZ0yf4f2bCr9xVqGeBGVY/4biDA25C2YfH+UeOJA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UVzHSp61FKVRjmsltn872PK/6LDaScABiB3LZIiDb3yAf67e57OSq+l8E8MzlwuyZW+YnzsivwVDDcr3eApVEGRfHfXIUwx0NZbGpizrMpdMkbQNcyAoxg1vPINWPv08UD/YdNeA/wq2zXRy3hzrbEaU9R2ms7yFaCUT68Yi96o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=csgroup.eu; spf=pass smtp.mailfrom=csgroup.eu; arc=none smtp.client-ip=93.17.235.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=csgroup.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=csgroup.eu Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4Z1dQg35xWz9sSq; Mon, 24 Feb 2025 12:13:47 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id reeUmV24E4zC; Mon, 24 Feb 2025 12:13:47 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4Z1dQg2BZFz9sSp; Mon, 24 Feb 2025 12:13:47 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 2FFAC8B765; Mon, 24 Feb 2025 12:13:47 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id kefUlrU39Hz9; Mon, 24 Feb 2025 12:13:47 +0100 (CET) Received: from [10.25.207.138] (unknown [10.25.207.138]) by messagerie.si.c-s.fr (Postfix) with ESMTP id C903F8B763; Mon, 24 Feb 2025 12:13:46 +0100 (CET) Message-ID: <5e8a4dd9-50a8-4080-8d63-dbb8c7241b98@csgroup.eu> Date: Mon, 24 Feb 2025 12:13:46 +0100 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] mm: Rename GENERIC_PTDUMP and PTDUMP_CORE To: Anshuman Khandual , Steven Price , linux-mm@kvack.org Cc: Catalin Marinas , Will Deacon , Jonathan Corbet , Marc Zyngier , Michael Ellerman , Nicholas Piggin , Paul Walmsley , Palmer Dabbelt , Heiko Carstens , Vasily Gorbik , Thomas Gleixner , Ingo Molnar , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org References: <20250213040934.3245750-1-anshuman.khandual@arm.com> <20250213040934.3245750-5-anshuman.khandual@arm.com> <8e75c5ff-a97b-4a6f-9c8b-ac2598eafe60@arm.com> <6e1201a1-60c1-40a3-951f-d603b6341a11@csgroup.eu> <03b042ec-1cb7-4419-8741-c65e74e49d51@arm.com> Content-Language: fr-FR From: Christophe Leroy In-Reply-To: <03b042ec-1cb7-4419-8741-c65e74e49d51@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 14/02/2025 à 08:26, Anshuman Khandual a écrit : > > > On 2/13/25 17:19, Christophe Leroy wrote: >> >> >> Le 13/02/2025 à 12:23, Steven Price a écrit : >>> On 13/02/2025 04:09, Anshuman Khandual wrote: >>>> Platforms subscribe into generic ptdump implementation via GENERIC_PTDUMP. >>>> But generic ptdump gets enabled via PTDUMP_CORE. These configs combination >>>> is confusing as they sound very similar and does not differentiate between >>>> platform's feature subscription and feature enablement for ptdump. Rename >>>> the configs as ARCH_HAS_PTDUMP and PTDUMP making it more clear and improve >>>> readability. >>> >>> [...] >>>> diff --git a/arch/powerpc/configs/mpc885_ads_defconfig b/arch/powerpc/configs/mpc885_ads_defconfig >>>> index 77306be62e9e..db005618690b 100644 >>>> --- a/arch/powerpc/configs/mpc885_ads_defconfig >>>> +++ b/arch/powerpc/configs/mpc885_ads_defconfig >>>> @@ -78,4 +78,4 @@ CONFIG_DEBUG_VM_PGTABLE=y >>>>   CONFIG_DETECT_HUNG_TASK=y >>>>   CONFIG_BDI_SWITCH=y >>>>   CONFIG_PPC_EARLY_DEBUG=y >>>> -CONFIG_GENERIC_PTDUMP=y >>>> +CONFIG_PTDUMP=y >>> >>> I'd suggest dropp this from the defconfig too, just like patch 1 dropped >>> it from debug.config. >>> >> >> Thanks for spotting that. >> >> That one is wrong. Was introduced by commit d210ee3fdfe8 ("powerpc/configs: Update config files for removed/renamed symbols") which aimed at fixing commit e084728393a5 ("powerpc/ptdump: Convert powerpc to GENERIC_PTDUMP") but it did it wrong. >> >> It is CONFIG_PTDUMP_DEBUGFS that is wanted. > > Should this replacement be done in the series or would you like it > to be handled in powerpc later ? Yes I think you should do the replacement.