From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"mchehab+samsung@kernel.org" <mchehab+samsung@kernel.org>,
"bigeasy@linutronix.de" <bigeasy@linutronix.de>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [RESEND] admin-guide/cputopology.rst: Remove non-existed cpu-hotplug.txt
Date: Tue, 13 Jul 2021 01:19:34 +0000 [thread overview]
Message-ID: <60ECEA44.1040306@fujitsu.com> (raw)
In-Reply-To: <87h7gzqzhb.fsf@meer.lwn.net>
on 2021/7/13 0:16, Jonathan Corbet wrote:
> Yang Xu<xuyang2018.jy@fujitsu.com> writes:
>
>> Since kernel commit ff58fa7f556c ("Documentation: Update CPU hotplug and move it to core-api"),
>> cpu_hotplug.txt has been removed. We should update it in here.
>>
>> Signed-off-by: Yang Xu<xuyang2018.jy@fujitsu.com>
>> ---
>> Documentation/admin-guide/cputopology.rst | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/Documentation/admin-guide/cputopology.rst b/Documentation/admin-guide/cputopology.rst
>> index b90dafcc8237..cc28b1a16371 100644
>> --- a/Documentation/admin-guide/cputopology.rst
>> +++ b/Documentation/admin-guide/cputopology.rst
>> @@ -135,9 +135,9 @@ source for the output is in brackets ("[]").
>> [NR_CPUS-1]
>>
>> offline: CPUs that are not online because they have been
>> - HOTPLUGGED off (see cpu-hotplug.txt) or exceed the limit
>> - of CPUs allowed by the kernel configuration (kernel_max
>> - above). [~cpu_online_mask + cpus>= NR_CPUS]
>> + HOTPLUGGED off or exceed the limit of CPUs allowed by the
>> + kernel configuration (kernel_max above).
>> + [~cpu_online_mask + cpus>= NR_CPUS]
>
> Is there a reason why you took out the reference to cpu-hotplug.txt
> entirely rather than switching it to the rst file?
Because rst file doesn't have HOTPLUGGED off information and
ABI/testing/sysfs-devices-system-cpu file for offline also doesn't have
cpu-hotplug.txt or rst file.
So I think removing it is better.
Best Regards
Yang Xu
>
> Thanks,
>
> jon
next prev parent reply other threads:[~2021-07-13 1:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 1:37 [RESEND] admin-guide/cputopology.rst: Remove non-existed cpu-hotplug.txt Yang Xu
2021-07-12 16:16 ` Jonathan Corbet
2021-07-13 1:19 ` xuyang2018.jy [this message]
2021-07-25 20:43 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60ECEA44.1040306@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).