Re: [PATCH v7 1/2] docs: s390/pci: Improve and update PCI documentation

[Gerd Bayer <gbayer@linux.ibm.com>]

On Tue, 2026-04-07 at 12:12 +0200, Niklas Schnelle wrote:


[... snip ...]

> Similarly add documentation for the fidparm attribute added by commit
> 99ad39306a62 ("s390/pci: Expose FIDPARM attribute in sysfs") and
> add a list of pft values and their names.
> 

[... snip ...]

> ---
>  Documentation/arch/s390/pci.rst | 144 +++++++++++++++++++++++++++-------------
>  1 file changed, 97 insertions(+), 47 deletions(-)
> 
> diff --git a/Documentation/arch/s390/pci.rst b/Documentation/arch/s390/pci.rst
> index d5755484d8e75c7bf67a350e61bbe04f0452a2fa..8cb0a1e784a7cfc5df1e04a4154ba02c9ecf46cc 100644
> --- a/Documentation/arch/s390/pci.rst
> +++ b/Documentation/arch/s390/pci.rst
> @@ -6,6 +6,7 @@ S/390 PCI
>  
>  Authors:
>          - Pierre Morel
> +        - Niklas Schnelle
>  
>  Copyright, IBM Corp. 2020
>  
> @@ -27,14 +28,16 @@ Command line parameters
>  debugfs entries
>  ---------------
>  
> -The S/390 debug feature (s390dbf) generates views to hold various debug results in sysfs directories of the form:
> +The S/390 debug feature (s390dbf) generates views to hold various debug results
> +in sysfs directories of the form:
>  
>   * /sys/kernel/debug/s390dbf/pci_*/
>  
>  For example:
>  
>    - /sys/kernel/debug/s390dbf/pci_msg/sprintf
> -    Holds messages from the processing of PCI events, like machine check handling
> +
> +    holds messages from the processing of PCI events, like machine check handling
>      and setting of global functionality, like UID checking.
>  
>    Change the level of logging to be more or less verbose by piping
> @@ -47,87 +50,134 @@ Sysfs entries
>  

[... snip ...]

> +
> +* /sys/firmware/clp/uid_is_unique:

As much as I had loved the attribute to be named as such, or even
better /sys/firmware/clp/uids_are_unique, I find commit b043a81ce3ee
("s390/pci: Expose firmware provided UID Checking state in sysfs") has
introduced

/sys/firmware/clp/uid_checking.

Sorry, that this did slip me...

Gerd