From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADF2CC7EE23 for ; Mon, 29 May 2023 14:22:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229742AbjE2OWn (ORCPT ); Mon, 29 May 2023 10:22:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229667AbjE2OWm (ORCPT ); Mon, 29 May 2023 10:22:42 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F698E8; Mon, 29 May 2023 07:22:33 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-3f6e72a1464so22082565e9.1; Mon, 29 May 2023 07:22:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685370151; x=1687962151; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=vl5E9mH7Bi/ClQnlPR1LRMwr8a1e9GOqSgKO5eVDbSU=; b=ggFbeCNormcSCt72bW8IqNCobzV+UiIQWrJ9Ra/a1MX8/CEq8Vuu2VbkPylXs5EuPQ RNt0w9J+lWwJ4Z+A01vIG6BYwn74yVGk8J/cGKNjM7h+REbVxa2JPofUPwESHBHYJU90 aT71CuC6NDB1jcXke5SD8VNO8AV1tKjvGTrjFlr1X+hsH/2hQQc+8oKAfJxcN9/HIdcr DTfWxy2yVqhgnMBPWupKvBk3t7qm+ViQ401ZLvgfGL7w+CfzSIIMzxv+87oV8OPrcxWD jsf40vMFg7CHF05UHz7hdf3gEmhRuPab2tFDg0ocOqFRrTs0npl6jyzn57vktB4yOfV0 gwNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685370151; x=1687962151; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vl5E9mH7Bi/ClQnlPR1LRMwr8a1e9GOqSgKO5eVDbSU=; b=I7CmJuIoTHKShWxP3IDCU0mga+WAZBXQG6HFDUahfo9D0qlDgGjyvHqVtvXNNwUlVA 7XvDm+1bgg/BhtYVBl/IguaOR0J5ErTi6yGz6XSaX14JKZy4Od5rBOlU1UwbwixHNF8I LkBicOva69M4t1mlxeDVf21EP8oS/Z73KvnbjbD4+BYHFJiY3YOHjeUG5/JL+gc93nAZ ad/1+sAwH3a0tCDNbTP+NTFd+BvWkPINhsmOT6/GBhDKbCOXNEUqWRALFZiDaAdwlV8J F8FjkRpc/18VWXahfHGD8UdYfHVIFFh95I0wdfveW3FLA+9hz10LL6qlFa/rb6bupQ/b qrDQ== X-Gm-Message-State: AC+VfDy2b9aL9/FP2gtYleqPzPI2SVo7gAgoCrHEnBXNUDSrJSe8fngM bwUn9iDhWo7hR5aXlwaARE0= X-Google-Smtp-Source: ACHHUZ7L+Y8YK2pmRY6CMGxDXgKqI9PIYbA5LjI3TodqBKoH52Wli1y549++A2DTU7/h9dwYIpcbFA== X-Received: by 2002:a7b:c448:0:b0:3f6:4cfc:79cb with SMTP id l8-20020a7bc448000000b003f64cfc79cbmr8855842wmi.31.1685370151110; Mon, 29 May 2023 07:22:31 -0700 (PDT) Received: from Ansuel-xps. (93-34-93-173.ip49.fastwebnet.it. [93.34.93.173]) by smtp.gmail.com with ESMTPSA id y6-20020a05600c364600b003f6042d6da0sm14382269wmq.16.2023.05.29.07.22.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 May 2023 07:22:30 -0700 (PDT) Message-ID: <6474b526.050a0220.baa3e.31c1@mx.google.com> X-Google-Original-Message-ID: Date: Mon, 29 May 2023 16:09:39 +0200 From: Christian Marangi To: Jonathan Corbet Cc: Bagas Sanjaya , Pavel Machek , Lee Jones , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-leds@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [net-next PATCH v3 03/13] Documentation: leds: leds-class: Document new Hardware driven LEDs APIs References: <20230527112854.2366-1-ansuelsmth@gmail.com> <20230527112854.2366-4-ansuelsmth@gmail.com> <871qiz5iqt.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871qiz5iqt.fsf@meer.lwn.net> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon, May 29, 2023 at 08:12:42AM -0600, Jonathan Corbet wrote: > Bagas Sanjaya writes: > > >> + - hw_control_get_device: > >> + return the device associated with the LED driver in > >> + hw control. A trigger might use this to match the > >> + returned device from this function with a configured > >> + device for the trigger as the source for blinking > >> + events and correctly enable hw control. > >> + (example a netdev trigger configured to blink for a > >> + particular dev match the returned dev from get_device > >> + to set hw control) > >> + > >> + Return a device or NULL if nothing is currently attached. > > Returns a device name? > > The return type of this function is struct device * - how would you > expect it to return a name? > Just to clarify, a device name can't be returned. Not every device have a name and such name can be changed. An example is network device where you can change the name of the interface. Using the device prevents all of this problem. -- Ansuel