From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZW2H/utz" Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 748C010F9; Fri, 1 Dec 2023 07:09:17 -0800 (PST) Received: by mail-qk1-x732.google.com with SMTP id af79cd13be357-77d645c0e06so112311585a.3; Fri, 01 Dec 2023 07:09:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701443356; x=1702048156; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=zLso2pmbW+pqec/n5hTLrdVINDT0pM+C03w8nh7HKns=; b=ZW2H/utzzf1N7CiaySlvo1Rf/2AEihSxENWVUquX4J/l39PzuK8dND9WNcVXu1taoX Rj7+SHZGsei6QlOGW9p8OZyqJXLHCh2i4c8hybn6eqz9mw30mwtTXz81AEMAE2jtfFhJ UgYS/PUTL/mjlV8uEoiyH4vyKHSIfDaGCB+RrUvSRorMWS7H2kcJV25cIOfjFGlU7Dvw u9RbeF1A90lzZJzDh189xT8bkgXIrd417KCDKsKVnVZ+BwSakSccGybZE2aB9ouJiQ8Z UOiRmPKUhUQQYtARmx4fNnb6LRFGEKroQOFtv1QlNoPhv62L+jjc0GLrT7120XYRMs15 NsZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701443356; x=1702048156; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=zLso2pmbW+pqec/n5hTLrdVINDT0pM+C03w8nh7HKns=; b=eFFRYwiS/0K9fqnRZIK4nTKrZI+AHpzU9i0L2JMXRFwUyBxhPPb9NLRn9JjPoQCtFU flSBTRW9Z6/5JuDkTQ9kGQohIMtwiFb1RA2gr9tDZE2L/0R7VMraOpZn7C1IGacXiTaq GdiC67/XivIrehsMTEyS8qWsM+uKQd+V9capxdJZMFD8wzDGlowRRRanSiSnf7TAc3y0 WElU4YuiIfcrPIHCeZQkV+LIFwHNZrPDiksCnxwNJygmCfyidZHAdYOdicqTHOs8jrhi f3uXZ3NJsxUx/5brQHV1ehe9jTTtW88sCaUe/mIcxxbFQeqDj6l/+MSzf8NpQmPmGmY4 M8Gw== X-Gm-Message-State: AOJu0YyjQydEDG3m72cwB5wEfj+HUAm1KPUvfU6lJ5bwfs71NQqKXDo9 xPSMiezz/FnMYilqTw6dRI0iVMZ5PtHgdA== X-Google-Smtp-Source: AGHT+IH54DZX3epKyg6LRt2pdYZkL/+XeUYhSrEyKX4h3aISopJX9pTR0/tZhUxii4HdMqDmoQRtqg== X-Received: by 2002:ad4:4511:0:b0:67a:8ed9:c9f with SMTP id k17-20020ad44511000000b0067a8ed90c9fmr3811562qvu.48.1701443356450; Fri, 01 Dec 2023 07:09:16 -0800 (PST) Received: from localhost (114.66.194.35.bc.googleusercontent.com. [35.194.66.114]) by smtp.gmail.com with ESMTPSA id g12-20020a0caacc000000b0067a39a44ca5sm1106qvb.77.2023.12.01.07.09.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 07:09:15 -0800 (PST) Date: Fri, 01 Dec 2023 10:09:15 -0500 From: Willem de Bruijn To: "Song, Yoong Siang" , Jesper Dangaard Brouer , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Bjorn Topel , "Karlsson, Magnus" , "Fijalkowski, Maciej" , Jonathan Lemon , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Stanislav Fomichev , Lorenzo Bianconi , Tariq Toukan , Willem de Bruijn , Maxime Coquelin , Andrii Nakryiko , Mykola Lysenko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , Shuah Khan , Alexandre Torgue , Jose Abreu Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , "bpf@vger.kernel.org" , "xdp-hints@xdp-project.net" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kselftest@vger.kernel.org" Message-ID: <6569f71bad00d_138af5294d@willemb.c.googlers.com.notmuch> In-Reply-To: References: <20231201062421.1074768-1-yoong.siang.song@intel.com> Subject: RE: [PATCH bpf-next v2 0/3] xsk: TX metadata txtime support Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Song, Yoong Siang wrote: > On Friday, December 1, 2023 6:46 PM, Jesper Dangaard Brouer wrote: > >On 12/1/23 07:24, Song Yoong Siang wrote: > >> This series expands XDP TX metadata framework to include ETF HW offload. > >> > >> Changes since v1: > >> - rename Time-Based Scheduling (TBS) to Earliest TxTime First (ETF) > >> - rename launch-time to txtime > >> > > > >I strongly disagree with this renaming (sorry to disagree with Willem). > > > >The i210 and i225 chips call this LaunchTime in their programmers > >datasheets, and even in the driver code[1]. > > > >Using this "txtime" name in the code is also confusing, because how can > >people reading the code know the difference between: > > - tmo_request_timestamp and tmo_request_txtime > > > > Hi Jesper and Willem, > > How about using "launch_time" for the flag/variable and > "Earliest TxTime First" for the description/comments? I don't particularly care which term we use, as long as we're consistent. Especially, don't keep introducing new synonyms. The fact that one happens to be one vendor's marketing term does not make it preferable, IMHO. On the contrary. SO_TXTIME is in the ABI, and EDT has been used publicly in kernel patches and conference talks, e.g., Van Jacobson's Netdev 0x12 keynote. Those are vendor agnostic commonly used terms. But as long as Launch Time is not an Intel only trademark, fine to select that.