From: Christian Marangi <ansuelsmth@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>, Jonathan Corbet <corbet@lwn.net>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
INAGAKI Hiroshi <musashino.open@gmail.com>,
Daniel Golle <daniel@makrotopia.org>,
Christian Brauner <brauner@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>, Ming Lei <ming.lei@redhat.com>,
Li Lingfeng <lilingfeng3@huawei.com>,
Christian Heusel <christian@heusel.eu>,
linux-block@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Lorenzo Bianconi <lorenzo@kernel.org>
Subject: Re: [RFC PATCH 3/4] block: add support for partition table defined in OF
Date: Wed, 2 Oct 2024 10:22:28 +0200 [thread overview]
Message-ID: <66fd02c8.5d0a0220.796f6.d2df@mx.google.com> (raw)
In-Reply-To: <Zvz6ITaMKmo0U3c3@infradead.org>
On Wed, Oct 02, 2024 at 12:45:37AM -0700, Christoph Hellwig wrote:
> On Tue, Oct 01, 2024 at 11:26:22AM +0200, Christian Marangi wrote:
> > > No. ->disk_name is in no way reliable, we can't hardcode that into
> > > a partition parser.
> > >
> >
> > Then any hint on this or alternative way?
>
> The normal way would be to use eui/ngui/uuid provided by the storage
> device. We have a interface for that in the block layer support by
> scsi and nvme, but I don't know how to wire that up for eMMC which
> I suspect is what you care about.
>
I think I have found a better way to handle it, please check v5, did you
receive the series?
The new series just make the driver pass the partition node and the OF
code just take it and use it.
This way we don't have to parse the disk name at all and it's driver
specific work to select the "partitions" node if multiple are present.
I feel your hint produced a much better implementation without having to
pollute the block code with specific case.
--
Ansuel
next prev parent reply other threads:[~2024-10-02 8:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 10:59 [RFC PATCH 0/4] block: partition table OF support Christian Marangi
2024-09-23 10:59 ` [RFC PATCH 1/4] block: add support for defining read-only partitions Christian Marangi
2024-09-24 6:32 ` Christoph Hellwig
2024-09-23 10:59 ` [RFC PATCH 2/4] docs: block: Document support for read-only partition in cmdline part Christian Marangi
2024-09-23 10:59 ` [RFC PATCH 3/4] block: add support for partition table defined in OF Christian Marangi
2024-09-24 6:34 ` Christoph Hellwig
2024-09-24 10:17 ` Christian Marangi
2024-10-01 8:37 ` Christoph Hellwig
2024-10-01 9:26 ` Christian Marangi
2024-10-02 7:45 ` Christoph Hellwig
2024-10-02 8:22 ` Christian Marangi [this message]
2024-09-23 10:59 ` [RFC PATCH 4/4] dt-bindings: mmc: Document support for partition table in mmc-card Christian Marangi
2024-09-24 22:53 ` Rob Herring
2024-09-24 23:01 ` Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66fd02c8.5d0a0220.796f6.d2df@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=christian@heusel.eu \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@makrotopia.org \
--cc=devicetree@vger.kernel.org \
--cc=hch@infradead.org \
--cc=krzk+dt@kernel.org \
--cc=lilingfeng3@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=ming.lei@redhat.com \
--cc=miquel.raynal@bootlin.com \
--cc=musashino.open@gmail.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).