Re: [PATCH v4 26/28] cxl/mem: Trace Dynamic capacity Event Record

Ira Weiny
2024-10-24T01:52:24Z

Jonathan Cameron wrote:
> On Mon, 07 Oct 2024 18:16:32 -0500
> ira.weiny@intel.com wrote:
>
> > From: Navneet Singh <navneet.singh@intel.com>
> >
> > CXL rev 3.1 section 8.2.9.2.1 adds the Dynamic Capacity Event Records.
> > User space can use trace events for debugging of DC capacity changes.
> >
> > Add DC trace points to the trace log.
> >
> > Signed-off-by: Navneet Singh <navneet.singh@intel.com>
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> Minor comment inline about tag formatting.
>
> Either way
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>

[snip]

> > +
> > + CXL_EVT_TP_printk("event_type='%s' host_id='%d' region_id='%d' " \
> > + "starting_dpa=%llx length=%llx tag=%s " \
> > + "shared_extent_sequence=%d",
> > + show_dc_evt_type(__entry->event_type),
> > + __entry->hostid,
> > + __entry->region_id,
> > + __entry->dpa_start,
> > + __entry->length,
> > + __print_hex(__entry->tag, CXL_EXTENT_TAG_LEN),
>
> %pU maybe?
> https://elixir.bootlin.com/linux/v6.11.2/source/include/ras/ras_event.h#L248
> uses it for the GUIDs in CPER etc.
>
> I guess it depends on how strongly we want to push John's vision of these
> always being UUIDs! (I'm in favor and here is just formatting a debug print
> so that shouldn't be a problem even for those who want for some odd reason
> to use something else for tags :)

I'm not pushing against the UUID idea any more. Just forgot this print.

Changed.

Ira

[snip]