Re: [PATCH v4 23/28] dax/bus: Factor out dev dax resize logic

Ira Weiny
2024-10-21T21:17:04Z

Jonathan Cameron wrote:
> On Mon, 07 Oct 2024 18:16:29 -0500
> Ira Weiny <ira.weiny@intel.com> wrote:

[snip]

> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> > ---
> > Changes:
> > [Jonathan: Fix handling of alloc]
>
> Trivial comments inline.
> Not an area I know much about, so treat this one as a 'smells ok'
> type of tag.

NP

> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>

Thanks

>
> > +
> > +static ssize_t dev_dax_resize(struct dax_region *dax_region,
> > + struct dev_dax *dev_dax, resource_size_t size)
> > +{
> > + resource_size_t avail = dax_region_avail_size(dax_region), to_alloc;
> resource_size_t to_alloc;
>
> on it's own line. That was hard to spot all the way over there.
> Obviously this was in original code, but maybe slip a tidy up in whilst
> you are moving it?

Yea fixed up.
Ira