From: Paolo Bonzini <pbonzini@redhat.com>
To: Lai Jiangshan <jiangshanlai@gmail.com>,
Sean Christopherson <seanjc@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
kvm@vger.kernel.org, Lai Jiangshan <jiangshan.ljs@antgroup.com>,
Jonathan Corbet <corbet@lwn.net>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
X86 ML <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
linux-doc@vger.kernel.org
Subject: Re: [RFC PATCH V3 3/4] KVM: X86: Alloc role.pae_root shadow page
Date: Thu, 14 Apr 2022 11:08:45 +0200 [thread overview]
Message-ID: <683974e7-5801-e289-8fa4-c8a8d21ec1b2@redhat.com> (raw)
In-Reply-To: <CAJhGHyD-4YFDhkxk2SQFmKe3ooqw_0wE+9u3+sZ8zOdSUfbnxw@mail.gmail.com>
On 4/14/22 11:07, Lai Jiangshan wrote:
>> I don't think this will work for shadow paging. CR3 only has to be 32-byte aligned
>> for PAE paging. Unless I'm missing something subtle in the code, KVM will incorrectly
>> reuse a pae_root if the guest puts multiple PAE CR3s on a single page because KVM's
>> gfn calculation will drop bits 11:5.
>
> I forgot about it.
Isn't the pae_root always rebuilt by
if (!tdp_enabled && memcmp(mmu->pdptrs, pdpte, sizeof(mmu->pdptrs)))
kvm_mmu_free_roots(vcpu->kvm, mmu, KVM_MMU_ROOT_CURRENT);
in load_pdptrs? I think reuse cannot happen.
Paolo
next prev parent reply other threads:[~2022-04-14 9:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220330132152.4568-1-jiangshanlai@gmail.com>
2022-03-30 13:21 ` [RFC PATCH V3 2/4] KVM: X86: Introduce role.glevel for level expanded pagetable Lai Jiangshan
2022-03-30 16:01 ` Lai Jiangshan
2022-04-12 21:31 ` Sean Christopherson
2022-04-13 4:13 ` Lai Jiangshan
2022-04-13 8:38 ` Paolo Bonzini
2022-04-13 14:42 ` Sean Christopherson
2022-04-13 14:46 ` Paolo Bonzini
2022-04-13 15:32 ` Sean Christopherson
2022-04-13 16:03 ` Paolo Bonzini
2022-04-14 15:51 ` Sean Christopherson
2022-04-14 16:32 ` Lai Jiangshan
2022-03-30 13:21 ` [RFC PATCH V3 3/4] KVM: X86: Alloc role.pae_root shadow page Lai Jiangshan
2022-04-12 21:14 ` Sean Christopherson
2022-04-14 9:07 ` Lai Jiangshan
2022-04-14 9:08 ` Paolo Bonzini [this message]
2022-04-14 9:32 ` Lai Jiangshan
2022-04-14 10:04 ` Paolo Bonzini
2022-04-14 11:06 ` Lai Jiangshan
2022-04-14 14:12 ` Paolo Bonzini
2022-04-14 14:42 ` Sean Christopherson
2022-04-14 13:35 ` Lai Jiangshan
2022-04-14 14:52 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=683974e7-5801-e289-8fa4-c8a8d21ec1b2@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jiangshan.ljs@antgroup.com \
--cc=jiangshanlai@gmail.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).