From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 1C66A7D87C for ; Tue, 28 Aug 2018 22:29:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727744AbeH2CXS (ORCPT ); Tue, 28 Aug 2018 22:23:18 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35050 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727067AbeH2CXR (ORCPT ); Tue, 28 Aug 2018 22:23:17 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 11EE640241C9; Tue, 28 Aug 2018 22:29:32 +0000 (UTC) Received: from llong.remote.csb (ovpn-123-12.rdu2.redhat.com [10.10.123.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 86ED82026D6B; Tue, 28 Aug 2018 22:29:30 +0000 (UTC) Subject: Re: [PATCH 2/2] fs/dcache: Make negative dentries easier to be reclaimed To: Matthew Wilcox Cc: Alexander Viro , Jonathan Corbet , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, "Luis R. Rodriguez" , Kees Cook , Linus Torvalds , Jan Kara , "Paul E. McKenney" , Andrew Morton , Ingo Molnar , Miklos Szeredi , Larry Woodman , James Bottomley , "Wangkai (Kevin C)" , Michal Hocko References: <1535476780-5773-1-git-send-email-longman@redhat.com> <1535476780-5773-3-git-send-email-longman@redhat.com> <20180828221352.GC11400@bombadil.infradead.org> From: Waiman Long Organization: Red Hat Message-ID: <6873378b-3202-e738-2366-5fb818b4a013@redhat.com> Date: Tue, 28 Aug 2018 18:29:29 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20180828221352.GC11400@bombadil.infradead.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Tue, 28 Aug 2018 22:29:32 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Tue, 28 Aug 2018 22:29:32 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'longman@redhat.com' RCPT:'' Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 08/28/2018 06:13 PM, Matthew Wilcox wrote: > On Tue, Aug 28, 2018 at 01:19:40PM -0400, Waiman Long wrote: >> @@ -134,7 +135,7 @@ bool list_lru_add(struct list_lru *lru, struct list_head *item) >> spin_lock(&nlru->lock); >> if (list_empty(item)) { >> l = list_lru_from_kmem(nlru, item, &memcg); >> - list_add_tail(item, &l->list); >> + (add_tail ? list_add_tail : list_add)(item, &l->list); >> /* Set shrinker bit if the first element was added */ >> if (!l->nr_items++) >> memcg_set_shrinker_bit(memcg, nid, > That's not OK. Write it out properly, ie: > > if (add_tail) > list_add_tail(item, &l->list); > else > list_add(item, &l->list); > Yes, I can rewrite it. What is the problem with the abbreviated form? Cheers, Longman