From: Hans de Goede <hdegoede@redhat.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Fernando Eckhardt Valle" <fevalle@ipt.br>
Cc: Mark Pearson <mpearson-lenovo@squebb.ca>,
corbet@lwn.net, hmh@hmh.eng.br, markgross@kernel.org,
linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86: thinkpad_acpi: sysfs interface to auxmac
Date: Mon, 18 Sep 2023 15:41:22 +0200 [thread overview]
Message-ID: <6a4a9acf-aa1d-dc73-b171-76654e1b9d47@redhat.com> (raw)
In-Reply-To: <97ac516a-5d9f-f58d-2313-d7d3453f58cb@linux.intel.com>
Hi,
On 9/15/23 18:18, Ilpo Järvinen wrote:
> On Fri, 15 Sep 2023, Fernando Eckhardt Valle wrote:
<snip>
>> + goto auxmacinvalid;
>> + }
>> +
>> + if (strncmp(obj->string.pointer + 0x8, "#", 1) != 0 ||
>> + strncmp(obj->string.pointer + 0x15, "#", 1) != 0) {
>
> Why use strncmp with (..., 1)? These offsets should defines above and not
> use literals.
Right, good point.
To be extra clear here, this should be replaced by != '#' statements, e.g.:
if (obj->string.pointer[AUXMAC_BEGIN_MARKER] != '#' ||
obj->string.pointer[AUXMAC_END_MARKER] != '#') {
...
Regards,
Hans
prev parent reply other threads:[~2023-09-18 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 12:31 [PATCH v2] platform/x86: thinkpad_acpi: sysfs interface to auxmac Fernando Eckhardt Valle
2023-09-15 16:18 ` Ilpo Järvinen
2023-09-15 17:37 ` Fernando Eckhardt Valle (FIPT)
2023-09-18 13:41 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a4a9acf-aa1d-dc73-b171-76654e1b9d47@redhat.com \
--to=hdegoede@redhat.com \
--cc=corbet@lwn.net \
--cc=fevalle@ipt.br \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox