From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795257316; b=jSMHt3p9a5dRTrp0yr3aZ0Dfdm5mZ3qzxpxJfYlkoLTtiJWks60ISwHoTeWdxH6+J8ZY qLJAGZ3QrK6OhDj32nP/YavGovT4jogTlWWsemaPSQZ1QrlPSEErSCeflvZ4zLMaUPOLz gKKmtVaRlyVlH3t+8PlLafCsV+mwT9z7TBaN+4r//8Gr/q+odLIIsho2BEN3AI40zGsFp C/tspzN2pFkRaliJzpHqux0Kn/NpC+3RbRnlkMj7ZM3H9UO+Aa/2x0ohyJqofL4obSEQP wPv5oE4hrDA/HJ2S1h8+V6QpPwH6bvHVepMWA1UgWAYjLSy1bW1AGHs5pf1UlnBlrlg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795257316; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received: X-Received:Received:Message-ID:Subject:From:To:Cc:Date:In-Reply-To: References:Autocrypt:Content-Type:Content-Transfer-Encoding: User-Agent:MIME-Version; bh=9bsvYKUqqiIEmbO2aiAG3E5Ax6t0fNk6OQ/rRTGZEtM=; b=t0frXP2c7mmlm9+qgZY6BQ6aSGZCvVpfOXfD8LInpPuTPqfOUPKCjttam9DJ3AhbsM5E C38cnais1EsNMlKNkqP5uroFtpGr0cqNWhtxof/nT5u9IF4v4/UMuHrNdYwGnYae0QL/S 4QVpzQ8hhteswOE/0Sc4t8AjEgA53nb6E5vr+hGGkqUFwYuQL21M28tlz19S4t+6Z2ECR LI6vtyG2+9uKhHbxoPi6pjOMKLdcZOOyMzwNyvE7tfj9g0AJfU14McU3sOQWZDbg37HKB H3JCkq0TQZNh8VZKiBw5At/xzbvqmE1GZ/T/qd626mTpDMq6GSguBI82cWj/HL6EikA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b="T06V/NK5"; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=GH8CCjzs; arc=none smtp.remote-ip=170.10.133.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8A51606A334 for ; Sat, 21 Nov 2026 10:35:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org A8A51606A334 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=T06V/NK5; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=GH8CCjzs DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1795257313; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9bsvYKUqqiIEmbO2aiAG3E5Ax6t0fNk6OQ/rRTGZEtM=; b=T06V/NK5+dY7JdHwvdPwQG8fzDOLDWPMkf/lRpaDG95YoizlwQc0kJMdv3bgQu6AyJjqr+ OLVUjH+zk1SGdk6p7pYXwARhx6bYHMvBJG0mjcqLMgxZ2s2jLbef0f5fxAu6G3MMJ4Yzch Sv406BK65IXypEE9peNczxOaiJFdCnI= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-492-gGtgYJgUMsyrbooqSBj_sA-1; Sat, 21 Nov 2026 10:35:11 +0000 X-MC-Unique: gGtgYJgUMsyrbooqSBj_sA-1 X-Mimecast-MFC-AGG-ID: gGtgYJgUMsyrbooqSBj_sA_1795257310 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-48fcb657f32so964293f8f.2 for ; Sat, 21 Nov 2026 02:35:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1795257310; x=1795862110; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :autocrypt:references:in-reply-to:date:cc:to:from:subject:message-id :from:to:cc:subject:date:message-id:reply-to:content-type; bh=9bsvYKUqqiIEmbO2aiAG3E5Ax6t0fNk6OQ/rRTGZEtM=; b=GH8CCjzsFzumr78PhysOTQ9fkumvDAoN8Fd/Xl2Jo6xyS6KMUDENRwz1Jx2iFo1n5+ EcV/Xbf5P9qsSu4nEiaLbb1wZdOknxRBuqvVKndZ51WHNh2VlCkM+3TRDLx+ldjBxuPa w+7Q+vaegvCwQA2zsgRC0iQXhpKl5Jj1PmtyVI2SLPq8haKyssNY0bv2isx+daLX5Iao 0LEAblvztaCa2gOplJidMPyYtd3oi3j05ddpAUxlXu5kXd8fMH2wswRikDhUE1T3R1Hn IVTBk90gxbpJCldrV+Je54Oh79n4oeVmcH1NSXowvr4TML8scYFuB1LGFcRbO9mfXs7T fhqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795257310; x=1795862110; h=mime-version:user-agent:content-transfer-encoding:content-type :autocrypt:references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=9bsvYKUqqiIEmbO2aiAG3E5Ax6t0fNk6OQ/rRTGZEtM=; b=V2NqoRl2Uiaj7lGcocEmPf9+rIk9OrV2bf3sNMW5G7fcqq/7/KquJ1AfiaRsO6WWjG rAxn/PWjnsIiSjnl4gCNeng93TqbmFN/HjvPUWsugVSuLTpBon8f9Q7aJvS0BllTuAwg 9KotJ04lEwtUJFwvF7FdwSKj7EF4U41zX8JD3tNUrzRFGMt6jMv6UJcoCcODc3edMvYH GeYgxotUdGhoDzYHuUCWH1pJ1pgssLoO3v2RFPEtL+YHFdLBRCj1MnGRDr97NCLtibbl QzOPdxZI4Cw9qw6AGz9TXybM7p7tYnml8hXhJBfj37P65C7IN0tHtAa8dJZNVU2H0A6m dR9w== X-Forwarded-Encrypted: i=1; AL+hErGogYHdQFcERIHqkeXowLegnLkqlXMSHU0fvCPuK+KpR10n6QppT6ep7lon2ANOCleFPr7Dbidy0zg=@vger.kernel.org X-Gm-Message-State: APuU4Z809qrJgIVapjrh3Bcprf09JOhm1My2C2czxBKtrlruBmGOCy8o Om35VcqC2V/jEagSdK/BcOBDr9LcTmzeO+3PTqeIco4IwxCyeJ9gb3gqJ5GNMiKJjobjpj/2kOH VM7q9BFagcRsyIPyYB7sBtLod5dA+H2EH2C/Nos2Dh3hQrL4/f9lJfVf9w6vJYg== X-Gm-Gg: AZFdTZekokjMllq2Fbm3q6jkrqtTRR//sF9nd5XKbLlZ37kPkjfFVf9AtgQz6X9VddD FtFWlqdYBlUcNhlD1vtDaphK/R7q13Co4SRv7L3vBziXNZKBFQ3OD6DjfbdQdkxDDfFP5V6k99f SUIjap7QqgcdpNow0PNBrCymaR2MQRl/5FzoSCVxO+XDofeIDGMiU9SMUBbsPfTHTlHvl+RvXu9 uYHQeN4t2gHVipTC5O8q5tH3RCJSS9WOQDXRqkdGq/WPOgmAcUKO9N5fxK35I0JMKf6EMiLfH30 GSL7Gs1cwnYICqrEzSozqV8foO5PBlo0p75ltd+AKoV42Nh4TmLczkcs64yEmHKHaN44uZxBfrs BFVfAeIoXM1+XHx+s3O8QysaKuUwjG6sm2RMaabsIA9YMe45iO+eUOpkUYHYGDuvcNs777gyqTJ wH X-Received: by 2002:a05:600c:1389:b0:4bb:7347:d5c0 with SMTP id 5b1f17b1804b1-4bb88826937mr123101945e9.9.1795257310551; Sat, 21 Nov 2026 02:35:10 -0800 (PST) X-Received: by 2002:a05:600c:1389:b0:4bb:7347:d5c0 with SMTP id 5b1f17b1804b1-4bb88826937mr123101795e9.9.1795257310278; Sat, 21 Nov 2026 02:35:10 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb ([185.168.96.228]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4bb884865b1sm165089265e9.5.2026.11.21.02.35.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Nov 2026 02:35:09 -0800 (PST) Message-ID: <6c3fa853697803c63e2b87c7f8a9d4ff2f561820.camel@redhat.com> Subject: Re: [RFC PATCH v2 2/9] tracing/sched: Add IRQ preemption lifecycle tracepoints From: Gabriele Monaco To: Karl Mehltretter , Steven Rostedt Cc: Masami Hiramatsu , Mathieu Desnoyers , Thomas Gleixner , Sebastian Andrzej Siewior , Clark Williams , Ingo Molnar , Peter Zijlstra , Andy Lutomirski , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , Jonathan Corbet , Shuah Khan , Randy Dunlap , Wen Yang , linux-trace-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sat, 21 Nov 2026 11:35:07 +0100 In-Reply-To: <20261107171252.25090-3-kmehltretter@gmail.com> References: <20261107171252.25090-1-kmehltretter@gmail.com> <20261107171252.25090-3-kmehltretter@gmail.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.62.1 (3.62.1-1.fc45) X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 On Sat, 2026-11-07 at 18:12 +0100, Karl Mehltretter wrote: ... > =C2=A0asmlinkage __visible void __sched preempt_schedule_irq(void) > =C2=A0{ > +=09struct task_struct *owner =3D current; > =C2=A0=09enum ctx_state prev_state; > =C2=A0 > =C2=A0=09/* Catch callers which need to be fixed */ > =C2=A0=09BUG_ON(preempt_count() || !irqs_disabled()); > =C2=A0 > =C2=A0=09prev_state =3D exception_enter(); > +=09/* Sample before tracing bookkeeping can change the observed context. > */ What's this comment for? You're tracing before disabling preemption to sche= dule, what bookkeeping? > +=09if (trace_sched_irq_preempt_entry_tp_enabled()) > +=09=09trace_sched_irq_preempt_entry_tp(owner, preempt_count(), > irqs_disabled()); I don't think you need to check the static key manually, arguments are expa= nded inside the trace_##_tp() after checking it, so you can just trace here. > =C2=A0 > =C2=A0=09do { > =C2=A0=09=09preempt_disable(); > @@ -7664,6 +7668,8 @@ asmlinkage __visible void __sched > preempt_schedule_irq(void) > =C2=A0=09=09sched_preempt_enable_no_resched(); > =C2=A0=09} while (need_resched()); > =C2=A0 > +=09if (trace_sched_irq_preempt_exit_tp_enabled()) > +=09=09trace_sched_irq_preempt_exit_tp(owner, preempt_count(), > irqs_disabled()); Does the owner here makes sense? Do you use it as the /initiator/ of the fi= rst switch? Is it only to match it with the entry (although, as you said, it ma= y be somewhere else, running again, or not running at all). Thanks, Gabriele > =C2=A0=09exception_exit(prev_state); > =C2=A0} > =C2=A0