Re: [PATCH v2 09/15] admin-guide/hw-vuln: Correct prctl() argument description

Daniel Bristot de Oliveira
2024-04-05T09:33:02Z

On 3/13/24 02:24, Joel Fernandes (Google) wrote:
> Correct the description for arg4 which appears to be outdated.
>
> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>

Maybe it is better to keep these tests into a separated thread (?) Because they
are touching things that are not about the server, so it might create conflicts...

What I did in the past when adding a series that was part in the kernel (tracer)
and part of tools (rtla) was to split them into two series, then referencing
one on the other - Steven suggested... and it was a good thing... and
reduced the number of versions.

So I am not adding these self-tests on top of the dl series for now... because
there is also discussion about the patches... and I am not an expert in the
selftests.... I will add a reference to this thread in the v6 cover and keep
updating it as new versions show up... in this way, one thing does not block
the other.

Thoughts?

-- Daniel

> ---
> Documentation/admin-guide/hw-vuln/core-scheduling.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/admin-guide/hw-vuln/core-scheduling.rst b/Documentation/admin-guide/hw-vuln/core-scheduling.rst
> index cf1eeefdfc32..338d639a8127 100644
> --- a/Documentation/admin-guide/hw-vuln/core-scheduling.rst
> +++ b/Documentation/admin-guide/hw-vuln/core-scheduling.rst
> @@ -62,8 +62,8 @@ arg3:
>
> arg4:
> ``pid_type`` for which the operation applies. It is one of
> - ``PR_SCHED_CORE_SCOPE_``-prefixed macro constants. For example, if arg4
> - is ``PR_SCHED_CORE_SCOPE_THREAD_GROUP``, then the operation of this command
> + ``PIDTIME_``-prefixed macro constants. For example, if arg4
> + is ``PIDTYPE_TGID``, then the operation of this command
> will be performed for all tasks in the task group of ``pid``.
>
> arg5: