From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 43DF97D043 for ; Mon, 18 Jun 2018 23:11:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755432AbeFRXLl (ORCPT ); Mon, 18 Jun 2018 19:11:41 -0400 Received: from ale.deltatee.com ([207.54.116.67]:45174 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755375AbeFRXLk (ORCPT ); Mon, 18 Jun 2018 19:11:40 -0400 Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtp (Exim 4.89) (envelope-from ) id 1fV3J2-0003yk-OL; Mon, 18 Jun 2018 17:11:29 -0600 To: Andy Shevchenko , Alex Williamson Cc: Linux Kernel Mailing List , linux-pci@vger.kernel.org, Linux Documentation List , Stephen Bates , Christoph Hellwig , Bjorn Helgaas , Jonathan Corbet , Ingo Molnar , Thomas Gleixner , "Paul E. McKenney" , Marc Zyngier , Kai-Heng Feng , Frederic Weisbecker , Dan Williams , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Benjamin Herrenschmidt , =?UTF-8?Q?Christian_K=c3=b6nig?= References: <20180618193636.16210-1-logang@deltatee.com> <20180618193636.16210-2-logang@deltatee.com> <20180618154430.1af3d42f@t450s.home> From: Logan Gunthorpe Message-ID: <6df930b0-e0aa-67c3-357b-a366319c2f5d@deltatee.com> Date: Mon, 18 Jun 2018 17:11:22 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: christian.koenig@amd.com, benh@kernel.crashing.org, jglisse@redhat.com, dan.j.williams@intel.com, frederic@kernel.org, kai.heng.feng@canonical.com, marc.zyngier@arm.com, paulmck@linux.vnet.ibm.com, tglx@linutronix.de, mingo@kernel.org, corbet@lwn.net, bhelgaas@google.com, hch@lst.de, sbates@raithlin.com, linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, alex.williamson@redhat.com, andy.shevchenko@gmail.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v3 1/3] PCI: Make specifying PCI devices in kernel parameters reusable X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 18/06/18 05:06 PM, Andy Shevchenko wrote: > On Tue, Jun 19, 2018 at 12:44 AM, Alex Williamson >> There's probably really no path to resolve these, but acknowledging the >> difference in this comment block might be helpful in the future. > > ...or introduce a parser part to allow user supply "any" instead of > numeric value. I think the main difficulty is maintaining backwards compatibility. If anyone is already using zero as a parameter then we will break their system. >>> + pr_info("PCI: Can't parse resource_alignment parameter: pci:%s\n", > >> The "pci:" prefix on %s doesn't make sense now, it was used above when >> the pointer was already advanced past this token, now I believe it would >> lead to "pci:pci:xxxx:yyyy" or "pci:xx:yy.z". Thanks, > > I'm just wondering if we can use pci_info() here, Or it makes no sense? > Also, the original loglevel was an "error". Yeah, I don't think pci_info() makes sense as it's not attached to a specific device. Not sure how I messed up the log level, but I'll fix it for v4. Thanks, Logan -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html