From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 266D0E7D26E for ; Tue, 26 Sep 2023 09:26:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234173AbjIZJ0n (ORCPT ); Tue, 26 Sep 2023 05:26:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234177AbjIZJ0m (ORCPT ); Tue, 26 Sep 2023 05:26:42 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4223611F for ; Tue, 26 Sep 2023 02:26:34 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-3214cdb4b27so7798261f8f.1 for ; Tue, 26 Sep 2023 02:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1695720392; x=1696325192; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:references:cc:to :content-language:subject:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=kmbdPGVs/W/K0GplugB5QvWG9QUiEtGu9P+FlblHW9s=; b=omASNCkvQh8ogDycK6NS67DjKJ9uzDzUSm5qj2PQ42ShbFSp0GjTT1kFT9G8h/y/NP CmD6FuqIQ10+Z9raam3r4/NqUsq7eXuiu9uvf3msORuxNCoxvZ96rhuaJz3VgwGB4Vth vUHV0Rs+bmjfVjEuTYRdZ6Py8lkOBcJCj+6iQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695720392; x=1696325192; h=content-transfer-encoding:in-reply-to:references:cc:to :content-language:subject:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kmbdPGVs/W/K0GplugB5QvWG9QUiEtGu9P+FlblHW9s=; b=QUuUzlWXq7MYf3m4lf0UKXrjijF3vNXxu16CMjFCb7roZ87eJzT0ILqDwhHgvqCUkL jpUvYUr/L7qBxCw4TiYYIGX79LK0mS9QnNA8hC1Iyi1Bf0sDmvTMC/yspmz69dD2Q976 xE4dafXPfcEQybW/3cZQrzjpHLw4T+hW4ijWLotN2R/n9wpO0Eo37oaUdefinnNxRjM5 BLtfA3jfMBHB6+Uqmy6WfXyY8fIQfqakFIXNp2c1fRumQkZZ+tApM8s/wwnGQMA2Jb5M yxEbNTZkHc508YRa2dj8XKHWefZod9K0H11jN0bi7FqrmzjFhi1sg2Kg7yEQOIXNnH18 BRsw== X-Gm-Message-State: AOJu0Yz877+PfZAtsW9q6Om0hWZRjxTABTLwF7x8dth4tNadVAmGxUfy wc/Jv9z7wFR6GrKDbuSl7snKIQ== X-Google-Smtp-Source: AGHT+IGgfHuuM6+TDVmgDCR6/9jB/xVFtYMos7qI/oRqScsqgBiOvBrkuPDQ8QUbO3jvp1Bf0T5msA== X-Received: by 2002:a5d:44ca:0:b0:31f:fdd8:7d56 with SMTP id z10-20020a5d44ca000000b0031ffdd87d56mr8037098wrr.12.1695720392647; Tue, 26 Sep 2023 02:26:32 -0700 (PDT) Received: from [10.80.67.28] (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id o5-20020adfeac5000000b0031984b370f2sm14100219wrn.47.2023.09.26.02.26.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Sep 2023 02:26:32 -0700 (PDT) Message-ID: <6e0064bc-65c1-24f5-c29d-c1d1c027e2d3@citrix.com> Date: Tue, 26 Sep 2023 10:26:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 From: andrew.cooper3@citrix.com Subject: Re: [PATCH v11 05/37] x86/trapnr: Add event type macros to Content-Language: en-GB To: Nikolay Borisov , Xin Li , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, luto@kernel.org, pbonzini@redhat.com, seanjc@google.com, peterz@infradead.org, jgross@suse.com, ravi.v.shankar@intel.com, mhiramat@kernel.org, jiangshanlai@gmail.com References: <20230923094212.26520-1-xin3.li@intel.com> <20230923094212.26520-6-xin3.li@intel.com> <7acd7bb3-0406-4fd9-8396-835bfd951d87@suse.com> In-Reply-To: <7acd7bb3-0406-4fd9-8396-835bfd951d87@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 26/09/2023 9:10 am, Nikolay Borisov wrote: > On 23.09.23 г. 12:41 ч., Xin Li wrote: >> diff --git a/arch/x86/include/asm/trapnr.h >> b/arch/x86/include/asm/trapnr.h >> index f5d2325aa0b7..8d1154cdf787 100644 >> --- a/arch/x86/include/asm/trapnr.h >> +++ b/arch/x86/include/asm/trapnr.h >> @@ -2,6 +2,18 @@ >>   #ifndef _ASM_X86_TRAPNR_H >>   #define _ASM_X86_TRAPNR_H >>   +/* >> + * Event type codes used by FRED, Intel VT-x and AMD SVM >> + */ >> +#define EVENT_TYPE_EXTINT    0    // External interrupt >> +#define EVENT_TYPE_RESERVED    1 >> +#define EVENT_TYPE_NMI        2    // NMI >> +#define EVENT_TYPE_HWEXC    3    // Hardware originated traps, >> exceptions >> +#define EVENT_TYPE_SWINT    4    // INT n >> +#define EVENT_TYPE_PRIV_SWEXC    5    // INT1 >> +#define EVENT_TYPE_SWEXC    6    // INTO, INT3 > > nit: This turned into INTO (Oh) rather than INT0( zero) in v11 Yes, v11 corrected a bug in v10. The INTO instruction is "INT on Overflow".  No zero involved. INT3 is thusly named because it generates vector 3.  Similarly for INT1 although it had the unofficial name ICEBP long before INT1 got documented. If INTO were to have a number, it would need to be 4, but it's behaviour is conditional on the overflow flag, unlike INT3/1 which are unconditional exceptions. ~Andrew