From: Manuel Ebner <manuelebner@mailbox.org>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 5/5] watchdog: dev: convert to kernel-doc comments
Date: Tue, 30 Jun 2026 20:54:45 +0200 [thread overview]
Message-ID: <6edf96b1cc0ead6654b23f2d2b74353cbed621f7.camel@mailbox.org> (raw)
In-Reply-To: <20260529212024.2119204-6-rdunlap@infradead.org>
On Fri, 2026-05-29 at 14:20 -0700, Randy Dunlap wrote:
> [...]
>
> @@ -659,7 +659,7 @@ __ATTRIBUTE_GROUPS(wdt);
> #define wdt_groups NULL
> #endif
>
> -/*
> +/**
> * watchdog_ioctl_op - call the watchdog drivers ioctl op if defined
Maybe this is better:
* watchdog_ioctl_op - call the watchdog drivers ioctl operation if defined
> [...]
> @@ -732,7 +732,7 @@ static ssize_t watchdog_write(struct fil
> return len;
> }
>
> -/*
> +/**
> * watchdog_ioctl - handle the different ioctl's for the watchdog device
I think it's plural:
* watchdog_ioctl - handle the different ioctls for the watchdog device
> * @file: File handle to the device
> * @cmd: Watchdog command
Thanks
Manuel
next prev parent reply other threads:[~2026-06-30 18:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 21:20 [PATCH v2 0/5] watchdog: improve comments & Documentation Randy Dunlap
2026-05-29 21:20 ` [PATCH v2 1/5] watchdog: add devm_watchdog_register_device() to watchdog-kernel-api Randy Dunlap
2026-05-29 21:20 ` [PATCH v2 2/5] watchdog: linux/watchdog.h: repair kernel-doc comments Randy Dunlap
2026-05-29 21:20 ` [PATCH v2 3/5] watchdog: uapi: add comments for what bit masks apply to Randy Dunlap
2026-05-29 21:20 ` [PATCH v2 4/5] watchdog: core: clean up some comments Randy Dunlap
2026-05-29 21:20 ` [PATCH v2 5/5] watchdog: dev: convert to kernel-doc comments Randy Dunlap
2026-06-30 18:54 ` Manuel Ebner [this message]
2026-06-30 19:11 ` Guenter Roeck
2026-06-08 18:53 ` [PATCH v2 0/5] watchdog: improve comments & Documentation Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6edf96b1cc0ead6654b23f2d2b74353cbed621f7.camel@mailbox.org \
--to=manuelebner@mailbox.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox