From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F162184 for ; Mon, 20 Oct 2025 14:17:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760969834; cv=none; b=jhvJxWLLiX2NxcbOcMQcO1apG39sSWl6BGILiTK3e0CZ8O55BRgkbtUKUg+bixcL2nBKtSkmIwgp1UXwshMf/iilujLSQ/OMcoCzKi+7Xh/nQiuvH9x0OZDWxeOUbnmw55VdlBMg+ZBfEoaKtpH4WDM3E2fPXE8ahJji20D1/DI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760969834; c=relaxed/simple; bh=hLn4KX6C+zx+kRhAJwsP0GiYeYzEKw8qqlJ6TVXxhqI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p9ae8Kz36rsHMjDzWke66mVS/2eZlwMEGQ7NxI6XrN4fwgxccbBPoWOBOZlcbEonLDdDVhnzSm+Vql2/laIE60Nw4lK/XxSNFBtapvDjx9EF3ySKqUYJPz31GnYblUFyrujskyAFH7TssgOgma/DshqZBsNV6JP9bp5s2Cc6JWU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JQ93ihut; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JQ93ihut" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760969831; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jfYAKZOWZrksi5qoX4OmGVPw0kd6k84iLxlHCLK7oEE=; b=JQ93ihutCK/paIQW74tfcjiQKMGot+N6cFk1yCRAgQJjDT3Uq82To1zyppvAss6AWy4AQc NlKagnj0h/Bd0uu+TuIDOv9Y+217UoJ/EWqtmkyyuPNRiKBNNME48sORAzMEzSmP3Gi86B r4pzIxrKp7FODwIh/SofpcyB3GcL7yU= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-457-l68wYTUmNb-4pzKIP-XQHw-1; Mon, 20 Oct 2025 10:17:09 -0400 X-MC-Unique: l68wYTUmNb-4pzKIP-XQHw-1 X-Mimecast-MFC-AGG-ID: l68wYTUmNb-4pzKIP-XQHw_1760969829 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-427060bc12dso4802398f8f.0 for ; Mon, 20 Oct 2025 07:17:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760969829; x=1761574629; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jfYAKZOWZrksi5qoX4OmGVPw0kd6k84iLxlHCLK7oEE=; b=YIENt7o5yugUpwdz1kbMjOHEoOW4WLWI9NDDaDVHf1vnEjoB2qlvNbdN8fV1VxsqVA MhCjplavgRbC7njcc1ZLA7oXPpmIS9snbIbClCS6nemJdZRMabXT41ptrn5TalGhpGDn WXcnRdbSRGmyqhnPcfpclbPg6hL/oOq/OIud4TMD+Zuhzo/98uAFSTNq/S0VU1P47tx7 +lJzmeK5nMIrgf6qqXPwhxyeItMIxgCK3hFZz7LSJA6KTB9ZdJZdzWMcJ+RLLAb/PRvZ axM9yIuiu6BsFQXEuuCUUjEBMeH0iHVNJYGr4VC3xNX1xIFEo1wGDs1dyuX6Pe3/WVpQ ibbA== X-Forwarded-Encrypted: i=1; AJvYcCVvd49JmUAPEIRCSB/lk5vUYqsplk2SkOSYqQBOahdMZaVCSIFWZRQ3PrZqMHwdgEDN/ImgJQHEXgg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9/h1OqJgqAhoKrtg8Yrns2OXoawVPeDT8qnRG3kFMM58TUbcF dtIRj39Q04fuBUJa3sVa4pVASQVw3NeVBLpkML6PBnbeRv8Cl506OrLVFhefC7epvvgjsBOwVs6 D/UHIwp+fAWRqIHTNoaVOq9jybyarntyFcbOPdzs5DJYOYfk5ArtbohVq8DckLA== X-Gm-Gg: ASbGncv+A4rORKIEewiKPacNjmKkCy27yqxCqLSiV7j/6mdw4EP0DU1ObVNxadR8zaI 85m5VSYpNDe+atHAobE9dlRsxx4eSfkbK7qsR66ElfvTn10w5nRXkff8VN/4pWa/ixrCuE3MLR6 QcvHFHAferejQXcPXn3/8+SILhE16IjhRF0VSDYopMuktvbc2Nz6iZs/WL726128xJaaiDISBGu 4VvCbEytd/P7VxO8DrD/+L/9vOGIpIAuopBHmZifkdNG4OLWs1YUWl6ws9c8m7lCwIvz6nwLokE WneXcjYsQzjrH6P8fNz6jxJtDDn9zgVJpIYSRoIDmI0HMLbMn7aS/akSuXhJAIFv2dwCAQzFZhU zo+oHLOCWr80YdbIFBFOv1riUC5XPR7djdymjJHzS89G7hKp1miHlNURly9eCVZA638Rgvd+bBR MIx8o5dQPfGAmlvjFbIwY+raInMzg= X-Received: by 2002:a5d:5c89:0:b0:425:6866:6a9e with SMTP id ffacd0b85a97d-42704ca6ba1mr8775147f8f.0.1760969828674; Mon, 20 Oct 2025 07:17:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG6OUvLi2k38V0HguToAtdytTARx3HNV77YTxzJsGCen7movSvk2GULYom+MGJGITAx0cpoXg== X-Received: by 2002:a5d:5c89:0:b0:425:6866:6a9e with SMTP id ffacd0b85a97d-42704ca6ba1mr8775103f8f.0.1760969828192; Mon, 20 Oct 2025 07:17:08 -0700 (PDT) Received: from ?IPV6:2003:d8:2f0c:c200:fa4a:c4ff:1b32:21ce? (p200300d82f0cc200fa4ac4ff1b3221ce.dip0.t-ipconnect.de. [2003:d8:2f0c:c200:fa4a:c4ff:1b32:21ce]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-427f009a993sm15520367f8f.24.2025.10.20.07.17.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Oct 2025 07:17:07 -0700 (PDT) Message-ID: <6fe3562d-49b2-4975-aa86-e139c535ad00@redhat.com> Date: Mon, 20 Oct 2025 16:17:06 +0200 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm, hugetlb: implement movable_gigantic_pages sysctl To: Gregory Price , linux-mm@kvack.org, osalvador@suse.de Cc: corbet@lwn.net, muchun.song@linux.dev, akpm@linux-foundation.org, hannes@cmpxchg.org, laoar.shao@gmail.com, mclapinski@google.com, joel.granados@kernel.org, jack@suse.cz, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Mel Gorman , Michal Hocko , Alexandru Moise <00moses.alexander00@gmail.com>, David Rientjes References: <20251009161515.422292-1-gourry@gourry.net> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20251009161515.422292-1-gourry@gourry.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09.10.25 18:15, Gregory Price wrote: > This reintroduces a concept removed by > commit d6cb41cc44c6 ("mm, hugetlb: remove hugepages_treat_as_movable sysctl") > > This sysctl provides some flexibility between multiple requirements which > are difficult to square without adding significantly more complexity. > > 1) onlining memory in ZONE_MOVABLE to maintain hotplug compatibility > 2) onlining memory in ZONE_MOVABLE to increase reliability of hugepage > allocation. > > When the user's intent for ZONE_MOVABLE is to allow more reliable huge > page allocation (as opposed to enabling hotplugability), disallowing 1GB > hugepages in this region this region is pointless. So if hotplug is not > a requirement, we can loosen the restrictions to allow 1GB gigantic pages > in ZONE_MOVABLE. > > Since 1GB can be difficult to migrate / has impacts on compaction / > defragmentation, we don't enable this by default. However, since there > are scenarios where gigantic pages are migratable (hugetlb available in > multiple places), we should allow use of these on zone movable regions. > > Note: Boot-time CMA is not possible for driver-managed hotplug memory, > as CMA requires the memory to be registered as SystemRAM at boot time. > > Cc: David Hildenbrand > Cc: Mel Gorman > Cc: Michal Hocko > Cc: Alexandru Moise <00moses.alexander00@gmail.com> > Suggested-by: David Rientjes > Signed-off-by: Gregory Price > Link: https://lore.kernel.org/all/20180201193132.Hk7vI_xaU%25akpm@linux-foundation.org/ > --- I just remembered one thing, maybe Oscar knows what I mean: At some point we discussed a possible issue when alloc_contig_range()/alloc_contig_pages() would try to allocate a gigantic folio and would stumble over movable gigantic folios (possibly triggering some recursion when trying to move that one? Not sure). We wanted to avoid having one gigantic folio allocation try to move another gigantic folio allocation. I think your patch would not change anything in that regard: when we scan for a suitable range in alloc_contig_pages_noprof() we call pfn_range_valid_contig() . There, we simply give up whenever we spot any PageHuge(), preventing this issue. However, it also means that we won't try moving 2MB folios to free up a 1GB folio. That could be supported by allowing for moving hugetlb folios when their size is small enough to be served by the buddy, and the size we are allocating is larger than the one of these folios. -- Cheers David / dhildenb