From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 66B057DE74 for ; Tue, 17 Apr 2018 20:40:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752710AbeDQUkX (ORCPT ); Tue, 17 Apr 2018 16:40:23 -0400 Received: from mga02.intel.com ([134.134.136.20]:59222 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752387AbeDQUkV (ORCPT ); Tue, 17 Apr 2018 16:40:21 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2018 13:40:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,464,1517904000"; d="scan'208";a="192266805" Received: from yoojae-mobl1.amr.corp.intel.com (HELO [10.7.153.150]) ([10.7.153.150]) by orsmga004.jf.intel.com with ESMTP; 17 Apr 2018 13:40:18 -0700 Subject: Re: [PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers From: Jae Hyun Yoo To: Rob Herring Cc: Alan Cox , Andrew Jeffery , Andrew Lunn , Andy Shevchenko , Arnd Bergmann , Benjamin Herrenschmidt , Fengguang Wu , Greg KH , Guenter Roeck , Haiyue Wang , James Feist , Jason M Biils , Jean Delvare , Joel Stanley , Julia Cartwright , Miguel Ojeda , Milton Miller II , Pavel Machek , Randy Dunlap , Stef van Os , Sumeet R Pawnikar , Vernon Mauery , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org References: <20180410183212.16787-1-jae.hyun.yoo@linux.intel.com> <20180410183212.16787-8-jae.hyun.yoo@linux.intel.com> <20180416181423.t4vf7sugv6z3aw5h@rob-hp-laptop> <287e0fd9-b631-2602-2785-7b8aaed7a6b9@linux.intel.com> Message-ID: <6ff697e8-cd20-e551-da13-b614cc39f900@linux.intel.com> Date: Tue, 17 Apr 2018 13:40:18 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <287e0fd9-b631-2602-2785-7b8aaed7a6b9@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 4/16/2018 4:51 PM, Jae Hyun Yoo wrote: > On 4/16/2018 4:22 PM, Jae Hyun Yoo wrote: >> On 4/16/2018 11:14 AM, Rob Herring wrote: >>> On Tue, Apr 10, 2018 at 11:32:09AM -0700, Jae Hyun Yoo wrote: >>>> This commit adds dt-bindings documents for PECI cputemp and dimmtemp >>>> client >>>> drivers. >>> [...] >>>> +Example: >>>> +    peci-bus@0 { >>>> +        #address-cells = <1>; >>>> +        #size-cells = <0>; >>>> +        < more properties > >>>> + >>>> +        peci-dimmtemp@cpu0 { >>> >>> unit-address is wrong. >>> >> >> Will fix it using the reg value. >> >>> It is a different bus from cputemp? Otherwise, you have conflicting >>> addresses. If that's the case, probably should make it clear by showing >>> different host adapters for each example. >>> >> >> It could be the same bus with cputemp. Also, client address sharing is >> possible by PECI core if the functionality is different. I mean, >> cputemp and dimmtemp targeting the same client is possible case like >> this. >> peci-cputemp@30 >> peci-dimmtemp@30 >> > > Oh, I got your point. Probably, I should change these separate settings > into one like > > peci-client@30 { >     compatible = "intel,peci-client"; >     reg = <0x30>; > }; > > Then cputemp and dimmtemp drivers could refer the same compatible > string. Will rewrite it. > I've checked it again and realized that it should use function based node name like: peci-cputemp@30 peci-dimmtemp@30 If it use the same string like 'peci-client@30', the drivers cannot be selectively enabled. The client address sharing way is well handled in PECI core and this way would be better for the future implementations of other PECI functional drivers such as crash dump driver and so on. So I'm going change the unit-address only. Thanks, Jae -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html