From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29DC7366557 for ; Tue, 24 Mar 2026 03:41:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774323662; cv=none; b=tWQ8pWOhqnwrjNkw9ODStU1791qfBOFh85cUc0I0eEOEarNf7oKqF4bKIqv0NpQDn8FFZprD19anb03kc6RnV/p+IPhxf5/RhXPIbTOsjmrHjV29nIalbXAGs81q7pSRMtTO5mE+jaQOfxu1ZagyChKkzxOgM/ZpINO48kX1xH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774323662; c=relaxed/simple; bh=at5qO47FiC/Sq0RzqHfPejenzE2Z8Wn2nDR43pAscRU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YSvc1kdXBqK5m6HU1xQACoydwHscQi9uEJDfm5AyS5Xn4rnOZRm5rmklW8rswcOBxD584USOx63guTqMTC/R0odX4GYHK0inDcqYMKGTKhB3kCMnrJI44iw9AgGlOBNIc4NHebE2XsSxmBKNEEYdmJfLBNsHcJT2LUTYs2ikfp4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Zn4G1h6p; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=HcUt8aKH; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Zn4G1h6p"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="HcUt8aKH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774323660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LD86M66XQ6z2RDnVdKVUV2lC/ws2IdjFX4ukZlHTEIA=; b=Zn4G1h6pw1IDZCrFMdhPoJ9FZRsncG1dVIVvAeeWZcj8t/2xpXYWRkwHvwYtU4YNK/LsFq PbyL75LmwEZ6atFVRt7p+GY1A5BWI4BywnES603+1z1VJ8R79XOLUGeLPaV1YPBGws04tF GpNnyLhLEcxVjBuDsVxyt+DlVomAYi0= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-605-vk6RnvNjPyKiuNojtw93AA-1; Mon, 23 Mar 2026 23:40:58 -0400 X-MC-Unique: vk6RnvNjPyKiuNojtw93AA-1 X-Mimecast-MFC-AGG-ID: vk6RnvNjPyKiuNojtw93AA_1774323658 Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c70f19f0f37so3128166a12.0 for ; Mon, 23 Mar 2026 20:40:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774323657; x=1774928457; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LD86M66XQ6z2RDnVdKVUV2lC/ws2IdjFX4ukZlHTEIA=; b=HcUt8aKHijqsHmnVhQ11HbdzlJAxEVq0oiXNsKlHzlqTL3kLbP18ulFLEtobcd35CR AQZ5Cg2WFFTNbuAdhbR0L+6fZ/NRdenaWjG9xdZscSu2OItOhqWgX07+3YHAbOsMyvLb jxiooO+SbWBYP91uP8gyzR7jeS1XFYJMfmGICTUGMNf3EiJ/yKrgsHf0179SHaoL8AuU LHoq74XekcZlOgl21Vu1uObfnq84bIhVhVvbaTQf61Oe8uvAmj5G241RVC0LayJTsk/g rzPc1UDs8QjHu3pfqFUO3yC46MAW/DaQzL7fIjwNP57V5maKGIx5QWSziUKD08BWw/vX ZcMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774323657; x=1774928457; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LD86M66XQ6z2RDnVdKVUV2lC/ws2IdjFX4ukZlHTEIA=; b=Xew13+61kkUcc9JYtLZG+ofKhdKQQMl5syjW5KCjvX6W18S5/iM+mFu2fEDr/z4fzv wnRO3MxzRYC5jWYqQVfVFmJpdp1lTmQl3PTlr3KVWYVbH3qVi0gihH0g5sMZqYOGrWx0 aJfFnCOFm0XSXV8uVEZkW+TLw8h4pgA6ZLkmXbUX3rSz4vjgvcOUBMbwPFqkSXgymxfP YIwGVcFAEv2nHPvNDPgcLXmUMsTyvxRrYsebzK0Isf7VzlGYLGkUkgwx+QFtrYOt/ha7 tZXZoowCQJjKEW8Pl5oxcYOC+Q3tzRKbyz4tiY0+7nS0YyQCqn+DL7fc9kqEd8jOwX60 HamQ== X-Forwarded-Encrypted: i=1; AJvYcCWhJV1KCExtcTk2cJOa95oHFM7HfLdiLIUUEzSmKIFQQrS68jxr3TBW1vIjX2dfqsXjmxNatwDkkWA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw27vRsUTECraJ2H2JBEds2c+wP6oW1tFRiL/KRuoW6rHmkf3uh 2NSndvWAlhiIuTzVcUyG3Gd/0PuzxdmPHfCmHDVPADeVETUKQAHX1Ur66OhUCM1in+VKieBN3/Z v7kPuW8z2isUYrS+Vv5pNra8wHhkd0XYtN6ZyN39eesv5up8vafdR5mMHGBNHOg== X-Gm-Gg: ATEYQzzjXwDeN98cFJb26u5df/Uyxps9cT6SbEhr6/qVnXKCAdDf0zptykW1OlVMHVA /EccBU+590fbVfpYSl2A9aB66N0NHyLTvkbcF9VY8FZWSDoN0y9d2pWaWj5i52qLXAz2c0vn1p0 LyqAMla/M3j/5NHX2oyMrejHl8UbzvdmXm3T0oRCA7wHozbFH/Afv8gTYzRXNRR3KyrAIi0T3hz uyuqB8IGKrY3w+VpT2pUH8pPddDh4h0s9b8AbHEBOuAAxfSHe9LtA5/vlteqTJhKrtur5UXuMDs UG+HUbcR9m7VNJgPhZqevy4T0BnyaUWd9MQppHQzlgoVZ/wWTVQRUFAg5R3Jb6bpq8km/tKCser APm/tX1KW/fiATpx2xDzuDz8UDrsisc4m9gWY0tm3vi6pZ/at375gybuZB6diclU7 X-Received: by 2002:a05:6a00:2d82:b0:82a:67ce:66de with SMTP id d2e1a72fcca58-82c5bdb0f77mr1586850b3a.14.1774323657558; Mon, 23 Mar 2026 20:40:57 -0700 (PDT) X-Received: by 2002:a05:6a00:2d82:b0:82a:67ce:66de with SMTP id d2e1a72fcca58-82c5bdb0f77mr1586793b3a.14.1774323657062; Mon, 23 Mar 2026 20:40:57 -0700 (PDT) Received: from [192.168.68.51] (n175-34-8-244.mrk21.qld.optusnet.com.au. [175.34.8.244]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b0354baefsm11044528b3a.0.2026.03.23.20.40.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2026 20:40:56 -0700 (PDT) Message-ID: <6ff8f2f2-e7b9-49a5-bbc1-3cfdc2fff4fb@redhat.com> Date: Tue, 24 Mar 2026 13:40:41 +1000 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 28/40] arm_mpam: resctrl: Add support for csu counters To: Ben Horgan Cc: amitsinght@marvell.com, baisheng.gao@unisoc.com, baolin.wang@linux.alibaba.com, carl@os.amperecomputing.com, dave.martin@arm.com, david@kernel.org, dfustini@baylibre.com, fenghuay@nvidia.com, james.morse@arm.com, jonathan.cameron@huawei.com, kobak@nvidia.com, lcherian@marvell.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, peternewman@google.com, punit.agrawal@oss.qualcomm.com, quic_jiles@quicinc.com, reinette.chatre@intel.com, rohit.mathew@arm.com, scott@os.amperecomputing.com, sdonthineni@nvidia.com, tan.shaopeng@fujitsu.com, xhao@linux.alibaba.com, catalin.marinas@arm.com, will@kernel.org, corbet@lwn.net, maz@kernel.org, oupton@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, kvmarm@lists.linux.dev, zengheng4@huawei.com, linux-doc@vger.kernel.org, Shaopeng Tan References: <20260313144617.3420416-1-ben.horgan@arm.com> <20260313144617.3420416-29-ben.horgan@arm.com> Content-Language: en-US From: Gavin Shan In-Reply-To: <20260313144617.3420416-29-ben.horgan@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/14/26 12:46 AM, Ben Horgan wrote: > From: James Morse > > resctrl exposes a counter via a file named llc_occupancy. This isn't really > a counter as its value goes up and down, this is a snapshot of the cache > storage usage monitor. > > Add some picking code which will only find an L3. The resctrl counter > file is called llc_occupancy but we don't check it is the last one as > it is already identified as L3. > > Tested-by: Shaopeng Tan > Tested-by: Zeng Heng > Tested-by: Punit Agrawal > Reviewed-by: Zeng Heng > Reviewed-by: Shaopeng Tan > Reviewed-by: Jonathan Cameron > Signed-off-by: James Morse > Co-developed-by: Dave Martin > Signed-off-by: Dave Martin > Signed-off-by: Ben Horgan > --- > Changes since rfc: > Allow csu counters however many partid or pmg there are > else if -> if > reduce scope of local variables > drop has_csu > > Changes since v2: > return -> break so works for mbwu in later patch > add for_each_mpam_resctrl_mon > return error from mpam_resctrl_monitor_init(). It may fail when is abmc > allocation introduced in a later patch. > Squashed in patch from Dave Martin: > https://lore.kernel.org/lkml/20250820131621.54983-1-Dave.Martin@arm.com/ > > Changes since v3: > resctrl_enable_mon_event() signature update > Restrict the events considered > num-rmid update > Use raw_smp_processor_id() > Tighten heuristics: > Make sure it is the L3 > Please shout if this means the counters aren't exposed on any platforms > Drop tags due to change in policy/rework > > Changes since v4: > Move generic monitor boilerplate to separate patch > --- > drivers/resctrl/mpam_resctrl.c | 83 ++++++++++++++++++++++++++++++++++ > 1 file changed, 83 insertions(+) > Reviewed-by: Gavin Shan