From: Paolo Abeni <pabeni@redhat.com>
To: Fan Gong <gongfan1@huawei.com>, Zhu Yikai <zhuyikai1@h-partners.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Bjorn Helgaas <helgaas@kernel.org>, luosifu <luosifu@huawei.com>,
Xin Guo <guoxin09@huawei.com>,
Shen Chenyang <shenchenyang1@hisilicon.com>,
Zhou Shuai <zhoushuai28@huawei.com>, Wu Like <wulike1@huawei.com>,
Shi Jing <shijing34@huawei.com>,
Fu Guiming <fuguiming@h-partners.com>,
Meny Yossefi <meny.yossefi@huawei.com>,
Gur Stavi <gur.stavi@huawei.com>, Lee Trager <lee@trager.us>,
Michael Ellerman <mpe@ellerman.id.au>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Suman Ghosh <sumang@marvell.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Joe Damato <jdamato@fastly.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH net-next v13 1/8] hinic3: Async Event Queue interfaces
Date: Tue, 19 Aug 2025 15:22:01 +0200 [thread overview]
Message-ID: <715111b5-6cd1-45c0-b398-b5d8bec7f24f@redhat.com> (raw)
In-Reply-To: <4a3fbb9455305898257760e2a13cc072b475489b.1755176101.git.zhuyikai1@h-partners.com>
On 8/15/25 3:01 AM, Fan Gong wrote:
> +static void remove_eq(struct hinic3_eq *eq)
> +{
> + hinic3_set_msix_state(eq->hwdev, eq->msix_entry_idx,
> + HINIC3_MSIX_DISABLE);
> + free_irq(eq->irq_id, eq);
> + /* Indirect access should set q_id first */
> + hinic3_hwif_write_reg(eq->hwdev->hwif,
> + HINIC3_EQ_INDIR_IDX_ADDR(eq->type),
> + eq->q_id);
> +
> + cancel_work_sync(&eq->aeq_work);
The above should be 'disable_work_sync()' to avoid the work being
re-scheduled by the flushed handler and later UaF.
/P
next prev parent reply other threads:[~2025-08-19 13:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 1:01 [PATCH net-next v13 0/8] net: hinic3: Add a driver for Huawei 3rd gen NIC - management interfaces Fan Gong
2025-08-15 1:01 ` [PATCH net-next v13 1/8] hinic3: Async Event Queue interfaces Fan Gong
2025-08-19 13:22 ` Paolo Abeni [this message]
2025-08-15 1:01 ` [PATCH net-next v13 2/8] hinic3: Complete " Fan Gong
2025-08-15 1:01 ` [PATCH net-next v13 3/8] hinic3: Command Queue framework Fan Gong
2025-08-15 1:02 ` [PATCH net-next v13 4/8] hinic3: Command Queue interfaces Fan Gong
2025-08-15 1:02 ` [PATCH net-next v13 5/8] hinic3: TX & RX Queue coalesce interfaces Fan Gong
2025-08-15 1:02 ` [PATCH net-next v13 6/8] hinic3: Mailbox framework Fan Gong
2025-08-19 13:36 ` Paolo Abeni
2025-08-15 1:02 ` [PATCH net-next v13 7/8] hinic3: Mailbox management interfaces Fan Gong
2025-08-15 1:02 ` [PATCH net-next v13 8/8] hinic3: Interrupt request configuration Fan Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=715111b5-6cd1-45c0-b398-b5d8bec7f24f@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=christophe.jaillet@wanadoo.fr \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fuguiming@h-partners.com \
--cc=gongfan1@huawei.com \
--cc=guoxin09@huawei.com \
--cc=gur.stavi@huawei.com \
--cc=helgaas@kernel.org \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=lee@trager.us \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luosifu@huawei.com \
--cc=meny.yossefi@huawei.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=shenchenyang1@hisilicon.com \
--cc=shijing34@huawei.com \
--cc=sumang@marvell.com \
--cc=vadim.fedorenko@linux.dev \
--cc=wulike1@huawei.com \
--cc=zhoushuai28@huawei.com \
--cc=zhuyikai1@h-partners.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).