From: Frank Rowand <frowand.list@gmail.com>
To: Rae Moar <rmoar@google.com>,
davidgow@google.com, skhan@linuxfoundation.org,
keescook@chromium.org, Tim.Bird@sony.com,
brendanhiggins@google.com
Cc: corbet@lwn.net, guillaume.tucker@collabora.com,
dlatypov@google.com, kernelci@groups.io,
kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [KTAP V2 PATCH] ktap_v2: add skip test result
Date: Sat, 11 Mar 2023 21:25:16 -0600 [thread overview]
Message-ID: <7180be2d-60c7-0d99-338e-b818771b310f@gmail.com> (raw)
In-Reply-To: <20230310222002.3633162-1-rmoar@google.com>
On 3/10/23 16:20, Rae Moar wrote:
> Add the test result "skip" to KTAP version 2 as an alternative way to
> indicate a test was skipped.
>
> The current spec uses the "#SKIP" directive to indicate that a test was
> skipped. However, the "#SKIP" directive is not always evident when quickly
> skimming through KTAP results.
>
> The "skip" result would provide an alternative that could make it clearer
> that a test has not successfully passed because it was skipped.
>
> Before:
>
> KTAP version 1
> 1..1
> KTAP version 1
> 1..2
> ok 1 case_1
> ok 2 case_2 #SKIP
> ok 1 suite
>
> After:
>
> KTAP version 2
> 1..1
> KTAP version 2
> 1..2
> ok 1 case_1
> skip 2 case_2
> ok 1 suite
>
> Here is a link to a version of the KUnit parser that is able to parse
> the skip test result for KTAP version 2. Note this parser is still able
> to parse the "#SKIP" directive.
>
> Link: https://kunit-review.googlesource.com/c/linux/+/5689
>
> Signed-off-by: Rae Moar <rmoar@google.com>
> ---
< snip >
Another reason to add the "skip" result is that there was disagreement in previous
discussions as to whether the "#SKIP" directive should be used in an "ok" result
or a "not_ok" result.
next prev parent reply other threads:[~2023-03-12 3:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 22:20 [KTAP V2 PATCH] ktap_v2: add skip test result Rae Moar
2023-03-11 17:36 ` Bird, Tim
2023-03-12 4:02 ` Frank Rowand
2023-03-14 22:03 ` Rae Moar
2023-03-15 12:53 ` Mark Brown
2023-03-15 21:45 ` Frank Rowand
2023-03-16 11:33 ` Mark Brown
2023-03-16 17:49 ` Frank Rowand
2023-03-12 3:14 ` Frank Rowand
2023-03-12 3:25 ` Frank Rowand [this message]
2023-03-12 3:52 ` Frank Rowand
2023-03-13 14:41 ` Frank Rowand
2023-03-26 23:36 ` Frank Rowand
2023-03-14 22:20 ` Rae Moar
2023-03-15 13:08 ` Guillaume Tucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7180be2d-60c7-0d99-338e-b818771b310f@gmail.com \
--to=frowand.list@gmail.com \
--cc=Tim.Bird@sony.com \
--cc=brendanhiggins@google.com \
--cc=corbet@lwn.net \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=guillaume.tucker@collabora.com \
--cc=keescook@chromium.org \
--cc=kernelci@groups.io \
--cc=kunit-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rmoar@google.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox