From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70E5E26F2A8; Fri, 19 Dec 2025 19:11:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766171472; cv=none; b=HtZvQ+tRjCbhAsYLddHdtYwLbZb8XWjObeJLaG6YS9pOPi/wtiPrGpgzPVRADovYMujQ4FtTClU2hwwo5AC8gg4V+5ktX07UncCOswlEfVieokFPhGY7v/gf2YGld5AroXiRiBQyX3tFfCkfMDttvNXfeSHC65lZ9Hru9EMQOmM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766171472; c=relaxed/simple; bh=zH9xLhrr0JJqrDsiBJ+O4UpNDV0/WnkG8Vui4YjMsbI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Mmg5lI9gBrKQdKXcVgU4FVTJ1Td/5qwyHEs2UXBVKyC2FeauhiFY4qCAlu2thalSRyi3jLC3R9DF1tfy6mPJtE7sCHK9IKnNDBZt1jvoo1cIdiTUEPOUOLhFR1JlUH4GbzbOWsQcdz6Ab4ynFyhlgzvtDTciX7eEmN60sagbzhA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=XC2/lN1x; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="XC2/lN1x" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id C87FC1A22FA; Fri, 19 Dec 2025 19:11:06 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 9DF656071D; Fri, 19 Dec 2025 19:11:06 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 98737102F0BC0; Fri, 19 Dec 2025 20:10:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1766171463; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=Ug66R9FnI9fcgiVr7X3wQd7beMpX5BAaPDYcsdzzrsY=; b=XC2/lN1xpxPHx765W3PubGbvXiOCuW13gXYNWZx3d736bAqa9UnedBbbo4zK3HVkOUkbVc H+w+17j4dqHEAoI942rB2eXkZlegYZum8EOoU4s6xSiMK4tsicndcSW7qJghryiGwzxMqZ 1CdkFo7oBPoRenGd33d5C324s/1QFl+4FELvmzcSyL71BYuItor2cj1mlcBJG9c7fQeHre ixsK6E6NGFyqIjO7BNSMX5MYE5D2ZFkSyxBv3QMoBf4HozON4DKxVs1TOGr3SVZETpz+Qe 6lA4fGoZMCcyVXdS9YEXJisSmlkEP48EhtUHBuw9VTprwxUisOteDZMV5SVkrw== Message-ID: <76417a1c-1179-4e47-ab2d-00048116bfae@bootlin.com> Date: Fri, 19 Dec 2025 20:11:09 +0100 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v2 29/32] drm/vkms: Rename vkms_connector_init to vkms_connector_init_static To: Luca Ceresoli , Haneen Mohammed , Simona Vetter , Melissa Wen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , jose.exposito89@gmail.com, Jonathan Corbet Cc: victoria@system76.com, sebastian.wick@redhat.com, thomas.petazzoni@bootlin.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <20251029-vkms-all-config-v2-0-a49a2d4cba26@bootlin.com> <20251029-vkms-all-config-v2-29-a49a2d4cba26@bootlin.com> From: Louis Chauvet Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 12/19/25 19:58, Luca Ceresoli wrote: > On Wed Oct 29, 2025 at 3:37 PM CET, Louis Chauvet wrote: >> With the introduction of dynamic connectors we will have two way of >> initializing a VKMS connector. Rename the current function to clarify >> the case. >> >> Signed-off-by: Louis Chauvet > >> --- a/drivers/gpu/drm/vkms/vkms_connector.h >> +++ b/drivers/gpu/drm/vkms/vkms_connector.h >> @@ -4,6 +4,7 @@ >> #define _VKMS_CONNECTOR_H_ >> >> #include "vkms_drv.h" >> +#include "vkms_config.h" > > Why? Maybe this is for another patch in the series? This line is useful, I use struct vkms_config_connector But I agree, this should be a separate patch. > With that line removed: > > Reviewed-by: Luca Ceresoli > > > -- > Luca Ceresoli, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com