From: Krzysztof Kozlowski <krzk@kernel.org>
To: CaoRuichuang <create0818@163.com>, corbet@lwn.net
Cc: skhan@linuxfoundation.org, workflows@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: use acknowledgment in submitting-patches
Date: Sun, 5 Apr 2026 21:30:02 +0200 [thread overview]
Message-ID: <797436d2-6579-4563-a033-329992b101f2@kernel.org> (raw)
In-Reply-To: <20260405183602.73797-1-create0818@163.com>
On 05/04/2026 20:36, CaoRuichuang wrote:
> Signed-off-by: CaoRuichuang <create0818@163.com>
> ---
> Documentation/process/submitting-patches.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> index e69d19a..5c44be9 100644
> --- a/Documentation/process/submitting-patches.rst
> +++ b/Documentation/process/submitting-patches.rst
> @@ -486,9 +486,9 @@ reviewed it as thoroughly as if a Reviewed-by: was provided. Similarly, a key
> user may not have carried out a technical review of the patch, yet they may be
> satisfied with the general approach, the feature or the user-facing interface.
>
> -Acked-by: does not necessarily indicate acknowledgement of the entire patch.
> +Acked-by: does not necessarily indicate acknowledgment of the entire patch.
Pointless change. You are replacing one correct spelling with another
correct one. And your commit msg is empty...
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-04-05 19:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-05 18:36 [PATCH] docs: use acknowledgment in submitting-patches CaoRuichuang
2026-04-05 19:30 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=797436d2-6579-4563-a033-329992b101f2@kernel.org \
--to=krzk@kernel.org \
--cc=corbet@lwn.net \
--cc=create0818@163.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox