From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A57C93F9F38 for ; Tue, 25 Aug 2026 10:43:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787654634; cv=none; b=K4tKJLmI1RudVIrYOYDAsp5ihicjAOdZs1LiEv+hls2nPvL4BaQCnYZv2op7l5bhGftg/VAVcb3uMIq5Y+OIyD5RbnBazq+pxcweukZqP3LfvVb+uEjSqwW3jWUZED1Ne1QFnvDLTisfKbTehRN4n3LBvB+dOg9094Br+2xh4r0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787654634; c=relaxed/simple; bh=QFInQJXondlUA70nRR+VYLFa+WvVwFUjN0rN7mFQJiQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=o2TBvwSDtZfuDTWmfaDuWoMJ3qjuzfwafpUcLt09vL9J2CMcldReLqk1FlIrf1rdPK4/7jPvWxlDFYNfHDeULX8/Ndb6B7aiQA513V1dx7SM8D4X2fj9xMTWS0KCGJpUcYjJfHWOAF+W5QakSVcYYTmFQkwkYgCuDvNcOfh6ri8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a/Wc1RY5; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a/Wc1RY5" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-c15d47266baso532008066b.3 for ; Tue, 25 Aug 2026 03:43:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787654631; x=1788259431; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UviVHg4iRcsv0fdKQmMFuzXb6W/9vw8IV+1dqwY6Nl4=; b=a/Wc1RY5XNJNyi9xtalA395JKQG+d/KRFLbhD3MT26pBIykJU04GXtl4wMSgGelycJ zAS6WKB3joeIIDyOe4rCBaxAPG7DIrUOuh/85cYs6Ksp/0l16Slw7xqde576FqGeINxH w6cxm3yK090PL466jRpAbgXTzZuvmv5bXfKrJbDPhTKl8Xd3/i8KyoDSy8jQl8MdzRDr nw2SpeA6Iza/3I/5fojrkDdUffa95lLQoJRf/hrx1YdEqpGTczUm/suVmYMnVu+Z9H4v ecciR3KkNTFvhSLlkRgd1oi1se5GyGJvs2YkvWiRyC1lbw0FPrJ3YfffAx5968bVjzAv Zeag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787654631; x=1788259431; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UviVHg4iRcsv0fdKQmMFuzXb6W/9vw8IV+1dqwY6Nl4=; b=d4RWQhbLHTRsQ4FR6EPXpIy3CtdW0MjcP8aVelIcxCh9DpSebH14EtfSlzh88AGRKC 9xew2AgcTuHrF7wre5UlIRzOT+/koRy2fTKvk0kaXweRVwTmwP5Nlh5PLD/LQgp3/vCB lCmzVv7YH2X3O6nG3LYcF26s8GZOxVKx4jN7eEVDXm9UJJljiNGfEDqNzhxEm1C5RnXG 9oqmjIKXnNSz5iql+5SmhqH1ceT/G3JAflQTf4s4NtVlp71uY2taozUOaOHBemdrLX5u 7FWF6RNZUduvu0lxHj2ZKaam5k1zOWvz/Tk1oy+CKghgGdvc50YNBeM+a78OLaJuZXAQ 6ypw== X-Forwarded-Encrypted: i=1; AHgh+RpWoOeHnSani/JWFgmrtW67KxiQxFYUbEZlIO2sDGvCgPTPXtHUfQ5BnHA/r+Ing78dJLgygdhfmQ8=@vger.kernel.org X-Gm-Message-State: AFuF++mIt+YzKaYgFW80jT2UxEJyzzM1WhY0Lw2RzCzYvDIek5wJdAd4 wkmH5pnQOVejw5YsiGcT5ffn9DF87iB8xDfZlp8yXxUEWNlRtZT66pdG X-Gm-Gg: AR+sD12NM4FcXOpz3srs6XLBcSeJLfHoCfH8UNA2hlchWq557yn7uXO7ZNrOSlzwCCx zt6SmxscIkpj+xUvwAHxc9dlB4z25+J41DdFMFj5b5rSxe6waXPN356rMrdGTEQGZWoOS6Amnj3 BfAGs6AqYn/tWQqkXMR8lCS6BegQHf1HgxJYckACIbUIHor1fOWTrurJ9KCvQNoL6bVNYz1cwQt vT/fSJvhnpLtTUPIwp+VqiJ4VtJ4Sdgs1G11c/1K+oT3VGUQaVjlI09UHqrlppXLEJ3JGnNdsx1 5ppLjTmnWpThikhcRpQwlyGmpocoaLltMUzCx4PksoQZ2+I2ha9KdMnsPdLNouDfju4n9MPiCDw U1ibRWnYzKc8Tqtp439HYv7A+T4hl2ax/Y29tchRy92VsZ8pv/EeZWoNmK7yobT2EVO3JLtpYh4 NEW8prGlW2IhLAD5dxM80s6RVkhJ92iBbG3R+k1p3IZECqb5SMQmC/VvcJ+oxKJ8yGYquhL/Vyk 4Erc6nrNRmVNYDQ7wYgGV5SX38PZy9+WcYeugDeuSp+JnSiZfQnZ0ud X-Received: by 2002:a17:907:8995:b0:c24:4128:c19d with SMTP id a640c23a62f3a-c24e584dc37mr540823866b.4.1787654630510; Tue, 25 Aug 2026 03:43:50 -0700 (PDT) Received: from [172.24.138.145] (dynamic-176-007-058-112.176.7.pool.telefonica.de. [176.7.58.112]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a59e1d741asm13240282a12.27.2026.08.25.03.43.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Aug 2026 03:43:50 -0700 (PDT) Message-ID: <79c44439-86a3-4eba-bd6f-44423c59c17d@gmail.com> Date: Tue, 25 Aug 2026 12:43:47 +0200 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 05/14] iio: adc: Add AD7768 and AD7768-4 core support To: David Lechner , Janani Sunil , =?UTF-8?Q?Nuno_S=C3=A1?= , Michael Hennerich , Jonathan Cameron , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Olivier Moysan , Philipp Zabel , Linus Walleij , Bartosz Golaszewski , Jonathan Corbet , Shuah Khan , Michael Walle Cc: linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org, =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= References: <20260821-ad7768-driver-v4-0-bb8fbd06d4eb@analog.com> <20260821-ad7768-driver-v4-5-bb8fbd06d4eb@analog.com> <10d575af-2a2c-484b-82b0-0a00de1c50be@baylibre.com> Content-Language: en-US From: Janani Sunil In-Reply-To: <10d575af-2a2c-484b-82b0-0a00de1c50be@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/22/26 19:30, David Lechner wrote: > > On 8/21/26 9:06 AM, Janani Sunil wrote: >> Add core support for the AD7768 and AD7768-4 simultaneous sampling ADCs. >> Configure supplies, clock and reset, use a custom regmap bus for the SPI >> protocol, and parse the enabled channels and input buffer settings from >> devicetree. >> >> Connect the converter to an IIO backend for buffered capture with CRC, >> provide a fixed safe wideband sampling configuration and add runtime >> power management. >> >> Signed-off-by: Janani Sunil >> --- ... >> +static int ad7768_regmap_read(void *context, const void *reg_buf, >> + size_t reg_size, void *val_buf, size_t val_size) >> +{ >> + struct ad7768_state *st = spi_get_drvdata(context); >> + struct spi_device *spi = context; >> + struct spi_transfer t[] = { >> + { >> + .tx_buf = &st->d16, >> + .len = sizeof(st->d16), >> + .cs_change = 1, >> + }, { >> + /* >> + * Register responses are delayed by one CS frame. While >> + * receiving the response to this read, the device also >> + * decodes another command on SDI. Repeat the read >> + * command to avoid sending an unspecified dummy >> + * command. > Could this have unintended concequences? E.g. register writes that have > size-effects, like reset or clearing status registers. Repeating the command cannot trigger reset or other write side effects. The device also does not have any read-to-clear registers. Thanks, Jan