From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 754E5299A85 for ; Tue, 8 Jul 2025 07:43:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751960636; cv=none; b=hJxNHfxCRg8eHbudb87sIKPbA8+5BE++gOh+XsdEBieXjGEFNA62MdDdEP70t5eYnyNqav88o0jPc0hVVvd88nKnQlk2JM7dqyFQRNFkW6teLVhJGkndHl7KR4S0FvmAAiPM+f7wokpUmG4F+vAI57iHfNA75NMbSrDNv+F9k0c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751960636; c=relaxed/simple; bh=F5MpHapmLfuB6EvTtAG4tHy29JewS89LYG6Uev1XsUU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KjmrvbWEc62np//wmtfSSkbnmicNGcfbCs24QSYlxCRqePz95RPE1gI6Q3mhq4IlOBDPlDN2DERYIsgA4olHgYL5Kg66uA/o6tbejuzzJvjW/mjLSOXE9SjF7jBssgP24ftcoeH+QIpBJZuXcTz1CPX89ZbB8x2fKno3YDX8mt4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=FYA0mAho; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FYA0mAho" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751960633; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PHZ3xvdg+8KBkT9ekm9uucUlDD68MoOhrjvY7t8qBig=; b=FYA0mAho1KmznhgmgviX3LSCDEnYBOHdMRGRq6j81QemHVnQblak3Nfgt4mIzl1/cEvde4 ZjcYZZ72IFYrxHGWPPO076q7hectnkRhbEzZ7paaJsHDFfJ43PqfRLFHNSqxBymgbKjhUY aRNxrVhx4VngAxu5tZpdPbkMUjMNrpI= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-94-6245IF18NF6Nm_0zkRfGCQ-1; Tue, 08 Jul 2025 03:43:51 -0400 X-MC-Unique: 6245IF18NF6Nm_0zkRfGCQ-1 X-Mimecast-MFC-AGG-ID: 6245IF18NF6Nm_0zkRfGCQ_1751960631 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a6df0c67a6so2265445f8f.3 for ; Tue, 08 Jul 2025 00:43:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751960630; x=1752565430; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=PHZ3xvdg+8KBkT9ekm9uucUlDD68MoOhrjvY7t8qBig=; b=f5Nz1HLudUb1jkhQ7psN/xtNKRlsekVBzr+eo902UhspZwCrw6sYBZ2s9BrrCLOBiI loZ4doFqoiv/yiiYDiRyRTU4ChuZw5KL25u2P2Uh9itFiEfj5UV3LqJIfjNJVcIkjzBz Tlf6xZEIlHSJ49qLAXkWNJwYH1AZmiYEEZ3lK3+c4kKg7n1AvEXGCC/Ok4F3cZmphwJf 47JETdl6Y5M4MLNJO/RbCkIRmKQzjIWEFe36bjM6LL0plB3wwwilBXfBq9BJikuMudJH dkvg49eoGTz9POJTZeXcXo1zW9YE1hyVj2fd3OsW6Fy7KeQ/UOCFUqnDbZiJOCH8hDIM SLvA== X-Forwarded-Encrypted: i=1; AJvYcCU42iBc+BwqGC2ZUQdK/dlPDqtflEHcbl0ewfgiYlmUTu26HJP9OrSJhsSfag4JJB2PeVHL/XinM24=@vger.kernel.org X-Gm-Message-State: AOJu0YwW06rsd9jzCZit2hDWrv761GefFPFmCcIRc2gyNxU5MLENWeU/ scsYLGvwwbDBuFPC/61nvGgFplLGQKLvjk70EvBaBPo/8JFDeq0mKUgzHcJg3SPSv2Hj+pX5aav ZzB0mHMKpy1Q/0yPwimox6FK5DiMhTAnlBry/bbIshU6AhFISkWTk0/YWVGwKOw== X-Gm-Gg: ASbGnctqrrw3rV6TAQjvApnPoK9tDVr3mmK+ClhDq4XBs+/vvJ5GRW+agPPI/bIIbSA 0szchJG8pYZ+nHEIucgejw0hUhz/iFxvIh9VP3Pnc/0mN3qTlk9Vk13s+bsfA+E9QJ5hke7eFaN LbOjFnyRICod0hRqIoTqfxF3ODB7FqFYSSzczrMliRrQum4GD0/1XrYRm670AKxUd60HngSwZna Jatnq8CcLhqOfNjHIKwwTGrzlZ3QFsymZEIUE/ksiXzgwJPndMW0bY+lBBG3Kaao72Er0CijSED nFAy/aZfJAIYbIu5U/jkor44GASO9Mzw327mTm3Z48VqD9ibC6b5gMS4oCLGyYeMnpCaNBk5PRL 0JTEbU1QmX8cuZuDuf73kpFMns0p5IYuX5W1GZt8gREXIh5D61Q== X-Received: by 2002:a05:6000:470f:b0:3b2:fe46:9812 with SMTP id ffacd0b85a97d-3b497015268mr10206022f8f.19.1751960630483; Tue, 08 Jul 2025 00:43:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHdyLGgvPShNDAS1NZe5c9F4HjwpnyI4qzbk2LaZP5mfvehBW/XkwrJq9VQ/ULZcNouddeW3Q== X-Received: by 2002:a05:6000:470f:b0:3b2:fe46:9812 with SMTP id ffacd0b85a97d-3b497015268mr10205981f8f.19.1751960629973; Tue, 08 Jul 2025 00:43:49 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1a:f500:4346:f17c:2bde:808c? (p200300d82f1af5004346f17c2bde808c.dip0.t-ipconnect.de. [2003:d8:2f1a:f500:4346:f17c:2bde:808c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b471b975efsm12017650f8f.46.2025.07.08.00.43.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Jul 2025 00:43:49 -0700 (PDT) Message-ID: <7b10d751-8e57-4cb9-b2a1-844695c95c73@redhat.com> Date: Tue, 8 Jul 2025 09:43:47 +0200 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] Restrict module namespace to in-tree modules and rename macro To: Christian Brauner , Vlastimil Babka Cc: Matthias Maennich , Jonathan Corbet , Luis Chamberlain , Petr Pavlu , Sami Tolvanen , Daniel Gomez , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Alexander Viro , Jan Kara , Christoph Hellwig , Peter Zijlstra , Shivank Garg , "Jiri Slaby (SUSE)" , Stephen Rothwell , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20250708-export_modules-v1-0-fbf7a282d23f@suse.cz> <20250708-merkmal-erhitzen-23e7e9daa150@brauner> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250708-merkmal-erhitzen-23e7e9daa150@brauner> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08.07.25 09:40, Christian Brauner wrote: > On Tue, Jul 08, 2025 at 09:28:56AM +0200, Vlastimil Babka wrote: >> Christian asked [1] for EXPORT_SYMBOL_FOR_MODULES() without the _GPL_ >> part to avoid controversy converting selected existing EXPORT_SYMBOL(). >> Christoph argued [2] that the _FOR_MODULES() export is intended for >> in-tree modules and thus GPL is implied anyway and can be simply dropped >> from the export macro name. Peter agreed [3] about the intention for >> in-tree modules only, although nothing currently enforces it. >> >> It seems straightforward to add this enforcement, so patch 1 does that. >> Patch 2 then drops the _GPL_ from the name and so we're left with >> EXPORT_SYMBOL_FOR_MODULES() restricted to in-tree modules only. >> >> Current -next has some new instances of EXPORT_SYMBOL_GPL_FOR_MODULES() >> in drivers/tty/serial/8250/8250_rsa.c by commit b20d6576cdb3 ("serial: >> 8250: export RSA functions"). Hopefully it's resolvable by a merge >> commit fixup and we don't need to provide a temporary alias. >> >> [1] https://lore.kernel.org/all/20250623-warmwasser-giftig-ff656fce89ad@brauner/ >> [2] https://lore.kernel.org/all/aFleJN_fE-RbSoFD@infradead.org/ >> [3] https://lore.kernel.org/all/20250623142836.GT1613200@noisy.programming.kicks-ass.net/ >> >> Signed-off-by: Vlastimil Babka >> --- > > Love this. It'd be great to get this in as a bugfix, > Acked-by: Christian Brauner Yes, looks like the right thing to do Acked-by: David Hildenbrand -- Cheers, David / dhildenb