From: Reinette Chatre <reinette.chatre@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
<fenghua.yu@intel.com>, <tglx@linutronix.de>, <mingo@redhat.com>,
<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
<paulmck@kernel.org>, <rdunlap@infradead.org>, <tj@kernel.org>,
<peterz@infradead.org>, <yanjiewtw@gmail.com>,
<kim.phillips@amd.com>, <lukas.bulwahn@gmail.com>,
<seanjc@google.com>, <jmattson@google.com>, <leitao@debian.org>,
<jpoimboe@kernel.org>, <rick.p.edgecombe@intel.com>,
<kirill.shutemov@linux.intel.com>, <jithu.joseph@intel.com>,
<kai.huang@intel.com>, <kan.liang@linux.intel.com>,
<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
<sandipan.das@amd.com>, <ilpo.jarvinen@linux.intel.com>,
<peternewman@google.com>, <maciej.wieczor-retman@intel.com>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<eranian@google.com>
Subject: Re: [PATCH] x86/resctrl: Fix unneeded variable warning reported by kernel test robot
Date: Wed, 24 Jan 2024 13:31:01 -0800 [thread overview]
Message-ID: <7d6e3d39-ce53-40e4-bba5-242911a1522a@intel.com> (raw)
In-Reply-To: <20240124204525.GIZbF25bekUME2flt0@fat_crate.local>
Hi Boris,
On 1/24/2024 12:45 PM, Borislav Petkov wrote:
> Hi,
>
> On Wed, Jan 24, 2024 at 12:04:31PM -0800, Reinette Chatre wrote:
>>> 54e35eb8611c ("x86/resctrl: Read supported bandwidth sources from CPUID").
>>
>> I think a "commit" prefix is required here and below.
>
> Yeah, but if you see a 12-char sha1 followed by a title in (" "), that
> is a commit and nothing else, right?
>
> If I say "commit" too it is kinda redundant.
I do not know the motivation for that requirement. From what I can tell the
change [1] that added that check went in as first version without discussion.
[1] starts by saying that the format is "preferred" so I assume there is
some history that I am not familiar with.
Reinette
[1] https://lore.kernel.org/all/976c6cdd680db4b55ae31b5fc2d1779da5c0dc66.camel@perches.com/
next prev parent reply other threads:[~2024-01-24 21:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202401241810.jbd8Ipa1-lkp@intel.com>
2024-01-24 17:52 ` [PATCH] x86/resctrl: Fix unneeded variable warning reported by kernel test robot Babu Moger
2024-01-24 18:25 ` Reinette Chatre
2024-01-24 18:31 ` Borislav Petkov
2024-01-24 18:51 ` Reinette Chatre
2024-01-24 19:14 ` Borislav Petkov
2024-01-24 19:39 ` Moger, Babu
2024-01-24 20:48 ` Borislav Petkov
2024-01-24 20:04 ` Reinette Chatre
2024-01-24 20:45 ` Borislav Petkov
2024-01-24 21:31 ` Reinette Chatre [this message]
2024-01-24 22:46 ` Borislav Petkov
2024-01-24 23:03 ` Reinette Chatre
2024-01-24 23:34 ` Borislav Petkov
2024-01-24 23:41 ` Borislav Petkov
2024-01-25 0:12 ` Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d6e3d39-ce53-40e4-bba5-242911a1522a@intel.com \
--to=reinette.chatre@intel.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jithu.joseph@intel.com \
--cc=jmattson@google.com \
--cc=jpoimboe@kernel.org \
--cc=kai.huang@intel.com \
--cc=kan.liang@linux.intel.com \
--cc=kim.phillips@amd.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=leitao@debian.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=maciej.wieczor-retman@intel.com \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peternewman@google.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=sandipan.das@amd.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=x86@kernel.org \
--cc=yanjiewtw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox