From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DF81839F3 for ; Wed, 12 Jun 2024 19:40:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718221229; cv=none; b=pCuwV+/vFaOLd2lDf1ULYwv353gFzTYPko9afWKmJymCKoyV7jGNFftCEQFL8NnxwInaUr/0wPFzZgEYIpqgdPXKhHylCJw0q50GUqcEKKhTV221P9SIdYkVEJWoQGA8KhVdlSoaXXRVo9RP0NFKB/lHJD5LtEzkqpPtEuSasZo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718221229; c=relaxed/simple; bh=cSKMFEYXfnxs8boSeddh2ftPnZABvpUWL3r1pVUsXaI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tNRAhriwvmn6lMTv5adL2UxZ166oF0a/q+TRR2r3kj22uu2HBEfpB6TSX6puh+sq8XG42cqeKPsm1UMHey9Kn17f6kT84JUARh7zBu2kTenSo+Wn1nQQhpk/Hrd/han3Zpu9l9PM/5juZdzKBDAJV0mFWbCb0nISnyN6BtvPxWo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=BhSR0zJc; arc=none smtp.client-ip=209.85.167.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="BhSR0zJc" Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3d226c5a157so82346b6e.2 for ; Wed, 12 Jun 2024 12:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1718221226; x=1718826026; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=w5LNtnpb+cPV0IybYX1l2BPxrq2qZxhs9ZuI7HpIWdM=; b=BhSR0zJc9Vy29nagRHebEf96qeTJ71fsNkJK5Whj8Q4sPt4L4CdQuXAByjLDSylTL2 Li3sgKMW3GTSUkh8vhNM6WwmcGllQXmNcjaCFwQDfBacok+pd1SEBhLzvngZ2/6MRbdz Pv3dsYGXzbK68fEjkzP+FY9uwgE4kGCqMrdZ7IeVNhWed7L+0+qOIWu/owem8mtARq++ UHSKosws61j8csR3tHvgmLcUbHUo95kTnrB3hVBv9EQleUY4KxNw9TexGyXOoHxyl2vf iu5o6kQyZyMYyBkoJAKGHFonxpY3bWxicO8DlUHdzRFak2dI8FfvZTeF2URlEPd/II0v wcgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718221226; x=1718826026; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=w5LNtnpb+cPV0IybYX1l2BPxrq2qZxhs9ZuI7HpIWdM=; b=YoGMZnKzIZtAQ9ywjpXzWP0zLwSHUS7npXbXO5NT+9PqsZBxJJJtIqPBIaEVMRUixW tnuZJ7qbdwkRtPNTpyvg3zHWE8h/b5isL8WQ8JGgj53n1/5milCUecL/m8DuXN9chvFq FACwb5+jKTN/RExOPNNAvBMJ2TKJH1IiavhfsbvKXntxCcO4x/kRoQEBLlTAjmePy4hX 8q4uAocckRoi9CT5ZPaxnvC4gBLgCVFE8Bu/H1MsVibbESjIXCn5CZFIaTSw2KgMqNHx TlHW8G8ekEVKIjIGDIDQpFI3auXSHGv3viHhFHKdyyy6n5MslHsQ/Gz17pv9E0Q02FVq e9oQ== X-Forwarded-Encrypted: i=1; AJvYcCUWW90VBH4+HF9uCK/G8I0Qr3sXxs/ZucynBNOSXJFqYxiD6eH7YL/OZZBMySbl8M5chznu5OX8VBv2adbjeGIXLkHy2+/71xzZ X-Gm-Message-State: AOJu0YyowwhOkX/j8WP8dKtYysPVrbrNx10o5KXhxN522oNN482q+6lt Vhbr4mDzraXF5cnlEVbk+ZaNy5X+ZDWLEtaRQ7LtP/upGuO7xEusgPjhUIdqvg0= X-Google-Smtp-Source: AGHT+IF6oKhV6A6Y8jPxsGC+iDd30Uo+tPSQ/KOgptYZ4SVvzSzhteTlGlt677GoxMbr0X9fXi+ZCg== X-Received: by 2002:a05:6808:1594:b0:3d1:fc50:1aae with SMTP id 5614622812f47-3d23dfdbe9dmr2927945b6e.7.1718221226425; Wed, 12 Jun 2024 12:40:26 -0700 (PDT) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3d21cac78d0sm1690192b6e.13.2024.06.12.12.40.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jun 2024 12:40:26 -0700 (PDT) Message-ID: <80093c72-d0c3-4d25-8830-392324744300@baylibre.com> Date: Wed, 12 Jun 2024 14:40:25 -0500 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] iio: adc: ad4695: Add driver for AD4695 and similar ADCs To: Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Michael Hennerich , =?UTF-8?Q?Nuno_S=C3=A1?= , Jonathan Corbet , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Ramona Gradinariu References: <20240612-iio-adc-ad4695-v1-0-6a4ed251fc86@baylibre.com> <20240612-iio-adc-ad4695-v1-2-6a4ed251fc86@baylibre.com> Content-Language: en-US From: David Lechner In-Reply-To: <20240612-iio-adc-ad4695-v1-2-6a4ed251fc86@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/12/24 2:20 PM, David Lechner wrote: > + ad4695_set_ref_voltage(st, st->vref_mv); > + if (ret) > + return ret; > + For some reason, no matter how many times I go over a patch, I always find something as soon as I hit send. This is missing ret =