From: Vladimir Kondratiev <vladimir.kondratiev@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
Luis Chamberlain <mcgrof@kernel.org>,
Kees Cook <keescook@chromium.org>,
Iurii Zaikin <yzaikin@google.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
"Guilherme G. Piccoli" <gpiccoli@canonical.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Kars Mulder <kerneldev@karsmulder.nl>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Arvind Sankar <nivedita@alum.mit.edu>,
Joe Perches <joe@perches.com>, Rafael Aquini <aquini@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Christian Brauner <christian.brauner@ubuntu.com>,
Alexei Starovoitov <ast@kernel.org>,
Davidlohr Bueso <dave@stgolabs.net>,
Michel Lespinasse <walken@google.com>,
Jann Horn <jannh@google.com>, chenqiwu <chenqiwu@xiaomi.com>,
Minchan Kim <minchan@kernel.org>,
Christophe Leroy <christophe.leroy@c-s.fr>,
Vladimir Kondratiev <vladimir.kondratiev@intel.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [RFC PATCH] do_exit(): panic() recursion detected
Date: Mon, 7 Dec 2020 14:55:18 +0200 [thread overview]
Message-ID: <8056f890-0297-6fa9-c9a6-c9909e0f24af@linux.intel.com> (raw)
In-Reply-To: <20201207125145.GM3040@hirez.programming.kicks-ass.net>
We do panic on oops as well. We panic on anything that may point to
system stability issues. I can't proof this code can't be reached
without oops, so I want to panic here as well.
On 12/7/20 2:51 PM, Peter Zijlstra wrote:
> On Mon, Dec 07, 2020 at 02:40:49PM +0200, Vladimir Kondratiev wrote:
>> From: Vladimir Kondratiev <vladimir.kondratiev@intel.com>
>>
>> Recursive do_exit() is symptom of compromised kernel integrity.
>> For safety critical systems, it may be better to
>> panic() in this case to minimize risk.
>
> You've not answered the previously posed question on why panic_on_oops
> isn't more suitable for your type of systems.
>
>> Signed-off-by: Vladimir Kondratiev <vladimir.kondratiev@intel.com>
>> Change-Id: I42f45900a08c4282c511b05e9e6061360d07db60
>
> This Change-ID crap doesn't belong in kernel patches.
>
next prev parent reply other threads:[~2020-12-07 12:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 12:40 [RFC PATCH] do_exit(): panic() recursion detected Vladimir Kondratiev
2020-12-07 12:51 ` Peter Zijlstra
2020-12-07 12:55 ` Vladimir Kondratiev [this message]
2020-12-07 14:27 ` [NEEDS-REVIEW] " Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8056f890-0297-6fa9-c9a6-c9909e0f24af@linux.intel.com \
--to=vladimir.kondratiev@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=aquini@redhat.com \
--cc=ast@kernel.org \
--cc=chenqiwu@xiaomi.com \
--cc=christian.brauner@ubuntu.com \
--cc=christophe.leroy@c-s.fr \
--cc=corbet@lwn.net \
--cc=dave@stgolabs.net \
--cc=ebiederm@xmission.com \
--cc=gpiccoli@canonical.com \
--cc=jannh@google.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kerneldev@karsmulder.nl \
--cc=kishon@ti.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mcgrof@kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=minchan@kernel.org \
--cc=nivedita@alum.mit.edu \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=vladimir.kondratiev@intel.com \
--cc=walken@google.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).