From: "Kiyanovski, Arthur" <akiyano@amazon.com>
To: Ahmed Zaki <ahmed.zaki@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"corbet@lwn.net" <corbet@lwn.net>,
"jesse.brandeburg@intel.com" <jesse.brandeburg@intel.com>,
"anthony.l.nguyen@intel.com" <anthony.l.nguyen@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"vladimir.oltean@nxp.com" <vladimir.oltean@nxp.com>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"horms@kernel.org" <horms@kernel.org>,
"mkubecek@suse.cz" <mkubecek@suse.cz>,
"willemdebruijn.kernel@gmail.com"
<willemdebruijn.kernel@gmail.com>,
"gal@nvidia.com" <gal@nvidia.com>,
"alexander.duyck@gmail.com" <alexander.duyck@gmail.com>,
"ecree.xilinx@gmail.com" <ecree.xilinx@gmail.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Jacob Keller <jacob.e.keller@intel.com>
Subject: RE: [PATCH net-next v8 1/8] net: ethtool: pass a pointer to parameters to get/set_rxfh ethtool ops
Date: Thu, 7 Dec 2023 07:02:28 +0000 [thread overview]
Message-ID: <82af13c02b5b4a3b9372ee5b38221b4b@amazon.com> (raw)
In-Reply-To: <20231206233642.447794-2-ahmed.zaki@intel.com>
> The get/set_rxfh ethtool ops currently takes the rxfh (RSS) parameters
> as direct function arguments. This will force us to change the API (and
> all drivers' functions) every time some new parameters are added.
>
> This is part 1/2 of the fix, as suggested in [1]:
>
> - First simplify the code by always providing a pointer to all params
> (indir, key and func); the fact that some of them may be NULL seems
> like a weird historic thing or a premature optimization.
> It will simplify the drivers if all pointers are always present.
>
> - Then make the functions take a dev pointer, and a pointer to a
> single struct wrapping all arguments. The set_* should also take
> an extack.
>
> Link: https://lore.kernel.org/netdev/20231121152906.2dd5f487@kernel.org/
> [1]
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Suggested-by: Jacob Keller <jacob.e.keller@intel.com>
> Signed-off-by: Ahmed Zaki <ahmed.zaki@intel.com>
> ---
Thanks for submitting this.
For the ENA driver:
Acked-by: Arthur Kiyanovski <akiyano@amazon.com>
next prev parent reply other threads:[~2023-12-07 7:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 23:36 [PATCH net-next v8 0/8] Support symmetric-xor RSS hash Ahmed Zaki
2023-12-06 23:36 ` [PATCH net-next v8 1/8] net: ethtool: pass a pointer to parameters to get/set_rxfh ethtool ops Ahmed Zaki
2023-12-07 7:02 ` Kiyanovski, Arthur [this message]
2023-12-09 1:57 ` Jakub Kicinski
2023-12-06 23:36 ` [PATCH net-next v8 2/8] net: ethtool: get rid of get/set_rxfh_context functions Ahmed Zaki
2023-12-06 23:36 ` [PATCH net-next v8 3/8] net: ethtool: add support for symmetric-xor RSS hash Ahmed Zaki
2023-12-06 23:36 ` [PATCH net-next v8 4/8] ice: fix ICE_AQ_VSI_Q_OPT_RSS_* register values Ahmed Zaki
2023-12-06 23:36 ` [PATCH net-next v8 5/8] ice: refactor RSS configuration Ahmed Zaki
2023-12-06 23:36 ` [PATCH net-next v8 6/8] ice: refactor the FD and RSS flow ID generation Ahmed Zaki
2023-12-06 23:36 ` [PATCH net-next v8 7/8] ice: enable symmetric-xor RSS for Toeplitz hash function Ahmed Zaki
2023-12-06 23:36 ` [PATCH net-next v8 8/8] iavf: " Ahmed Zaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82af13c02b5b4a3b9372ee5b38221b4b@amazon.com \
--to=akiyano@amazon.com \
--cc=ahmed.zaki@intel.com \
--cc=alexander.duyck@gmail.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).