linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Begunkov <asml.silence@gmail.com>
To: Mina Almasry <almasrymina@google.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org,
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
	sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org, bpf@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Cc: "David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Donald Hunter" <donald.hunter@gmail.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Ivan Kokshaysky" <ink@jurassic.park.msu.ru>,
	"Matt Turner" <mattst88@gmail.com>,
	"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Helge Deller" <deller@gmx.de>,
	"Andreas Larsson" <andreas@gaisler.com>,
	"Jesper Dangaard Brouer" <hawk@kernel.org>,
	"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Masami Hiramatsu" <mhiramat@kernel.org>,
	"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Martin KaFai Lau" <martin.lau@linux.dev>,
	"Eduard Zingerman" <eddyz87@gmail.com>,
	"Song Liu" <song@kernel.org>,
	"Yonghong Song" <yonghong.song@linux.dev>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"KP Singh" <kpsingh@kernel.org>,
	"Stanislav Fomichev" <sdf@fomichev.me>,
	"Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>,
	"Steffen Klassert" <steffen.klassert@secunet.com>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"David Ahern" <dsahern@kernel.org>,
	"Willem de Bruijn" <willemdebruijn.kernel@gmail.com>,
	"Shuah Khan" <shuah@kernel.org>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Christian König" <christian.koenig@amd.com>,
	"Bagas Sanjaya" <bagasdotme@gmail.com>,
	"Christoph Hellwig" <hch@infradead.org>,
	"Nikolay Aleksandrov" <razor@blackwall.org>,
	"David Wei" <dw@davidwei.uk>, "Jason Gunthorpe" <jgg@ziepe.ca>,
	"Yunsheng Lin" <linyunsheng@huawei.com>,
	"Shailend Chand" <shailend@google.com>,
	"Harshitha Ramamurthy" <hramamurthy@google.com>,
	"Shakeel Butt" <shakeel.butt@linux.dev>,
	"Jeroen de Borst" <jeroendb@google.com>,
	"Praveen Kaligineedi" <pkaligineedi@google.com>,
	"Willem de Bruijn" <willemb@google.com>,
	"Kaiyuan Zhang" <kaiyuanz@google.com>
Subject: Re: [PATCH net-next v15 10/14] tcp: RX path for devmem TCP
Date: Tue, 2 Jul 2024 15:51:27 +0100	[thread overview]
Message-ID: <8335651b-3296-460a-b9a6-4a36a7ec8bc8@gmail.com> (raw)
In-Reply-To: <20240628003253.1694510-11-almasrymina@google.com>

On 6/28/24 01:32, Mina Almasry wrote:
> In tcp_recvmsg_locked(), detect if the skb being received by the user
> is a devmem skb. In this case - if the user provided the MSG_SOCK_DEVMEM
> flag - pass it to tcp_recvmsg_devmem() for custom handling.
> 
> tcp_recvmsg_devmem() copies any data in the skb header to the linear
> buffer, and returns a cmsg to the user indicating the number of bytes
> returned in the linear buffer.
> 
> tcp_recvmsg_devmem() then loops over the unaccessible devmem skb frags,
> and returns to the user a cmsg_devmem indicating the location of the
> data in the dmabuf device memory. cmsg_devmem contains this information:
> 
> 1. the offset into the dmabuf where the payload starts. 'frag_offset'.
> 2. the size of the frag. 'frag_size'.
> 3. an opaque token 'frag_token' to return to the kernel when the buffer
> is to be released.
> 
> The pages awaiting freeing are stored in the newly added
> sk->sk_user_frags, and each page passed to userspace is get_page()'d.
> This reference is dropped once the userspace indicates that it is
> done reading this page.  All pages are released when the socket is
> destroyed.

Already gave it in v13, but it got lost

Reviewed-by: Pavel Begunkov <asml.silence@gmail.com>

-- 
Pavel Begunkov

  parent reply	other threads:[~2024-07-02 14:51 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-28  0:32 [PATCH net-next v15 00/14] Device Memory TCP Mina Almasry
2024-06-28  0:32 ` [PATCH net-next v15 01/14] netdev: add netdev_rx_queue_restart() Mina Almasry
2024-07-03  0:01   ` Jakub Kicinski
2024-06-28  0:32 ` [PATCH net-next v15 02/14] net: netdev netlink api to bind dma-buf to a net device Mina Almasry
2024-06-28 10:04   ` Donald Hunter
2024-07-01 19:04     ` Mina Almasry
2024-07-02  9:33       ` Donald Hunter
2024-07-03  0:19   ` Jakub Kicinski
2024-06-28  0:32 ` [PATCH net-next v15 03/14] netdev: support binding dma-buf to netdevice Mina Almasry
2024-07-02 11:08   ` Paolo Abeni
2024-07-02 14:17     ` Paolo Abeni
2024-07-03  1:09   ` Jakub Kicinski
2024-07-03 16:56     ` Mina Almasry
2024-07-03 18:31       ` Jakub Kicinski
2024-07-04 15:30   ` Taehee Yoo
2024-07-04 17:56   ` Taehee Yoo
2024-07-08 20:08     ` Mina Almasry
2024-07-09 15:37       ` Taehee Yoo
2024-07-09 17:44         ` Mina Almasry
2024-07-23 21:49         ` Mina Almasry
2024-07-24 14:11           ` Taehee Yoo
2024-06-28  0:32 ` [PATCH net-next v15 04/14] netdev: netdevice devmem allocator Mina Almasry
2024-06-28  0:32 ` [PATCH net-next v15 05/14] page_pool: convert to use netmem Mina Almasry
2024-06-28  0:32 ` [PATCH net-next v15 06/14] page_pool: devmem support Mina Almasry
2024-06-28  0:32 ` [PATCH net-next v15 07/14] memory-provider: dmabuf devmem memory provider Mina Almasry
2024-06-28  0:32 ` [PATCH net-next v15 08/14] net: support non paged skb frags Mina Almasry
2024-07-02 13:14   ` Eric Dumazet
2024-06-28  0:32 ` [PATCH net-next v15 09/14] net: add support for skbs with unreadable frags Mina Almasry
2024-07-02 14:06   ` Eric Dumazet
2024-06-28  0:32 ` [PATCH net-next v15 10/14] tcp: RX path for devmem TCP Mina Almasry
2024-07-02 14:16   ` Eric Dumazet
2024-07-02 14:51   ` Pavel Begunkov [this message]
2024-07-02 15:25   ` Arnd Bergmann
2024-07-02 18:14     ` Mina Almasry
2024-06-28  0:32 ` [PATCH net-next v15 11/14] net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags Mina Almasry
2024-07-02 14:30   ` Eric Dumazet
2024-07-02 14:56   ` Pavel Begunkov
2024-07-02 15:01   ` David Ahern
2024-06-28  0:32 ` [PATCH net-next v15 12/14] net: add devmem TCP documentation Mina Almasry
2024-06-28 10:09   ` Donald Hunter
2024-07-01 19:00     ` Mina Almasry
2024-06-28  0:32 ` [PATCH net-next v15 13/14] tools: net: package libynl for use in selftests Mina Almasry
2024-06-28  0:32 ` [PATCH net-next v15 14/14] selftests: add ncdevmem, netcat for devmem TCP Mina Almasry
2024-07-04  7:59   ` Taehee Yoo
2024-06-28  6:45 ` [PATCH net-next v15 00/14] Device Memory TCP Mina Almasry
2024-07-03  2:02 ` Jakub Kicinski
2024-07-03  4:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8335651b-3296-460a-b9a6-4a36a7ec8bc8@gmail.com \
    --to=asml.silence@gmail.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=almasrymina@google.com \
    --cc=andreas@gaisler.com \
    --cc=andrii@kernel.org \
    --cc=arnd@arndb.de \
    --cc=ast@kernel.org \
    --cc=bagasdotme@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=christian.koenig@amd.com \
    --cc=corbet@lwn.net \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=deller@gmx.de \
    --cc=donald.hunter@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=dsahern@kernel.org \
    --cc=dw@davidwei.uk \
    --cc=eddyz87@gmail.com \
    --cc=edumazet@google.com \
    --cc=haoluo@google.com \
    --cc=hawk@kernel.org \
    --cc=hch@infradead.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=hramamurthy@google.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=ink@jurassic.park.msu.ru \
    --cc=jeroendb@google.com \
    --cc=jgg@ziepe.ca \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kaiyuanz@google.com \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=linyunsheng@huawei.com \
    --cc=martin.lau@linux.dev \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mattst88@gmail.com \
    --cc=mhiramat@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pkaligineedi@google.com \
    --cc=razor@blackwall.org \
    --cc=richard.henderson@linaro.org \
    --cc=rostedt@goodmis.org \
    --cc=sdf@fomichev.me \
    --cc=shailend@google.com \
    --cc=shakeel.butt@linux.dev \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    --cc=sumit.semwal@linaro.org \
    --cc=tsbogend@alpha.franken.de \
    --cc=willemb@google.com \
    --cc=willemdebruijn.kernel@gmail.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).