From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6448304BDF; Fri, 12 Sep 2025 11:59:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757678367; cv=none; b=pGZMmJKGckQq/dcN5/LZ8R/mluvxVMrcv9CTf4srIlTnobj3L96/1C8aq8/J7eOIciu2mfMSVVFBS7kalgfTE6ylb6UtLYY7bzBrRrX2+plvKYGor9rPHoXezZwR0DiztPrd0AjRQffnUQ+MNxMRSPNVT1BNMq/9GahHi/zUkzU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757678367; c=relaxed/simple; bh=rafxCepOCZ5zRqpy5guYXvoh8TTmg6RiVJoppBGDmgg=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=hGjYlGrjSouqdT92sClv3j40SwkIpzlaRC/mF/wp8wY0O+0IwFfkAG0yOagTSaeKiQBpZqcTkXy7+CwfyfIrkZYRF7rK7FJbJsDEvZjVZC3aNhKja60ujdh+IsVc2QFt6875ui59yai8Kg80hxGtzn86UDBtjlHwRZ3aeiZcY50= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p6MfElXw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p6MfElXw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E12AC4CEF1; Fri, 12 Sep 2025 11:59:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757678366; bh=rafxCepOCZ5zRqpy5guYXvoh8TTmg6RiVJoppBGDmgg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=p6MfElXwv3soLj836yOMic8Qm4pScIY6Z764kA0g7yUwIAVYi7zfIhwwN39NO0PD3 iPq0m1p4Q882DdEtciaGmqhTwhf7BdlkOapNpd49SPnFzLF7P53hDn9UkbCGOLbtgT TFceD6fchmevTwkbUAHhrKj+eUS4NizUzUezyYhftzmG3hEcYQDVviy9VYFAnqed4c qvTOTPUWiEZBiZ336QDOkHXaOPSfKExxi40kKR5J7UZ/+aI0ZvQJUVpeZtoqrnluam eYl4LBm/JUru8p+mhhGVkSEBdCm8K4amhnezsIts2yo9WJCdYck/yNMvxCPCVAp2ow VbQPIb7HS0pTw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1ux2R2-00000005fus-0tdP; Fri, 12 Sep 2025 11:59:24 +0000 Date: Fri, 12 Sep 2025 12:59:23 +0100 Message-ID: <865xdndgpw.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: Catalin Marinas , Will Deacon , Oliver Upton , Joey Gouly , Suzuki K Poulose , Shuah Khan , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v16 2/6] KVM: arm64: Manage GCS access and registers for guests In-Reply-To: <20250912-arm64-gcs-v16-2-6435e5ec37db@kernel.org> References: <20250912-arm64-gcs-v16-0-6435e5ec37db@kernel.org> <20250912-arm64-gcs-v16-2-6435e5ec37db@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: broonie@kernel.org, catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, shuah@kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 12 Sep 2025 10:25:28 +0100, Mark Brown wrote: > > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c > index 82ffb3b3b3cf..03fb2dce0b80 100644 > --- a/arch/arm64/kvm/sys_regs.c > +++ b/arch/arm64/kvm/sys_regs.c > @@ -138,6 +138,8 @@ static bool get_el2_to_el1_mapping(unsigned int reg, > MAPPED_EL2_SYSREG(PIR_EL2, PIR_EL1, NULL ); > MAPPED_EL2_SYSREG(PIRE0_EL2, PIRE0_EL1, NULL ); > MAPPED_EL2_SYSREG(POR_EL2, POR_EL1, NULL ); > + MAPPED_EL2_SYSREG(GCSCR_EL2, GCSCR_EL1, NULL ); > + MAPPED_EL2_SYSREG(GCSPR_EL2, GCSPR_EL1, NULL ); > MAPPED_EL2_SYSREG(AMAIR_EL2, AMAIR_EL1, NULL ); > MAPPED_EL2_SYSREG(ELR_EL2, ELR_EL1, NULL ); > MAPPED_EL2_SYSREG(SPSR_EL2, SPSR_EL1, NULL ); Just like the previous version, you're missing the accessors that would be this table useful. Meaning that the vcpu_read_sys_reg() and vcpu_write_sys_reg() accessors will fail for all 4 GSC registers. M. -- Without deviation from the norm, progress is not possible.