[PATCH v4 1/2] dt-bindings: hwmon: add STEF48H28

[PATCH v4 1/2] dt-bindings: hwmon: add STEF48H28

[Charles Hsu]

Add device tree bindings for the hot-swap controller STEF48H28.

Signed-off-by: Charles Hsu <hsu.yungteng@gmail.com>
---
 .../bindings/hwmon/pmbus/st,stef48h28.yaml    | 43 +++++++++++++++++++
 1 file changed, 43 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/st,stef48h28.yaml

diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/st,stef48h28.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/st,stef48h28.yaml
new file mode 100644
index 000000000000..c6a4b02bcd84
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/pmbus/st,stef48h28.yaml
@@ -0,0 +1,43 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/pmbus/st,stef48h28.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: STMicroelectronics hot-swap controller with PMBus interface
+
+maintainers:
+  - Charles Hsu <hsu.yungteng@gmail.com>
+
+description: |
+  The STEF48H28 is an advanced 30A integrated electronic fuse for
+  the 9-80V DC power lines.
+
+  Datasheet:
+    https://www.st.com/resource/en/data_brief/stef48h28.pdf
+
+properties:
+  compatible:
+    enum:
+      - st,stef48h28
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        pmic@11 {
+            compatible = "st,stef48h28";
+            reg = <0x11>;
+        };
+    };
-- 
2.34.1

Re: [PATCH v4 1/2] dt-bindings: hwmon: add STEF48H28

[Krzysztof Kozlowski]

On 24/12/2025 09:48, Charles Hsu wrote:
> Add device tree bindings for the hot-swap controller STEF48H28.
> 
> Signed-off-by: Charles Hsu <hsu.yungteng@gmail.com>
> ---


Where is any changelog? You keep sending versions but you never
responded, never said what happened with this.

>  .../bindings/hwmon/pmbus/st,stef48h28.yaml    | 43 +++++++++++++++++++
>  1 file changed, 43 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/st,stef48h28.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/st,stef48h28.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/st,stef48h28.yaml
> new file mode 100644
> index 000000000000..c6a4b02bcd84
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/st,stef48h28.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/pmbus/st,stef48h28.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: STMicroelectronics hot-swap controller with PMBus interface
> +
> +maintainers:
> +  - Charles Hsu <hsu.yungteng@gmail.com>
> +
> +description: |
> +  The STEF48H28 is an advanced 30A integrated electronic fuse for
> +  the 9-80V DC power lines.
> +
> +  Datasheet:
> +    https://www.st.com/resource/en/data_brief/stef48h28.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - st,stef48h28
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        pmic@11 {

Your description says something else? Confusing.


> +            compatible = "st,stef48h28";
> +            reg = <0x11>;

You keep ignoring comments. Can you start responding to them?

NAK

> +        };
> +    };


Best regards,
Krzysztof

Re: [PATCH v4 1/2] dt-bindings: hwmon: add STEF48H28

[Yungteng Hsu]

Krzysztof Kozlowski <krzk@kernel.org> 於 2025年12月24日週三 下午6:03寫道：
>
> On 24/12/2025 09:48, Charles Hsu wrote:
> > Add device tree bindings for the hot-swap controller STEF48H28.
> >
> > Signed-off-by: Charles Hsu <hsu.yungteng@gmail.com>
> > ---
>
>
> Where is any changelog? You keep sending versions but you never
> responded, never said what happened with this.
>
Thank you for your feedback.
I realize now that I misunderstood the process.
I previously thought that the changes needed to be included in the cover letter.
I will follow the proper procedure for discussing updates in the thread.

> >  .../bindings/hwmon/pmbus/st,stef48h28.yaml    | 43 +++++++++++++++++++
> >  1 file changed, 43 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/st,stef48h28.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/st,stef48h28.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/st,stef48h28.yaml
> > new file mode 100644
> > index 000000000000..c6a4b02bcd84
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/st,stef48h28.yaml
> > @@ -0,0 +1,43 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/hwmon/pmbus/st,stef48h28.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: STMicroelectronics hot-swap controller with PMBus interface
> > +
> > +maintainers:
> > +  - Charles Hsu <hsu.yungteng@gmail.com>
> > +
> > +description: |
> > +  The STEF48H28 is an advanced 30A integrated electronic fuse for
> > +  the 9-80V DC power lines.
> > +
> > +  Datasheet:
> > +    https://www.st.com/resource/en/data_brief/stef48h28.pdf
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - st,stef48h28
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        pmic@11 {
>
> Your description says something else? Confusing.
Sorry for the confusion in the previous version, the datasheet link
was incorrect.
>
>
> > +            compatible = "st,stef48h28";
> > +            reg = <0x11>;
>
> You keep ignoring comments. Can you start responding to them?
I have updated the patch accordingly.
This device is not a regulator.
It is a power monitor, so regulator properties like supplies or
adjustable voltage are not applicable.
>
> NAK
>
> > +        };
> > +    };
>
>
> Best regards,
> Krzysztof

Re: [PATCH v4 1/2] dt-bindings: hwmon: add STEF48H28

[Krzysztof Kozlowski]

On 26/12/2025 03:46, Yungteng Hsu wrote:
> Krzysztof Kozlowski <krzk@kernel.org> 於 2025年12月24日週三 下午6:03寫道：
>>
>> On 24/12/2025 09:48, Charles Hsu wrote:
>>> Add device tree bindings for the hot-swap controller STEF48H28.
>>>
>>> Signed-off-by: Charles Hsu <hsu.yungteng@gmail.com>
>>> ---
>>
>>
>> Where is any changelog? You keep sending versions but you never
>> responded, never said what happened with this.
>>
> Thank you for your feedback.
> I realize now that I misunderstood the process.
> I previously thought that the changes needed to be included in the cover letter.
> I will follow the proper procedure for discussing updates in the thread.

There is no cover letter here at all. You sent only 1/2.

Best regards,
Krzysztof

Re: [PATCH v4 1/2] dt-bindings: hwmon: add STEF48H28

[Yungteng Hsu]

Krzysztof Kozlowski <krzk@kernel.org> 於 2025年12月26日週五 下午7:10寫道：


>
> On 26/12/2025 03:46, Yungteng Hsu wrote:
> > Krzysztof Kozlowski <krzk@kernel.org> 於 2025年12月24日週三 下午6:03寫道：
> >>
> >> On 24/12/2025 09:48, Charles Hsu wrote:
> >>> Add device tree bindings for the hot-swap controller STEF48H28.
> >>>
> >>> Signed-off-by: Charles Hsu <hsu.yungteng@gmail.com>
> >>> ---
> >>
> >>
> >> Where is any changelog? You keep sending versions but you never
> >> responded, never said what happened with this.
> >>
> > Thank you for your feedback.
> > I realize now that I misunderstood the process.
> > I previously thought that the changes needed to be included in the cover letter.
> > I will follow the proper procedure for discussing updates in the thread.
>
> There is no cover letter here at all. You sent only 1/2.
>
Thank you for the clarification.
I would like to confirm the correct approach.
Should the changes be documented in the cover letter, or should they
be written directly in the commit message?
I will resend the complete submission accordingly.
> Best regards,
> Krzysztof

Re: [PATCH v4 1/2] dt-bindings: hwmon: add STEF48H28

[Krzysztof Kozlowski]

On 29/12/2025 02:02, Yungteng Hsu wrote:
> Krzysztof Kozlowski <krzk@kernel.org> 於 2025年12月26日週五 下午7:10寫道：
> 
> 
>>
>> On 26/12/2025 03:46, Yungteng Hsu wrote:
>>> Krzysztof Kozlowski <krzk@kernel.org> 於 2025年12月24日週三 下午6:03寫道：
>>>>
>>>> On 24/12/2025 09:48, Charles Hsu wrote:
>>>>> Add device tree bindings for the hot-swap controller STEF48H28.
>>>>>
>>>>> Signed-off-by: Charles Hsu <hsu.yungteng@gmail.com>
>>>>> ---
>>>>
>>>>
>>>> Where is any changelog? You keep sending versions but you never
>>>> responded, never said what happened with this.
>>>>
>>> Thank you for your feedback.
>>> I realize now that I misunderstood the process.
>>> I previously thought that the changes needed to be included in the cover letter.
>>> I will follow the proper procedure for discussing updates in the thread.
>>
>> There is no cover letter here at all. You sent only 1/2.
>>
> Thank you for the clarification.
> I would like to confirm the correct approach.
> Should the changes be documented in the cover letter, or should they
> be written directly in the commit message?
> I will resend the complete submission accordingly.

Does not matter, because the problem is  - there is no cover letter. You
wrote that changelog is in the cover letter. There is no such!

Best regards,
Krzysztof