From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A899767C7D; Fri, 23 Feb 2024 11:33:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708688012; cv=none; b=lzrJ8swXyqhKy6wPOiv9gaApXUZ5m3TZ5xIu1ixj1Odwdt0A0a7Lwzdv92K9+3Pi5GlcAdx0Eo920lLNZPSDKc4U8K37koQQz8PX1sNUDmejVILAywVHSh/Y98Yzjf8CBoWBkNXcE/LC+vEQu/goK48IP7tpP0Ngtk/BpyHZQCQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708688012; c=relaxed/simple; bh=DeskMZXMo1BHkhunM8FKpUi8Q19ZTNc3ArIJp1xOFd8=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=cWfTb7hRydyzNxAq6RR1G/Zv6bZFDwE5He8VDf3ktcXhzOexa/P1l+qic9hZiXnfkVOXWhBvYjUyddiY7zWbC/32dxGMVYiZwl0DRQhoGd7AQ0SFMev92rP7ZDoBaHoptWkLFt1n08WAca7b7NevsEHUe2PpiiHu6V9xC1+Kops= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aufE4WBh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aufE4WBh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9678C433C7; Fri, 23 Feb 2024 11:33:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708688011; bh=DeskMZXMo1BHkhunM8FKpUi8Q19ZTNc3ArIJp1xOFd8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aufE4WBhKJvZ/R/CqHJp8Yck6eEk24phlJikoE5txPu0aTVmViLyy+usvfOs2zhxh B8ywTiS2xEjOjrAZf7CNyv3zoNcZ6DEK9tt1G1LyfLk0aUfepGn6ixGawQlWmOqiv6 ILaCZzG2bnSUON/j5XVr57XLOsQGgJNQ3Rrz55YqynaG0Za/GgTynbG1/m+H0OlcP1 dYQ22KKpmAux4Tvf+L+kbn8kvPlUfszEUcK+9IU+aftiitwa4K3PykCBUWtb8STZas d27N7aLIudxbVurXRvjh8GT7BsyCOFc60MoQuitWZPYzplWsEcgFrLxqzf35X5kvxP vldNXgxjkZHcA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rdTo1-0064Ef-VC; Fri, 23 Feb 2024 11:33:30 +0000 Date: Fri, 23 Feb 2024 11:33:29 +0000 Message-ID: <86o7c72z5i.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: Catalin Marinas , Will Deacon , Oliver Upton , James Morse , Suzuki K Poulose , Jonathan Corbet , Shuah Khan , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Martin , kvmarm@lists.linux.dev, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 11/14] KVM: arm64: Add newly allocated ID registers to register descriptions In-Reply-To: <20240122-arm64-2023-dpisa-v4-11-776e094861df@kernel.org> References: <20240122-arm64-2023-dpisa-v4-0-776e094861df@kernel.org> <20240122-arm64-2023-dpisa-v4-11-776e094861df@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: broonie@kernel.org, catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, corbet@lwn.net, shuah@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dave.martin@arm.com, kvmarm@lists.linux.dev, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 22 Jan 2024 16:28:14 +0000, Mark Brown wrote: > > The 2023 architecture extensions have allocated some new ID registers, add > them to the KVM system register descriptions so that they are visible to > guests. > > Signed-off-by: Mark Brown > --- > arch/arm64/kvm/sys_regs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c > index 30253bd19917..38503b1cd2eb 100644 > --- a/arch/arm64/kvm/sys_regs.c > +++ b/arch/arm64/kvm/sys_regs.c > @@ -2292,12 +2292,12 @@ static const struct sys_reg_desc sys_reg_descs[] = { > ID_AA64PFR0_EL1_AdvSIMD | > ID_AA64PFR0_EL1_FP), }, > ID_SANITISED(ID_AA64PFR1_EL1), > - ID_UNALLOCATED(4,2), > + ID_SANITISED(ID_AA64PFR2_EL1), So you now expose all sort of MTE things to the guest? > ID_UNALLOCATED(4,3), > ID_WRITABLE(ID_AA64ZFR0_EL1, ~ID_AA64ZFR0_EL1_RES0), > ID_HIDDEN(ID_AA64SMFR0_EL1), > ID_UNALLOCATED(4,6), > - ID_UNALLOCATED(4,7), > + ID_SANITISED(ID_AA64FPFR0_EL1), > > /* CRm=5 */ > { SYS_DESC(SYS_ID_AA64DFR0_EL1), > @@ -2324,7 +2324,7 @@ static const struct sys_reg_desc sys_reg_descs[] = { > ID_WRITABLE(ID_AA64ISAR2_EL1, ~(ID_AA64ISAR2_EL1_RES0 | > ID_AA64ISAR2_EL1_APA3 | > ID_AA64ISAR2_EL1_GPA3)), > - ID_UNALLOCATED(6,3), > + ID_WRITABLE(ID_AA64ISAR3_EL1, ~ID_AA64ISAR3_EL1_RES0), How about the non dpISA stuff that is advertised in the same register, and for which no support exists? > ID_UNALLOCATED(6,4), > ID_UNALLOCATED(6,5), > ID_UNALLOCATED(6,6), > M. -- Without deviation from the norm, progress is not possible.