From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D13C1B85DF; Thu, 24 Oct 2024 09:39:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729762788; cv=none; b=LewCy8mHVDsp4Ec50gAtwxJLdK0m0ie3KuIKu3GofvcTRrH7lGZMwkkNI17th1ArFdI4azN+/fAxdlFQqAH4EUji9E0HD+cvUjwPajMELVcSpunT2KVDCcTvHc8hQp9DMEb0T6S0POnv/Ie0B8+rBYZPV70ny9EKa3Db03TkUI8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729762788; c=relaxed/simple; bh=FW20GfbGsGiLyvJNvG1nJse9qdrvhRn6b52CFWefg4Q=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=IT+vav0GhaR2MsEM4aA2wITnRbyBxNynZEFLhp7+IKQEFxcFX4oqlwKN0vpBxtcLGDKEtV0RltvKKa8cYuEO73ETjQg2hrMbwrWPjHtv3keYUAJTowiT2YC6y9dyLu2kA25kJYPNRUYdSHO/jyQ2m22om9sihGi0Fdz9NWnjvg4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kC8PGQTk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kC8PGQTk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9009C4CEC7; Thu, 24 Oct 2024 09:39:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729762787; bh=FW20GfbGsGiLyvJNvG1nJse9qdrvhRn6b52CFWefg4Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kC8PGQTkt5IOuz/Pu3XYtPeXa+PM7kkAL/22B5yDSVWVauNm9rXgn7qA50FIErOmc lqDrGI2vR/0hP+y5gHeP3ikcaLho8fae9pyP/+Ehf02JVNCnJolD9wv8K8ojWPe0Jc ITtsOS4YQpNygjD4uH8HdRG5b5rESWBJajMARIAAhSk2U20tGZHRWFw/nLUdguxan2 UENGLYBvQRYxF0c6iCf7QDEWHWVXXPjy2mfJ7IrQ36goA+u6G/80OIFpeJ8LQplTcw XXLdgWEn7Yk6Voj4VvLtNsSX1HMY/o2LBJ6z0jg9TghP/f1PQwSE6JqC4cahMzQRyR 0tdocDku5BadA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1t3uJl-006OWJ-Kg; Thu, 24 Oct 2024 10:39:45 +0100 Date: Thu, 24 Oct 2024 10:39:45 +0100 Message-ID: <86v7xh3km6.wl-maz@kernel.org> From: Marc Zyngier To: Mostafa Saleh Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, corbet@lwn.net, Will Deacon Subject: Re: [PATCH] Documentation: Update the behaviour of "kvm-arm.mode" In-Reply-To: <20241023171244.4031151-1-smostafa@google.com> References: <20241023171244.4031151-1-smostafa@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: smostafa@google.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, corbet@lwn.net, will@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Hi Mostafa, On Wed, 23 Oct 2024 18:12:43 +0100, Mostafa Saleh wrote: > > Commit 5053c3f0519c ("KVM: arm64: Use hVHE in pKVM by default on CPUs with > VHE support") modified the behaviour of "kvm-arm.mode=protected" without > the updating the kernel parameters doc. > > Update it to match the current implementation. > > Cc: Will Deacon > Cc: Marc Zyngier > > Signed-off-by: Mostafa Saleh > --- > Documentation/admin-guide/kernel-parameters.txt | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index bb48ae24ae69..59a0dd7e2de6 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -2723,8 +2723,12 @@ > nvhe: Standard nVHE-based mode, without support for > protected guests. > > - protected: nVHE-based mode with support for guests whose > + protected: hVHE-based mode with support for guests whose > state is kept private from the host. > + In case hVHE is not supported in hardware, it will nit: it is VHE that is supported or not, hVHE is only a SW concept. > + boot with protected nVHE. > + nVHE protected mode can still be forced on VHE systems > + using "kvm_arm.mode=protected arm64_sw.hvhe=0 id_aa64mmfr1.vh=0" This opens another question: none of the arm_sw.*, nor any of the id_aa64* parameters are described (basically, anything that's in arch/arm64/kernel/pi/id_override.c). What should we do about these? > > nested: VHE-based mode with support for nested > virtualization. Requires at least ARMv8.3 Huh, another nit to fix. We only support nested with ARMv8.4 (with FEAT_NV2), as the ARMv8.3 version (the original FEAT_NV) is too ugly for words. Mind addressing this? Thanks! M. -- Without deviation from the norm, progress is not possible.