[PATCH v2 1/2] docs: move Linux logo into a new `images` folder

[PATCH v2 1/2] docs: move Linux logo into a new `images` folder

[Miguel Ojeda]

Having assets in the top-level `Documentation` directory can make
it harder to find the documents one needs, especially if we want
to add more of them later on.

Instead, create a new `images` folder inside it that is used
to hold assets such as logos.

In addition, update the reference in `scripts/spdxcheck-test.sh`.

Link: https://lore.kernel.org/lkml/8735hicoy7.fsf@meer.lwn.net/
Suggested-by: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
---
v1: https://lore.kernel.org/lkml/20220510172530.29704-1-ojeda@kernel.org/
v2:
  - Added the `scripts/spdxcheck-test.sh` reference update, as noticed
    by Jonathan Corbet.

 Documentation/{ => images}/COPYING-logo |   0
 Documentation/{ => images}/logo.gif     | Bin
 scripts/spdxcheck-test.sh               |   2 +-
 3 files changed, 1 insertion(+), 1 deletion(-)
 rename Documentation/{ => images}/COPYING-logo (100%)
 rename Documentation/{ => images}/logo.gif (100%)

diff --git a/Documentation/COPYING-logo b/Documentation/images/COPYING-logo
similarity index 100%
rename from Documentation/COPYING-logo
rename to Documentation/images/COPYING-logo
diff --git a/Documentation/logo.gif b/Documentation/images/logo.gif
similarity index 100%
rename from Documentation/logo.gif
rename to Documentation/images/logo.gif
diff --git a/scripts/spdxcheck-test.sh b/scripts/spdxcheck-test.sh
index cb76324756bd..9f6d1a74da6e 100644
--- a/scripts/spdxcheck-test.sh
+++ b/scripts/spdxcheck-test.sh
@@ -1,7 +1,7 @@
 #!/bin/sh
 
 # run check on a text and a binary file
-for FILE in Makefile Documentation/logo.gif; do
+for FILE in Makefile Documentation/images/logo.gif; do
 	python3 scripts/spdxcheck.py $FILE
 	python3 scripts/spdxcheck.py - < $FILE
 done

base-commit: 4b0986a3613c92f4ec1bdc7f60ec66fea135991f
-- 
2.36.1

Re: [PATCH v2 1/2] docs: move Linux logo into a new `images` folder

[Bagas Sanjaya]

On 5/28/22 22:31, Miguel Ojeda wrote:
> Having assets in the top-level `Documentation` directory can make
> it harder to find the documents one needs, especially if we want
> to add more of them later on.
> 
> Instead, create a new `images` folder inside it that is used
> to hold assets such as logos.
> 

Do assets include CSS and JS files?

And if we plan to add non-image assets to images/, that directory will
be misleading. I suggest to name the directory as assets/.

-- 
An old man doll... just what I always wanted! - Clara

Re: [PATCH v2 1/2] docs: move Linux logo into a new `images` folder

[Jonathan Corbet]

Bagas Sanjaya <bagasdotme@gmail.com> writes:

> On 5/28/22 22:31, Miguel Ojeda wrote:
>> Having assets in the top-level `Documentation` directory can make
>> it harder to find the documents one needs, especially if we want
>> to add more of them later on.
>> 
>> Instead, create a new `images` folder inside it that is used
>> to hold assets such as logos.
>> 
>
> Do assets include CSS and JS files?
>
> And if we plan to add non-image assets to images/, that directory will
> be misleading. I suggest to name the directory as assets/.

Can you please point out any CSS or JavaScript files in the kernel tree,
or any that we might expect to have there anytime soon?  I don't think
this is a case we need to be worried about.

Thanks,

jon

Re: [PATCH v2 1/2] docs: move Linux logo into a new `images` folder

[Jonathan Corbet]

Miguel Ojeda <ojeda@kernel.org> writes:

> Having assets in the top-level `Documentation` directory can make
> it harder to find the documents one needs, especially if we want
> to add more of them later on.
>
> Instead, create a new `images` folder inside it that is used
> to hold assets such as logos.

Both patches applied, thanks.

jon

Re: [PATCH v2 2/2] docs: add SVG version of the Linux logo

[Geert Uytterhoeven]

Hi Miguel,

On Sat, May 28, 2022 at 10:15 PM Miguel Ojeda <ojeda@kernel.org> wrote:
> In the Rust for Linux patch series, Jonathan Corbet requested [1] that
> we avoid binary assets (such as the logo), possibly by recreating
> them in SVG format.
>
> However, it turns out there is no SVG version of the Linux logo
> in the kernel tree yet, only a GIF one from the pre-v2.0.0 days.
>
> This patch fixes that by adding a SVG version of the Linux logo,
> which we could then use in the Rust for Linux documentation and
> other similar places.

Perhaps you want to add a Rust logo to drivers/video/logo/, to be
shown using fb_append_extra_logo() when Rust technology is included?

;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds