From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0AEDC4338F for ; Wed, 11 Aug 2021 09:17:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8046A6056C for ; Wed, 11 Aug 2021 09:17:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236311AbhHKJRo (ORCPT ); Wed, 11 Aug 2021 05:17:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27789 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234878AbhHKJRo (ORCPT ); Wed, 11 Aug 2021 05:17:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628673440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+rZhRdoNsieIXYY/pA3jAteEJJ6dMMA1Zrb29vrmk38=; b=UlZjF7jo2BEliJbRqEDZtvXZX3YHqEkzI5abPu2vo3ffdNvi4UxquwP9ujIiDM3E2kD7VA dHJ+jK1/qvxPWKRVYo/IY4M8sNwqy/OVT3lmb782COGNP+qmaYoZ22MVZudbE0UsrKGHpl t8W59BBDIyYWT2NMjp525sQezQcgfsY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-521-MtjubO-eMWOOB7mz4njilQ-1; Wed, 11 Aug 2021 05:17:18 -0400 X-MC-Unique: MtjubO-eMWOOB7mz4njilQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 83515C7401; Wed, 11 Aug 2021 09:17:13 +0000 (UTC) Received: from localhost (unknown [10.39.192.118]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A1C05D9CA; Wed, 11 Aug 2021 09:17:03 +0000 (UTC) From: Cornelia Huck To: Jason Gunthorpe , David Airlie , Tony Krowiak , Alex Williamson , Christian Borntraeger , Jonathan Corbet , Daniel Vetter , Diana Craciun , dri-devel@lists.freedesktop.org, Eric Auger , Eric Farman , Harald Freudenberger , Vasily Gorbik , Heiko Carstens , intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, Jani Nikula , Jason Herne , Joonas Lahtinen , kvm@vger.kernel.org, Kirti Wankhede , linux-doc@vger.kernel.org, linux-s390@vger.kernel.org, Matthew Rosato , Peter Oberparleiter , Halil Pasic , Rodrigo Vivi , Vineeth Vijayan , Zhi Wang Cc: "Raj, Ashok" , Christoph Hellwig , Leon Romanovsky , Max Gurtovoy , Yishai Hadas , Zhenyu Wang Subject: Re: [PATCH v4 02/14] vfio/mbochs: Fix missing error unwind of mbochs_used_mbytes In-Reply-To: <2-v4-9ea22c5e6afb+1adf-vfio_reflck_jgg@nvidia.com> Organization: Red Hat GmbH References: <2-v4-9ea22c5e6afb+1adf-vfio_reflck_jgg@nvidia.com> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Wed, 11 Aug 2021 11:17:01 +0200 Message-ID: <8735rgwdbm.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Thu, Aug 05 2021, Jason Gunthorpe wrote: > Convert mbochs to use an atomic scheme for this like mtty was changed > into. The atomic fixes various race conditions with probing. Add the > missing error unwind. Also add the missing kfree of mdev_state->pages. > > Fixes: 681c1615f891 ("vfio/mbochs: Convert to use vfio_register_group_dev()") > Reported-by: Cornelia Huck > Co-developed-by: Alex Williamson > Reviewed-by: Christoph Hellwig > Signed-off-by: Jason Gunthorpe > --- > samples/vfio-mdev/mbochs.c | 24 +++++++++++++++--------- > 1 file changed, 15 insertions(+), 9 deletions(-) Reviewed-by: Cornelia Huck