From: Jonathan Corbet <corbet@lwn.net>
To: hjh <huangjianghui@uniontech.com>
Cc: Alex Shi <alex.shi@linux.alibaba.com>,
Harry Wei <harryxiyou@gmail.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PATCH Documentation translations:translate sound/hd-audio/controls to chinese
Date: Mon, 01 Mar 2021 14:16:36 -0700 [thread overview]
Message-ID: <8735xe4lsb.fsf@meer.lwn.net> (raw)
In-Reply-To: <20210301122019.80234-1-huangjianghui@uniontech.com>
hjh <huangjianghui@uniontech.com> writes:
> Signed-off-by: hjh <huangjianghui@uniontech.com>
> ---
> Documentation/translations/zh_CN/index.rst | 1 +
> .../zh_CN/sound/hd-audio/controls.rst | 102 ++++++++++++++++++
> .../zh_CN/sound/hd-audio/index.rst | 17 +++
> .../translations/zh_CN/sound/index.rst | 26 +++++
> 4 files changed, 146 insertions(+)
> create mode 100644 Documentation/translations/zh_CN/sound/hd-audio/controls.rst
> create mode 100644 Documentation/translations/zh_CN/sound/hd-audio/index.rst
> create mode 100644 Documentation/translations/zh_CN/sound/index.rst
So you have sent me two versions of this in the last 24 hours with no
indication of what has changed or why I should prefer one over the
other. Always include that information (under the "---" line) when you
send updated versions.
It looks like you got a Reviewed-by tag from Alex on the other version,
but that doesn't appear here; why?
[...]
> diff --git a/Documentation/translations/zh_CN/sound/hd-audio/index.rst b/Documentation/translations/zh_CN/sound/hd-audio/index.rst
> new file mode 100644
> index 000000000000..c287aad51066
> --- /dev/null
> +++ b/Documentation/translations/zh_CN/sound/hd-audio/index.rst
> @@ -0,0 +1,17 @@
> +.. include:: ../../disclaimer-zh_CN.rst
> +
> +:Original: :doc:`../../../../sound/hd-audio/index`
> +:Translator: Huang Jianghui <huangjianghui@uniontech.com>
> +
> +
> +高清音频
> +========
> +
> +.. toctree::
> + :maxdepth: 2
> +
> + notes
> + models
> + controls
> + dp-mst
> + realtek-pc-beep
So you list a bunch of files here, but most of them are not added in
your patch. That will, of course, break the docs build.
> diff --git a/Documentation/translations/zh_CN/sound/index.rst b/Documentation/translations/zh_CN/sound/index.rst
> new file mode 100644
> index 000000000000..42d86b361e42
> --- /dev/null
> +++ b/Documentation/translations/zh_CN/sound/index.rst
> @@ -0,0 +1,26 @@
Similarly, including the index.rst file at this level is good, but...
> +.. include:: ../disclaimer-zh_CN.rst
> +
> +:Original: :doc:`../../../sound/index`
> +:Translator: Huang Jianghui <huangjianghui@uniontech.com>
> +
> +
> +====================
> +Linux 声音子系统文档
> +====================
> +
> +.. toctree::
> + :maxdepth: 2
> +
> + kernel-api/index
> + designs/index
> + soc/index
> + alsa-configuration
> + hd-audio/index
> + cards/index
What are all of these files?
Please fix these issues and make sure that the docs build runs correctly
before resubmitting.
Thanks,
jon
next prev parent reply other threads:[~2021-03-01 21:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 12:20 [PATCH] PATCH Documentation translations:translate sound/hd-audio/controls to chinese hjh
2021-03-01 21:16 ` Jonathan Corbet [this message]
2021-03-02 3:22 ` huangjianghui
2021-03-02 7:34 ` Alex Shi
2021-03-02 9:13 ` huangjianghui
2021-03-04 2:58 ` Alex Shi
-- strict thread matches above, loose matches on Subject: below --
2021-03-04 9:45 hjh
2021-03-04 9:49 ` Alex Shi
2021-03-09 0:00 ` Jonathan Corbet
2021-03-01 3:03 hjh
2021-03-01 9:31 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735xe4lsb.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=alex.shi@linux.alibaba.com \
--cc=harryxiyou@gmail.com \
--cc=huangjianghui@uniontech.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).