Re: [PATCH v5 0/4] ALSA: usb-audio: improve module param quirk_flags

[Takashi Iwai <tiwai@suse.de>]

On Thu, 25 Sep 2025 11:25:15 +0200,
Cryolitia PukNgae via B4 Relay wrote:
> 
> As an implementation of what has been discussed previously[1].
> 
> 1. https://lore.kernel.org/all/87h5xm5g7f.wl-tiwai@suse.de/
> 
> Signed-off-by: Cryolitia PukNgae <cryolitia@uniontech.com>

Thanks for the new patch set.  In general the code change looks good.

But, could you provide a bit more information in the patch
description?  Ideally speaking, the patch description should suffice
to understand what's done in the commit without seeing the commit
change itself.

Also, please try to use guard() for mutex.


thanks,

Takashi

> ---
> Changes in v5:
> - Apply review comments. Thanks a lot, Takashi Iwai!
> - Link to v4: https://lore.kernel.org/r/20250918-sound-v4-0-82cf8123d61c@uniontech.com
> 
> Changes in v4:
> - Split basic parse and dynamic change
> - Drop usage of linked list
> - Link to v3: https://lore.kernel.org/r/20250917-sound-v3-0-92ebe9472a0a@uniontech.com
> 
> Changes in v3:
> - Instead of a new param, improve the existed one.
> - Link to v2: https://lore.kernel.org/r/20250912-sound-v2-0-01ea3d279f4b@uniontech.com
> 
> Changes in v2:
> - Cleaned up some internal rebase confusion, sorry for that
> - Link to v1: https://lore.kernel.org/r/20250912-sound-v1-0-cc9cfd9f2d01@uniontech.com
> 
> ---
> Cryolitia PukNgae (4):
>       ALSA: usb-audio: add two-way convert between name and bit for QUIRK_FLAG_*
>       ALSA: usb-audio: improve module param quirk_flags
>       ALSA: usb-audio: make param quirk_flags change-able in runtime
>       ALSA: doc: add docs about improved quirk_flags in snd-usb-audio
> 
>  Documentation/sound/alsa-configuration.rst | 108 +++++++++++------
>  sound/usb/card.c                           |  66 +++++++++--
>  sound/usb/quirks.c                         | 179 ++++++++++++++++++++++++++++-
>  sound/usb/quirks.h                         |  11 +-
>  sound/usb/usbaudio.h                       |  84 +++++++++-----
>  5 files changed, 376 insertions(+), 72 deletions(-)
> ---
> base-commit: 4c421c40c8b30ab7aae1edc7f7e294fcd33fc186
> change-id: 20250910-sound-a91c86c92dba
> 
> Best regards,
> -- 
> Cryolitia PukNgae <cryolitia@uniontech.com>
> 
>