From: Javier Martinez Canillas <javierm@redhat.com>
To: Mark Brown <broonie@kernel.org>, Manivannan Sadhasivam <mani@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Liam Girdwood <lgirdwood@gmail.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Randy Dunlap <rdunlap@infradead.org>,
"Steven Rostedt (Google)" <rostedt@goodmis.org>,
Tejun Heo <tj@kernel.org>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] regulator: core: Add option to prevent disabling unused regulators
Date: Thu, 02 Nov 2023 10:33:38 +0100 [thread overview]
Message-ID: <875y2kh53h.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <c1690b26-9004-4e5e-aa14-c61f679add12@sirena.org.uk>
Mark Brown <broonie@kernel.org> writes:
> On Wed, Nov 01, 2023 at 10:26:52AM +0530, Manivannan Sadhasivam wrote:
>
>> On the other note, I'm wondering if we could use sync_state() for handling the
>> regulator_init_complete() work. This would ensure that the regulators are only
>> disabled when all the consumers are probed.
>
> That assumes that everything defined in the DT both has a driver and has
> the driver available for the currently running kernel neither of which
> is a good assumption.
Agreed. I believe the current logic of disabling all regulators using a
workqueue is the correct thing to do.
The only better option I think is to make user-space notify the kernel
that it won't load kernel modules anymore. But the delayed work would
sill be needed, since the kernel can't make an assumption on whether
user-space will notify of this or not.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2023-11-02 9:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-28 10:24 [PATCH] regulator: core: Add option to prevent disabling unused regulators Javier Martinez Canillas
2023-10-28 16:04 ` Randy Dunlap
2023-10-30 14:53 ` Brian Masney
2023-11-01 4:56 ` Manivannan Sadhasivam
2023-11-01 13:09 ` Mark Brown
2023-11-02 9:33 ` Javier Martinez Canillas [this message]
2023-11-13 19:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y2kh53h.fsf@minerva.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=paulmck@kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox